[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020858#comment-16020858 ] Hudson commented on HBASE-18016: FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #244 (See [https://builds.apache.org/job/HBase-HBASE-14614/244/]) HBASE-18016 Changes to inherit default behavior of abort from (stack: rev c1b45a2c45f3bfeb2ec43e395cc2722975bfe39c) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18016.master.001.patch > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014428#comment-16014428 ] Umesh Agashe commented on HBASE-18016: -- Thanks [~stack] for reviewing and committing the patch. > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18016.master.001.patch > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013712#comment-16013712 ] Hudson commented on HBASE-18016: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3025 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3025/]) HBASE-18016 Changes to inherit default behavior of abort from (stack: rev c1b45a2c45f3bfeb2ec43e395cc2722975bfe39c) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18016.master.001.patch > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012730#comment-16012730 ] Umesh Agashe commented on HBASE-18016: -- Changes for this are dependent on changes for HBASE-18018. The patch can be committed only after patch for HBASE-18018 is committed. > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: HBASE-18016.master.001.patch > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003112#comment-16003112 ] Umesh Agashe commented on HBASE-18016: -- Thanks for your comments @stack! I have created a separate JIRA HBASE-18018 to change the default behavior for supporting abort of all procedures even if rollback is not supported/ implemented. Once we change the default behavior, we can change TruncateTableProcedure to fallback on default behavior. > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[
https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002005#comment-16002005
]
stack commented on HBASE-18016:
---
Agree that if you look at TruncateTableProcedure, it doesn't seem to make sense
adding an abort but fact is that Procedures will have corner cases.
In this case, what we saw was an infinite loop of the following:
{code}
2017-04-18 21:06:05,392 WARN
org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure: Retriable
error trying to truncate table=state=TRUNCATE_TABLE_CREATE_FS_LAYOUT
java.io.IOException: java.util.concurrent.ExecutionException:
java.io.IOException: The specified region already exists on disk:
hdfs://nameservice1/hbase/XX/.tmp/data/default/YY/b76c62fb69c0aa8e667adfd604a22c69
2017-04-18 21:06:05,176 WARN
org.apache.hadoop.hbase.regionserver.HRegionFileSystem: Trying to create a
region that already exists on disk:
hdfs://nameservice1/hbase/xx/.tmp/data/default/YYY/b76c62fb69c0aa8e667adfd604a22c69
{code}
Truncate had borked itself. The above condition is probably fixable... i.e.
Truncate should recognize this state where it has mangled events and deal
appropriately ... but ti will take a while till we have ironed out all corner
cases.
Meantime, operators should be able to kill/abort Procedures gone wild whatever
the reason.
> Implement abort for TruncateTableProcedure
> --
>
> Key: HBASE-18016
> URL: https://issues.apache.org/jira/browse/HBASE-18016
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
> Fix For: 2.0.0
>
>
> TruncateTableProcedure can not be aborted as abort is not implemented.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001723#comment-16001723 ] Umesh Agashe commented on HBASE-18016: -- bq. Currently, it is tricky and difficult (if not impossible) to undo deletions. [~syuanjiang], Thanks for your comments. I agree. Currently I am thinking that abort() can just abort/ kill the procedure with or without implementing rollback. We noticed that once in a while procedure gets stuck (in waiting state for an event thats never going to occur) and user can not do anything about it. Its stuck in the system forever. Implementing abort with or without rollback will help user clean up the stuck procedures. If procedure supports rollback, abort will trigger rollback or else user can manually cleanup after abort. Let me know your thoughts. > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18016) Implement abort for TruncateTableProcedure
[ https://issues.apache.org/jira/browse/HBASE-18016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001593#comment-16001593 ] Stephen Yuan Jiang commented on HBASE-18016: Currently, it is tricky and difficult (if not impossible) to undo deletions. That is why DeleteTableProcedure and TruncateTableProcedure has no rollback once starting. > Implement abort for TruncateTableProcedure > -- > > Key: HBASE-18016 > URL: https://issues.apache.org/jira/browse/HBASE-18016 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > > TruncateTableProcedure can not be aborted as abort is not implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
