[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020873#comment-16020873 ] Hudson commented on HBASE-18068: FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #244 (See [https://builds.apache.org/job/HBase-HBASE-14614/244/]) HBASE-18068 Fix flaky test TestAsyncSnapshotAdminApi (appy: rev 23ea2c36f52283631ce665e04f2af433fc25ae55) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncSnapshotAdminApi.java > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020562#comment-16020562 ] Zheng Hu commented on HBASE-18068: -- Sorry for the late rely. The patch looks good and thanks for the fix. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020133#comment-16020133 ] Hudson commented on HBASE-18068: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3058 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3058/]) HBASE-18068 Fix flaky test TestAsyncSnapshotAdminApi (appy: rev 23ea2c36f52283631ce665e04f2af433fc25ae55) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncSnapshotAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019803#comment-16019803 ] Appy commented on HBASE-18068: -- To reply to stack's question on RB: bq. Why the change to void2 and void3 in the below? Now that we are using lambdas, all we need to write is (a,b) -> {body.} . But that comes at a disadvantage, we don't have types of a and b there. Instead of using 'retX', if we use 'voidX', 'longX' etc, it at least makes it clearer what the types are. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) >
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019784#comment-16019784 ] Appy commented on HBASE-18068: -- Pushed to master. Thanks for reviews [~stack] and [~zghaobac]. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019385#comment-16019385 ] Hadoop QA commented on HBASE-18068: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 10s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 57s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 58s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 9s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 52s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 33m 4s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 26s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 124m 6s {color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 45s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 180m 34s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12869076/HBASE-18068.master.001.patch | | JIRA Issue | HBASE-18068 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux bdcb7e2715fc 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 709f5a1 | | Default Java | 1.8.0_131 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6871/testReport/ | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6871/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Fix flaky test TestAsyncSnapshotAdminApi >
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019157#comment-16019157 ] Appy commented on HBASE-18068: -- I triggered QA run manually. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019131#comment-16019131 ] Guanghao Zhang commented on HBASE-18068: +1. Wait the hadoop QA result. I can't change the status to patch available? [~appy] > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018198#comment-16018198 ] Appy commented on HBASE-18068: -- [~zheng hu] uploaded patch. Real bug fix is just 10 lines, rest is landscaping. [ReviewBoard|https://reviews.apache.org/r/59425/] > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-18068.master.001.patch > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016860#comment-16016860 ] Zheng Hu commented on HBASE-18068: -- You fix this issue please, and I'll fix HBASE-18003. Thanks. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016614#comment-16016614 ] Appy commented on HBASE-18068: -- If you do take it, assign it to yourself so i know that you're working on this, and I don't end up doing redundant work. [~openinx] I'll ping here again when i actually start working on this. (so feel free to take anytime before that if you want) > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016298#comment-16016298 ] Appy commented on HBASE-18068: -- [~openinx], don't have a patch yet. If you want it, feel free to take it! Otherwise i'll try a patch later today/tom. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015064#comment-16015064 ] Zheng Hu commented on HBASE-18068: -- If you have a fix for it , then go ahead please :) > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} > https://builds.apache.org/job/HBASE-Flaky-Tests/16152/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-18068) Fix flaky test TestAsyncSnapshotAdminApi
[ https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015060#comment-16015060 ] Zheng Hu commented on HBASE-18068: -- [~appy], TestAsyncSnapshotAdminApi is written by me, and after checking the code, I found the problem: a snapshot restore may be still in progress even though async admin.restoreSnapshot(..).get(), because it just submit a procedure and get the procedure Id returned (ut can pass in local desktop because restore is so quick). So , let me fix the bug. > Fix flaky test TestAsyncSnapshotAdminApi > > > Key: HBASE-18068 > URL: https://issues.apache.org/jira/browse/HBASE-18068 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0 > > > Test failures > {noformat} > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testRestoreSnapshot > > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: > org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: Restore already in > progress on the table=testRestoreSnapshot > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:854) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreSnapshot(SnapshotManager.java:818) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.restoreOrCloneSnapshot(SnapshotManager.java:780) > at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2324) > at > org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:133) > at org.apache.hadoop.hbase.master.HMaster.restoreSnapshot(HMaster.java:2320) > at > org.apache.hadoop.hbase.master.MasterRpcServices.restoreSnapshot(MasterRpcServices.java:1224) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testDeleteSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: > org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Rejected taking { > ss=snapshotName1 table=testDeleteSnapshots type=FLUSH } because we are > already running another snapshot on the same table { ss=snapshotName1 > table=testDeleteSnapshots type=FLUSH } > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.prepareToTakeSnapshot(SnapshotManager.java:440) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.snapshotEnabledTable(SnapshotManager.java:497) > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:598) > at > org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1299) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi.testListSnapshots > > org.apache.hadoop.hbase.snapshot.SnapshotDoesNotExistException: Snapshot > 'snapshotName2' doesn't exist on the filesystem > at > org.apache.hadoop.hbase.master.snapshot.SnapshotManager.deleteSnapshot(SnapshotManager.java:289) > at > org.apache.hadoop.hbase.master.MasterRpcServices.deleteSnapshot(MasterRpcServices.java:461) > at > org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:277) > at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:257) > > {noformat} >