[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041538#comment-16041538
 ] 

Hudson commented on HBASE-18149:


FAILURE: Integrated in Jenkins build HBase-2.0 #4 (See 
[https://builds.apache.org/job/HBase-2.0/4/])
HBASE-18149 The setting rules for table-scope attributes and (tedyu: rev 
3d721798c4a02b171d5395de59e3a449ed116177)
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb
* (edit) hbase-shell/src/test/ruby/hbase/admin_test.rb


> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch, HBASE-18149-master-v2.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041494#comment-16041494
 ] 

Hudson commented on HBASE-18149:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3153 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3153/])
HBASE-18149 The setting rules for table-scope attributes and (tedyu: rev 
492c3f8e205e94510f83944510ab67365a9f7f2d)
* (edit) hbase-shell/src/test/ruby/hbase/admin_test.rb
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb


> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch, HBASE-18149-master-v2.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041282#comment-16041282
 ] 

Hudson commented on HBASE-18149:


SUCCESS: Integrated in Jenkins build HBase-1.4 #766 (See 
[https://builds.apache.org/job/HBase-1.4/766/])
HBASE-18149 The setting rules for table-scope attributes and (tedyu: rev 
e94245331eaccaee0a9b2d75c3e4c08586a8b16a)
* (edit) hbase-shell/src/test/ruby/hbase/admin_test.rb
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb


> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 3.0.0, 1.4.0
>
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch, HBASE-18149-master-v2.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040790#comment-16040790
 ] 

Hadoop QA commented on HBASE-18149:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 1s 
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 1s 
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 49s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 15s {color} 
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
6s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 51s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12871821/HBASE-18149-master-v2.patch
 |
| JIRA Issue | HBASE-18149 |
| Optional Tests |  asflicense  javac  javadoc  unit  rubocop  ruby_lint  |
| uname | Linux 7b057068d875 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 4a1529c |
| Default Java | 1.8.0_131 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7130/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/7130/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7130/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7130/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch, HBASE-18149-master-v2.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3

[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Guangxu Cheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040750#comment-16040750
 ] 

Guangxu Cheng commented on HBASE-18149:
---

Resubmit master patch for HadoopQA.Thanks

> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch, HBASE-18149-master-v2.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040614#comment-16040614
 ] 

Ted Yu commented on HBASE-18149:


Can you submit master patch for another QA run ?
TestShell should pass.

> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040447#comment-16040447
 ] 

Hadoop QA commented on HBASE-18149:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 46s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 5s 
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 5s 
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 
56s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
39s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s 
{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s 
{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
20m 47s {color} | {color:green} The patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s 
{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s 
{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 53s 
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
11s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 31s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:395d9a0 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12871776/HBASE-18149-branch-1-v1.patch
 |
| JIRA Issue | HBASE-18149 |
| Optional Tests |  asflicense  javac  javadoc  unit  rubocop  ruby_lint  |
| uname | Linux 4d759ae369bc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1 / 381c89b |
| Default Java | 1.7.0_131 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_131 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7124/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7124/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.

[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-07 Thread Guangxu Cheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040382#comment-16040382
 ] 

Guangxu Cheng commented on HBASE-18149:
---

Submit branch-1 patch for HadoopQA

> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-branch-1-v1.patch, 
> HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-06 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040151#comment-16040151
 ] 

Ted Yu commented on HBASE-18149:


Mind attaching patch for branch-1 ?

> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-02 Thread Guangxu Cheng (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034475#comment-16034475
 ] 

Guangxu Cheng commented on HBASE-18149:
---

All tests pass locally. the failed test is unrelated to this jira.

> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3
>   
>  
> COLUMN FAMILIES DESCRIPTION   
>   
>  
> {NAME => 'f2', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', 
> KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 
> 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'false', 
> BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}
> 1 row(s) in 0.0720 seconds
> {code}
> *BLOCKCACHE* was in effect but *COMPACTION_ENABLED* didn't take effect.
> After checking code, I found that if the table-scope attributes value is 
> false, you need to enclose 'false' in single quotation marks while 
> family-scope is not required.
> so we should keep the consistent logic for table-scope and family-scope.
> the command alter also have the same problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (HBASE-18149) The setting rules for table-scope attributes and family-scope attributes should keep consistent

2017-06-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034154#comment-16034154
 ] 

Hadoop QA commented on HBASE-18149:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 34s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s 
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s 
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
39s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
64m 23s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 29s {color} 
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
11s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 92m 35s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestShell |
| Timed out junit tests | 
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12870912/HBASE-18149-master-v1.patch
 |
| JIRA Issue | HBASE-18149 |
| Optional Tests |  asflicense  javac  javadoc  unit  rubocop  ruby_lint  |
| uname | Linux 84e0d62030bb 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 5491714 |
| Default Java | 1.8.0_131 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7046/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/7046/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7046/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/7046/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> The setting rules for table-scope attributes and family-scope attributes 
> should keep consistent
> ---
>
> Key: HBASE-18149
> URL: https://issues.apache.org/jira/browse/HBASE-18149
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.0.0, 1.2.5
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18149-master-v1.patch
>
>
> I use the following command to create a table.
> {code}
> hbase(main):030:0> create 't3',{NAME => 'f2', BLOCKCACHE => false}, 
> {COMPACTION_ENABLED => false}
> An argument ignored (unknown or overridden): COMPACTION_ENABLED
> 0 row(s) in 1.1390 seconds
> hbase(main):031:0> describe 't3'
> Table t3 is ENABLED
> t3