[jira] [Commented] (HBASE-18371) [C++] Update folly and wangle dependencies
[ https://issues.apache.org/jira/browse/HBASE-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099423#comment-16099423 ] Xiaobing Zhou commented on HBASE-18371: --- Had one more run, it works by removing buck-out. +1 non-binding > [C++] Update folly and wangle dependencies > -- > > Key: HBASE-18371 > URL: https://issues.apache.org/jira/browse/HBASE-18371 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18371_v1.patch, hbase-18371_v2.patch, > hbase-18371_v3.patch > > > We need to update folly and wangle dependency versions. Debugging an issue, I > realized that we may need a couple of recent patches from wangle. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18371) [C++] Update folly and wangle dependencies
[
https://issues.apache.org/jira/browse/HBASE-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096967#comment-16096967
]
Enis Soztutar commented on HBASE-18371:
---
I think buck does not re-compile if the dependency libraries change. That's why
you should remove the buck generated files first I think. Can you please do
something like
{code}
rm -rf buck-out/
{code}
> [C++] Update folly and wangle dependencies
> --
>
> Key: HBASE-18371
> URL: https://issues.apache.org/jira/browse/HBASE-18371
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-18371_v1.patch, hbase-18371_v2.patch,
> hbase-18371_v3.patch
>
>
> We need to update folly and wangle dependency versions. Debugging an issue, I
> realized that we may need a couple of recent patches from wangle.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18371) [C++] Update folly and wangle dependencies
[
https://issues.apache.org/jira/browse/HBASE-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095598#comment-16095598
]
Xiaobing Zhou commented on HBASE-18371:
---
v3 LGTM, had a run of dock build, but there are many compile issues when the
following is tried:
{noformat}
buck test --no-cache --no-results-cache //core:retry-test
{noformat}
Could you double check it? Thanks.
> [C++] Update folly and wangle dependencies
> --
>
> Key: HBASE-18371
> URL: https://issues.apache.org/jira/browse/HBASE-18371
> Project: HBase
> Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: HBASE-14850
>
> Attachments: hbase-18371_v1.patch, hbase-18371_v2.patch,
> hbase-18371_v3.patch
>
>
> We need to update folly and wangle dependency versions. Debugging an issue, I
> realized that we may need a couple of recent patches from wangle.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18371) [C++] Update folly and wangle dependencies
[ https://issues.apache.org/jira/browse/HBASE-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095524#comment-16095524 ] Xiaobing Zhou commented on HBASE-18371: --- Thanks [~enis] for the work. The patch v2 fails to be applied due to conflict, could you please have a rebase? > [C++] Update folly and wangle dependencies > -- > > Key: HBASE-18371 > URL: https://issues.apache.org/jira/browse/HBASE-18371 > Project: HBase > Issue Type: Sub-task >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: HBASE-14850 > > Attachments: hbase-18371_v1.patch, hbase-18371_v2.patch > > > We need to update folly and wangle dependency versions. Debugging an issue, I > realized that we may need a couple of recent patches from wangle. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
