[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131055#comment-16131055 ] Hudson commented on HBASE-18420: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-18420 Some methods of Admin don't use ColumnFamilyDescriptor (chia7712: rev 7941b83aafc721034b885f635dcb50cfb23ed9eb) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch, HBASE-18420.v1.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096242#comment-16096242 ] Hudson commented on HBASE-18420: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3412 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3412/]) HBASE-18420 Some methods of Admin don't use ColumnFamilyDescriptor (chia7712: rev 7941b83aafc721034b885f635dcb50cfb23ed9eb) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch, HBASE-18420.v1.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096223#comment-16096223 ] Hudson commented on HBASE-18420: FAILURE: Integrated in Jenkins build HBase-2.0 #211 (See [https://builds.apache.org/job/HBase-2.0/211/]) HBASE-18420 Some methods of Admin don't use ColumnFamilyDescriptor (chia7712: rev f8fa04c71763334a0a515e7d8bceb9c4d86d9a8d) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch, HBASE-18420.v1.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095940#comment-16095940 ] Ted Yu commented on HBASE-18420: lgtm > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch, HBASE-18420.v1.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095833#comment-16095833
]
Hadoop QA commented on HBASE-18420:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
3s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18420 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12878302/HBASE-18420.v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 76b713809bb6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / af534ac |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7745/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7745/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Some methods of Admin don't use ColumnFamilyDescriptor
> --
>
> Key: HBASE-18420
> URL: https://issues.apache.org/jira/browse/HBASE-18420
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095455#comment-16095455 ] Mike Drob commented on HBASE-18420: --- Oooh, was not expecting javadoc errors. Yea, let's take care of those. > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095446#comment-16095446
]
Hadoop QA commented on HBASE-18420:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
22s{color} | {color:red} hbase-client generated 4 new + 0 unchanged - 0 fixed =
4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18420 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12878247/HBASE-18420.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2a1642691f7c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / bc93b66 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/7738/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7738/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7738/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Some methods of Admin don't use ColumnFamilyDescriptor
> --
>
> Key: HBASE-18420
> URL:
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095397#comment-16095397 ] Chia-Ping Tsai commented on HBASE-18420: bq. How do we check for folks adding the wrong method signature going forward? The HTableDescriptor and HColumnDescriptor are declared as @Deprecated so the committers should be extra vigilant before committing. :( > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor
[ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095370#comment-16095370 ] Mike Drob commented on HBASE-18420: --- +1 assuming no QA issues. How do we check for folks adding the wrong method signature going forward? > Some methods of Admin don't use ColumnFamilyDescriptor > -- > > Key: HBASE-18420 > URL: https://issues.apache.org/jira/browse/HBASE-18420 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18420.v0.patch > > > I overlooked them when committing HBASE-18241. > Admin class > ||Removed API||New API|| > |modifyColumnFamily(TableName, > HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)| > |modifyColumnFamilyAsync(TableName, > HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, > ColumnFamilyDescriptor)| > |addColumnFamilyAsync(TableName, > HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)| > These methods are introduced by HBASE-16519 and HBASE-1989. Both of them > belong to 2.0 so we can change the input arguments without worrying about any > compatibility issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
