[
https://issues.apache.org/jira/browse/HBASE-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120856#comment-16120856
]
Enis Soztutar commented on HBASE-18534:
---
Thanks Xiaobing for the patch.
- This is 10 seconds, please update the comment.
{code}
+/* sleeping one hour */
+std::this_thread::sleep_for(std::chrono::seconds(10));
{code}
- Let's save this in a class field rather than reading it for every RPC.
{code}
+ int read_rpc_timeout_ms =
conf_->GetInt(ConnectionConfiguration::kRpcReadTimeout,
+
ConnectionConfiguration::kDefaultRpcTimeout);
{code}
The patch looks like a good start. However, you need a TimeoutManager, or an
actual EventBase thread to execute the timeouts, no?
> [C++] Support timeout in Rpc
>
>
> Key: HBASE-18534
> URL: https://issues.apache.org/jira/browse/HBASE-18534
> Project: HBase
> Issue Type: Sub-task
>Reporter: Xiaobing Zhou
>Assignee: Xiaobing Zhou
> Attachments: HBASE-18534.000.patch, HBASE-18534.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
