[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-10-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195102#comment-16195102
 ] 

Hudson commented on HBASE-18845:


Results for branch HBASE-18467, done in 4 hr 24 min and counting
[build #136 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136/]: 
FAILURE

details (if available):

(x) *{color:red}-1 overall{color}*
Committer, please check your recent inclusion of a patch for this issue.

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//General_Nightly_Build_Report/]










(/) {color:green}+1 jdk8 checks{color}
-- For more information [see jdk8 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//JDK8_Nightly_Build_Report/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.



> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, 
> HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185801#comment-16185801
 ] 

Hudson commented on HBASE-18845:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3798 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3798/])
HBASE-18845 TestReplicationSmallTests fails after HBASE-14004 (zhangduo: rev 
239e6872674ff122ecec2d8d6a557b269e6ae54b)
* (edit) 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java


> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, 
> HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-29 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185725#comment-16185725
 ] 

Hudson commented on HBASE-18845:


FAILURE: Integrated in Jenkins build HBase-2.0 #597 (See 
[https://builds.apache.org/job/HBase-2.0/597/])
HBASE-18845 TestReplicationSmallTests fails after HBASE-14004 (zhangduo: rev 
2e4c1b62884026ba8fc2d743d33a7f9d9125393e)
* (edit) 
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java


> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, 
> HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-28 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185408#comment-16185408
 ] 

Duo Zhang commented on HBASE-18845:
---

Let me commit.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, 
> HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185358#comment-16185358
 ] 

Hadoop QA commented on HBASE-18845:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
28s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
25s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
42m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m  
5s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  6m 
51s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}167m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18845 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889625/HBASE-18845.master.001.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 932e6ca884a8 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / b5b4108 |
| Default Java

[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-28 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185258#comment-16185258
 ] 

Duo Zhang commented on HBASE-18845:
---

Oh missed this one... Thanks for picking this up sir. 

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, 
> HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185203#comment-16185203
 ] 

Hadoop QA commented on HBASE-18845:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
 4s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
50s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
42m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 55s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 
35s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
31s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}180m 47s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | 
org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy |
|   | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
|   | org.apache.hadoop.hbase.regionserver.TestCompaction |
|   | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
|   | org.apache.hadoop.hbase.master.TestMasterFailover |
|   | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
|   | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
|   | org.apache.hadoop.hbase.TestHBaseTestingUtility |
|   | org.apache.hadoop.hbase.wal.TestWALFiltering |
|   | org.apache.hadoop.hbase.replication.regionserver.TestWALEntry

[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-28 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184909#comment-16184909
 ] 

stack commented on HBASE-18845:
---

Trying to move this along (failing tests are a downer), rebased it because 
failed apply. Ran it and it passes.

Looking at the patch, 99% is refactoring using new API rather than old. +1 on 
commit (given this not a behavioral change, just a change in how UT is done).

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18845.master.001.patch, HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181766#comment-16181766
 ] 

Ted Yu commented on HBASE-18845:


Currently working on customer issue.
I don't have much bandwidth in completely validating the fix.

I ran the test with patch a few times yesterday which passed.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-26 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181746#comment-16181746
 ] 

Duo Zhang commented on HBASE-18845:
---

No, this is not a behavior change, it is just a UT trick. Obviously you do not 
understand what I'm saying...

So please just help verifying if the fix works for you.

Thanks.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181165#comment-16181165
 ] 

Ted Yu commented on HBASE-18845:


Is this a behavioral change (log roll) ?

Can you add release note to HBASE-14004 on this ?

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-25 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180115#comment-16180115
 ] 

Duo Zhang commented on HBASE-18845:
---

Any other concerns [~tedyu]? Thanks.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-25 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180017#comment-16180017
 ] 

Duo Zhang commented on HBASE-18845:
---

The replication will keep reading the same file if it is still opened for 
writing. In the old code, we determine if a file is still opened for writing by 
checking if it is the only one file in the replication queue, so inject a new 
file to the queue will make progress, and now this is changed, so if you want 
the replication queue to be advanced then you need to roll the WAL explicitly.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-25 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179283#comment-16179283
 ] 

Ted Yu commented on HBASE-18845:


{code}
+// determine if the file being replicated currently is still opened for 
write, so just inject a
+// new wal to the replication queue does not mean the previous file is 
closed.
{code}
What's the implication for the above during replication operations ?

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178651#comment-16178651
 ] 

Hadoop QA commented on HBASE-18845:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
14s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
20s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
39m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m 
32s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  6m 
33s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
31s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}181m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18845 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12888773/HBASE-18845.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux ae5ac45e8338 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / a5f8443 |
| Default Java | 1.8.0_14

[jira] [Commented] (HBASE-18845) TestReplicationSmallTests fails after HBASE-14004

2017-09-24 Thread Duo Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178509#comment-16178509
 ] 

Duo Zhang commented on HBASE-18845:
---

Also did some refactoring to remove warnings.

[~tedyu] Could you please verify if this patch works for you?

Thanks.

> TestReplicationSmallTests fails after HBASE-14004
> -
>
> Key: HBASE-18845
> URL: https://issues.apache.org/jira/browse/HBASE-18845
> Project: HBase
>  Issue Type: Bug
>  Components: Replication
>Affects Versions: 3.0.0, 2.0.0-alpha-3
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18845.patch
>
>
> testEmptyWALRecovery and testVerifyRepJob



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)