[jira] [Commented] (HBASE-18847) Remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177058#comment-16177058
]
Hudson commented on HBASE-18847:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #221 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/221/])
HBASE-18847 Remove unneeded synchronized block from HFileWriterV2 (chia7712:
rev 5e240625bfd4f9f22579bd949c755a934b03dcbf)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
> Remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) Remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176878#comment-16176878
]
Hudson commented on HBASE-18847:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #958 (See
[https://builds.apache.org/job/HBase-1.2-IT/958/])
HBASE-18847 Remove unneeded synchronized block from HFileWriterV2 (chia7712:
rev 5e240625bfd4f9f22579bd949c755a934b03dcbf)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
> Remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) Remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176858#comment-16176858
]
Hadoop QA commented on HBASE-18847:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
37s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
59s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}279m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}320m 56s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| Timed out junit tests |
org.apache.hadoop.hbase.master.TestMasterMetricsWrapper |
[jira] [Commented] (HBASE-18847) Remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176829#comment-16176829
]
Hudson commented on HBASE-18847:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #225 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/225/])
HBASE-18847 Remove unneeded synchronized block from HFileWriterV2 (chia7712:
rev 5e240625bfd4f9f22579bd949c755a934b03dcbf)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
> Remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) Remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176814#comment-16176814
]
Rich Howarth commented on HBASE-18847:
--
No problem. Thanks to Sean for helping me get set up
> Remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176794#comment-16176794
]
Chia-Ping Tsai commented on HBASE-18847:
Will commit it later.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176789#comment-16176789
]
Sean Busbey commented on HBASE-18847:
-
awesome! feel free to push at your convenience.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176774#comment-16176774
]
Chia-Ping Tsai commented on HBASE-18847:
Excluding TestExportSnapshot, all tests pass locally. The TestExportSnapshot
fails without patch. So +1
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176385#comment-16176385
]
Sean Busbey commented on HBASE-18847:
-
bq. Will run all tests locally.
Fair enough. :) I'll spin up a new build box to grind on them. Might as well do
that in parallel to precommit.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176374#comment-16176374
]
Chia-Ping Tsai commented on HBASE-18847:
bq. Anything other folks would like to see tested manually if precommit doesn't
come back?
Will run all tests locally.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176367#comment-16176367
]
Sean Busbey commented on HBASE-18847:
-
{quote}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{quote}
I'd say we don't need a test for this, since we're just changing a lock around
a log message and we don't have any framework for testing changes to logging
currently.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176363#comment-16176363
]
Sean Busbey commented on HBASE-18847:
-
I manually restarted the precommit job. If that fails out again, I plan to run
through all the hfile tests locally before accepting the patch. Anything other
folks would like to see tested manually if precommit doesn't come back?
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176158#comment-16176158
]
Anoop Sam John commented on HBASE-18847:
Patch LGTM. Given the reasoning, strict sync check and logging only once is
not really needed.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176156#comment-16176156
]
Chia-Ping Tsai commented on HBASE-18847:
Our QA are messed up now...:((see HBASE-18645). Please retry your patch. Thanks.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847-branch-1.2-00.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176147#comment-16176147
]
Hadoop QA commented on HBASE-18847:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
48s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
19s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 17s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}419m 32s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}462m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort |
|
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175515#comment-16175515
]
Hadoop QA commented on HBASE-18847:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-18847 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18847 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888375/HBASE-18847.v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8730/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Bug
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
> Attachments: HBASE-18847.v1.patch
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18847) remove unneeded synchronized block from hfilev2 warning in branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-18847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172830#comment-16172830
]
Anoop Sam John commented on HBASE-18847:
Nice find..
> remove unneeded synchronized block from hfilev2 warning in branch-1.2
> -
>
> Key: HBASE-18847
> URL: https://issues.apache.org/jira/browse/HBASE-18847
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 1.2.0, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6
>Reporter: Rich Howarth
>Assignee: Rich Howarth
>Priority: Critical
> Fix For: 1.2.7
>
>
> The below code block starts at line 277 of HFileWriterV2.java. Class-level
> synchronization in a heavily used code path has a demonstrably significant
> negative effect on performance. I tested forcing a major compaction with 18
> compaction threads per node; removing the synchronization resulted in an
> order of magnitude performance increase, with the bottleneck then being at
> the disks (where I want it to be).
> {code:java}
> synchronized (HFileWriterV2.class) {
> if (WARN_CELL_WITH_TAGS && getFileContext().isIncludesTags()) {
> LOG.warn("A minimum HFile version of " +
> HFile.MIN_FORMAT_VERSION_WITH_TAGS
> + " is required to support cell attributes/tags. Consider setting "
> + HFile.FORMAT_VERSION_KEY + " accordingly.");
> WARN_CELL_WITH_TAGS = false;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
