[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186795#comment-16186795 ] Yechao Chen commented on HBASE-18862: - attach same file to trigger hadoop qa > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.1-v1.patch, HBASE-18862-branch-1.2.patch, > HBASE-18862-branch-1.2-v1.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.3-v1.patch, HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186794#comment-16186794 ] Yechao Chen commented on HBASE-18862: - Test case failures are not relevant. manual steps to verify first :set fs.hdfs.impl.disable.cache=true or false in hbase-site.xml second: restart hm/rs > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186791#comment-16186791 ] Yechao Chen commented on HBASE-18862: - thank for review [~PankajKumar] > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178560#comment-16178560 ] Pankaj Kumar commented on HBASE-18862: -- +1, LGTM.. > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176604#comment-16176604
]
Hadoop QA commented on HBASE-18862:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 17m
45s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
7s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
46s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
17s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}371m 30s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}432m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRecoveredEdits |
| | hadoop.hbase.client.TestAdmin2 |
| | hadoop.hbase.util.TestHBaseFsck |
| Timed out
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176221#comment-16176221 ] Yu Li commented on HBASE-18862: --- bq. if the patch name is xxx-xxx-branch-1.patch. this means the patch will be apply to branch-1? Correct, and for branch-1.1, the patch should be named as HBASE-18862.branch-1.1.patch or so, including "branch-1.1" in its name. bq. the patch apply to the branch by "Fix Version" or patch name? HadoopQA checks patch name to decide which branch to apply it and run UT against. More relative topics please refer to our ref-guide: http://hbase.apache.org/book.html#developing > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176208#comment-16176208 ] Yechao Chen commented on HBASE-18862: - by the way , if the patch name is xxx-xxx-branch-1.patch. this means the patch will be apply to branch-1? why not apply to branch-1.1,1.2.1.3 ? the patch apply to the branch by "Fix Version" or patch name? > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176113#comment-16176113 ] Yechao Chen commented on HBASE-18862: - retry Hadoop QA > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.1.patch, > HBASE-18862-branch-1.2.patch, HBASE-18862-branch-1.3.patch, > HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[
https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176105#comment-16176105
]
Hadoop QA commented on HBASE-18862:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 12s{color}
| {color:red} HBASE-18862 does not apply to branch-1. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18862 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888459/HBASE-18862-branch-1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8738/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
> -
>
> Key: HBASE-18862
> URL: https://issues.apache.org/jira/browse/HBASE-18862
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 1.3.1, 1.2.6, 1.1.12
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Critical
> Fix For: 1.3.2, 1.2.7, 1.1.13
>
> Attachments: HBASE-18862-branch-1.patch
>
>
> HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176098#comment-16176098 ] Yechao Chen commented on HBASE-18862: - [~tedyu] [~pankaj2461] mind have a look this small patch ? thanks > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 1.3.1, 1.2.6, 1.1.12 >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Critical > Fix For: 1.3.2, 1.2.7, 1.1.13 > > Attachments: HBASE-18862-branch-1.patch > > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18862) apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3
[ https://issues.apache.org/jira/browse/HBASE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176080#comment-16176080 ] Yechao Chen commented on HBASE-18862: - HBASE-15109 just change in branch1.4 and branch-2 we met the same problem in branch 1.1.x，make HBASE-15109 apply to branch-1.1,branch-1.2,branch-1.3. our error log: 2017-09-22 10:50:20,053 FATAL [regionserver/x-y2/a.b.c.d:60020] regionserver.HRegionServer: ABORTING region server x-y2,60020,1506048613148: Unhandled: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@5d9559db java.lang.RuntimeException: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@5d9559db at org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204) at org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:882) at java.lang.Thread.run(Thread.java:745) > apply HBASE-15109 to branch-1.1,branch-1.2,branch-1.3 > - > > Key: HBASE-18862 > URL: https://issues.apache.org/jira/browse/HBASE-18862 > Project: HBase > Issue Type: Bug >Reporter: Yechao Chen >Assignee: Yechao Chen > > HBASE-15109 should apply to branch-1.1,branch-1.2,branch-1.3 also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
