[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206594#comment-16206594 ] Hudson commented on HBASE-18914: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3899 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3899/]) HBASE-18914 Remove AsyncAdmin's methods which were already deprecated in (zghao: rev 51489b2081102b02785c89b6a03d36f54e29657b) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncSnapshotAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch, HBASE-18914.master.002.patch, > HBASE-18914.master.003.patch, HBASE-18914.master.003.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206317#comment-16206317 ] Hudson commented on HBASE-18914: FAILURE: Integrated in Jenkins build HBase-2.0 #698 (See [https://builds.apache.org/job/HBase-2.0/698/]) HBASE-18914 Remove AsyncAdmin's methods which were already deprecated in (zghao: rev 58b0585d66b90d3cdf47da84c64f2912e1773934) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncSnapshotAdminApi.java > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch, HBASE-18914.master.002.patch, > HBASE-18914.master.003.patch, HBASE-18914.master.003.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205929#comment-16205929
]
Hadoop QA commented on HBASE-18914:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 52s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
40s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 24s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}166m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.TestMasterFailover |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.master.TestTableStateManager |
| | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
|
| |
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205565#comment-16205565 ] Guanghao Zhang commented on HBASE-18914: bq. We can get deleteTables/disableTables/enableTables back in 3.0 if users require these helper methods. Agree. Let me commit it later. :-) > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch, HBASE-18914.master.002.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205542#comment-16205542 ] Chia-Ping Tsai commented on HBASE-18914: +1 We can get deleteTables/disableTables/enableTables back in 3.0 if users require these helper methods. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch, HBASE-18914.master.002.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205463#comment-16205463 ] Guanghao Zhang commented on HBASE-18914: Ping [~chia7712]. Any comments about 002 patch? Thanks. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch, HBASE-18914.master.002.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204790#comment-16204790
]
Hadoop QA commented on HBASE-18914:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
6s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
42m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
49s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
2s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}171m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18914 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/1289/HBASE-18914.master.002.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d92c727263cb 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 240b4b1 |
| Default Java | 1.8.0_144 |
|
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204709#comment-16204709 ] Guanghao Zhang commented on HBASE-18914: Attach a 002 patch remove deleteTables/disableTables/enableTables. [~chia7712] I remove them because I can't find a good alternative name.. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch, > HBASE-18914.master.002.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204707#comment-16204707
]
Hadoop QA commented on HBASE-18914:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-18914 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18914 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892220/HBASE-18914.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9118/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove AsyncAdmin's methods which were already deprecated in Admin interface
>
>
> Key: HBASE-18914
> URL: https://issues.apache.org/jira/browse/HBASE-18914
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18914.master.001.patch,
> HBASE-18914.master.002.patch
>
>
> Since we are not release hbase 2.0 now, I thought it is ok to remove the
> methods which were already de deprecated in Admin interface.
> The methods which were marked as deprecated in HBASE-18241.
> HTableDescriptor[] deleteTables(Pattern)
> HTableDescriptor[] enableTables(Pattern)
> HTableDescriptor[] disableTables(Pattern)
> getAlterStatus()
> closeRegion()
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195697#comment-16195697 ] Guanghao Zhang commented on HBASE-18914: bq. should we introduce the alternative ways to replace the deprecated methods in Admin? I am +1 for Admin has same methods with AsyncAdmin in 2.0. This can be discussed in HBASE-18911 or a new issue. bq. They are ugly names but we must come up with a workaround. Yeah, these names is ugly.. If the pattern is null, it means delete all tables or no delete tables.. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195583#comment-16195583
]
Chia-Ping Tsai commented on HBASE-18914:
bq. only removed getAlterStatus and closeRegion methods.
The deleteTables/enableTables/disableTables are reserved in {{AsyncAdmin}}, so
should we introduce the alternative ways to replace the deprecated methods in
{{Admin}}? What about deleteAllTables/enableAllTables/disableAllTables? They
are ugly names but we must come up with a workaround.
> Remove AsyncAdmin's methods which were already deprecated in Admin interface
>
>
> Key: HBASE-18914
> URL: https://issues.apache.org/jira/browse/HBASE-18914
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18914.master.001.patch
>
>
> Since we are not release hbase 2.0 now, I thought it is ok to remove the
> methods which were already de deprecated in Admin interface.
> The methods which were marked as deprecated in HBASE-18241.
> HTableDescriptor[] deleteTables(Pattern)
> HTableDescriptor[] enableTables(Pattern)
> HTableDescriptor[] disableTables(Pattern)
> getAlterStatus()
> closeRegion()
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[
https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195572#comment-16195572
]
Hadoop QA commented on HBASE-18914:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
42m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m
25s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18914 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890846/HBASE-18914.master.001.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5de036b71e7f 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e2ad4c0 |
| Default Java | 1.8.0_144 |
|
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195499#comment-16195499 ] Guanghao Zhang commented on HBASE-18914: Attach a 001 patch only removed getAlterStatus and closeRegion methods. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18914.master.001.patch > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194546#comment-16194546 ] Chia-Ping Tsai commented on HBASE-18914: bq. The reason is the usage of HTableDescriptor. Are there any other reasons? # HTableDescriptor is deprecated # They can replace by other methods easily. # All admin operation we allow user to use should have an all-or-nothing effect. These deprecated APIs can't guarantee all table are in the same state finally. There may, however, be other folks that consider the helper methods is necessary. It is ok to add the alternative way - use the TableDescriptor as return type. > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18914) Remove AsyncAdmin's methods which were already deprecated in Admin interface
[ https://issues.apache.org/jira/browse/HBASE-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194533#comment-16194533 ] Guanghao Zhang commented on HBASE-18914: [~chia7712] The deleteTables/enableTables/disableTables methods were deprecated by HBASE-18241. The reason is the usage of HTableDescriptor. Are there any other reasons? > Remove AsyncAdmin's methods which were already deprecated in Admin interface > > > Key: HBASE-18914 > URL: https://issues.apache.org/jira/browse/HBASE-18914 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Since we are not release hbase 2.0 now, I thought it is ok to remove the > methods which were already de deprecated in Admin interface. > The methods which were marked as deprecated in HBASE-18241. > HTableDescriptor[] deleteTables(Pattern) > HTableDescriptor[] enableTables(Pattern) > HTableDescriptor[] disableTables(Pattern) > getAlterStatus() > closeRegion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
