[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205203#comment-16205203 ] Hudson commented on HBASE-18954: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3892 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3892/]) HBASE-18954 Make *CoprocessorHost classes private. (appy: rev 202e414eb2e9bf9c825b6ac64a9c2ae50e1dcf5d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/Export.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch, HBASE-18954.master.003.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205158#comment-16205158 ] Hudson commented on HBASE-18954: FAILURE: Integrated in Jenkins build HBase-2.0 #691 (See [https://builds.apache.org/job/HBase-2.0/691/]) HBASE-18954 Make *CoprocessorHost classes private. (appy: rev e04b15c68534500eb7af655a39fd5ae1dec3b3d2) * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/security/access/SecureBulkLoadEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/SecureTestUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * (edit) hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/Export.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController3.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch, HBASE-18954.master.003.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205091#comment-16205091 ] Appy commented on HBASE-18954: -- Thanks for the review [~anoop.hbase]. Pushed to master and branch-2. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch, HBASE-18954.master.003.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205071#comment-16205071 ] Anoop Sam John commented on HBASE-18954: +1 > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch, HBASE-18954.master.003.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204996#comment-16204996
]
Hadoop QA commented on HBASE-18954:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 42s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m
53s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
24s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}154m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18954 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892237/HBASE-18954.master.003.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6590523d3aef 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 240b4b1 |
| Default Java | 1.8.0_144 |
|
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204872#comment-16204872 ] Appy commented on HBASE-18954: -- v3 Removed getCoprocessorHost from Region and Store interfaces. [~anoop.hbase] > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch, HBASE-18954.master.003.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203142#comment-16203142 ] Anoop Sam John commented on HBASE-18954: Region also having this getCoprocessorHost(). Did not remove that as the discussion was here in this jira. We should get rid of getCoprocessorHost() from Region and Store. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197758#comment-16197758 ] Appy commented on HBASE-18954: -- Sounds good. Will do. I see a bunch of getCoprocessorHost() in other places too. Will clean then up too. However, expect next patch with a bit of delay, 1-2 days, busy with other reviews. Thanks. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch, > HBASE-18954.master.002.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195824#comment-16195824
]
Chia-Ping Tsai commented on HBASE-18954:
Making *CoprocessorHost IA.Private means that they are internal use only, yet
user can get the {{RegionCoprocessorHost}} via {{Store#getCoprocessorHost}}.
Maybe {{Store#getCoprocessorHost}} should be removed.
> Make *CoprocessorHost classes private
> -
>
> Key: HBASE-18954
> URL: https://issues.apache.org/jira/browse/HBASE-18954
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Appy
>Assignee: Appy
> Labels: incompatible
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18954.master.001.patch,
> HBASE-18954.master.002.patch
>
>
> Move out configuration name constants (into Coprocessor class?) and made Host
> classes private.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195554#comment-16195554
]
Hadoop QA commented on HBASE-18954:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m
48s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18954 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890836/HBASE-18954.master.002.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux eb9b2dcbc0a9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / e2ad4c0 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8985/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8985/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195409#comment-16195409 ] Appy commented on HBASE-18954: -- Since we are leaving conf constants be, let me just change annotation from IA.LimitedPrivate to IA.Private. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194879#comment-16194879 ] stack commented on HBASE-18954: --- CoprocessorConfigurations.java is missing license and class comment on its intent (CoprocessorConfigurations is a generic name; you want to say something about who the configs are for, the audience? And yeah, as per Anoop, missing an Audience annotation). Agree, *Host should be private (I see over in RSGroups where it is using Host to call CPs not sure how to undo that just yet -- smile). > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194247#comment-16194247 ] Anoop Sam John commented on HBASE-18954: Oh I see.. Did not read all comments carefully. Just read the patch.. Yep +1. No need to expose at Code levels. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194237#comment-16194237 ] Appy commented on HBASE-18954: -- I agree. That's the option 3 in my last comment - not expose the confs since they are supposed to be used via xml. So you agree that i should move them in respective context, right? > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194220#comment-16194220 ] Anoop Sam John commented on HBASE-18954: On the confs added to new class CoprocessorConfigurations - U want to make this class exposed to CPs (As the original one , the Host , is made private now)? (The new class is missing the InterfaceAudience now) But why we have to expose this? All these confs being used in the conf.xml file by the user only right? I mean why a CP user has to know this constant ? For dynamic loading of CPs, we have APIs right? So am not very sure why these confs to be exposed as a Class level. Yes these are exposed but that is at the conf xml file and all the config names are exposed ones. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18954.master.001.patch > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194143#comment-16194143
]
Hadoop QA commented on HBASE-18954:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 84 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
38s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}113m
54s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
6s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
40s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
5s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
3s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 1m
32s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}227m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18954 |
| JIRA Patch
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194008#comment-16194008 ] Appy commented on HBASE-18954: -- At first, i moved all the config name variables to Coprocessor class. Was about to submit the patch, but then moving these constants to hbase-client package seemed bad because that's adding unnecessary dependency edge between two modules. Second thought was, moving them to a new and separate CoprocessorConfigs class in hbase-server/o/a/h/h/coprocessor i.e. next to CoprocessorHost, but that is the same pattern as HConstants, and the one we regret. In the end, it seems like it's best to keep these configs close to the context they are used. So basically, "hbase.coprocessor.region.classes" should go in the RegionCpHost. What do others think? [~Apache9], [~anoopsamjohn] [~stack] It should either be option 2, if exposing it to third party is important, or option 3, if you think that confs are for hbase-site.xml and not exposing as constants is fine. > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193994#comment-16193994 ] Appy commented on HBASE-18954: -- Interesting, MasterCpHost and WALCpHost are already IA.Private. Only CpHost, RegionCpHost, and RegionServerCpHost are IA.LimitedPrivate > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy >Assignee: Appy > Labels: incompatible > Fix For: 2.0.0-alpha-4 > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[
https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193950#comment-16193950
]
Appy commented on HBASE-18954:
--
So in MasterCoprocessorEnvironment, we give out MasterServices which is marked
Private (being tackled in HBASE-12260). And MasterServices gives out
{{MasterCoprocessorHost getMasterCoprocessorHost()}}. So basically, CP
implementations were able to get hold of hosts. Not good!
However, that jira is removing master CP getter. :)
Figuring out what needs to be moved out of *CpHost into separate LimitedPrivate
zone so that we an make these hosts private.
> Make *CoprocessorHost classes private
> -
>
> Key: HBASE-18954
> URL: https://issues.apache.org/jira/browse/HBASE-18954
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Appy
> Fix For: 2.0.0-alpha-4
>
>
> Move out configuration name constants (into Coprocessor class?) and made Host
> classes private.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18954) Make *CoprocessorHost classes private
[ https://issues.apache.org/jira/browse/HBASE-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193451#comment-16193451 ] Appy commented on HBASE-18954: -- fyi: [~Apache9] [~anoopsamjohn] > Make *CoprocessorHost classes private > - > > Key: HBASE-18954 > URL: https://issues.apache.org/jira/browse/HBASE-18954 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Appy > Fix For: 2.0.0-alpha-4 > > > Move out configuration name constants (into Coprocessor class?) and made Host > classes private. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
