[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197179#comment-16197179
]
Sean Busbey commented on HBASE-18957:
-
{quote}For stuff like filters, no harm a comment or method javadoc saying what
is expected... Can add on commit.{quote}
FilterList with an OR operator seems to be self explanatory already. The
current regression is a bug AFAICT.
{quote}
Then the change in FilterList, is that part of the revert you and Peter are
talking of doing?
Thats odd, that there are two mentions of
a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java in
the patch. Am I reading it wrong? (First there is removal of some breaks, then
there is more substantial change)
{quote}
Any changes to FilterList are a part of reverts. Peter's patch only adds a test
(and at that a test that can be used without changing starting in branch-1.1).
There are multipleinstances of FilterList because the patch is up to 6 commits
depending on the branch (patch w/test plus a commit per thing reverted) so that
they're straight-forward to track.
e.g. here's what master changes look like on my local repo (that's the branch
with the most reverts):
{code}
* 6abd43fba5 - (HEAD -> HBASE-18957) Revert "HBASE-17678 FilterList with
MUST_PASS_ONE may lead to redundant cells returned" (45 minutes ago)
* 00816870d5 - Revert "HBASE-17678 FilterList with MUST_PASS_ONE lead to
redundancy cells returned - addendum" (45 minutes ago)
* 33d40a82be - Revert "HBASE-15410 Utilize the max seek value when all Filters
in MUST_PASS_ALL FilterList return SEEK_NEXT_USING_HINT" (45 minutes ago)
* 49bbe00877 - Revert "HBASE-18160 Fix incorrect logic in
FilterList.filterKeyValue" (45 minutes ago)
* e900149a38 - Revert "HBASE-18904 Missing break in NEXT_ROW case of
FilterList#mergeReturnCodeForOrOperator()" (45 minutes ago)
* 0587c50298 - HBASE-18957 establish filter test that shows current behavior of
OR operator on FamilyFilters. (45 minutes ago)
* e2cef8aa80 - (origin/master, origin/HEAD) HBASE-18752 Recalculate the
TimeRange in flushing snapshot to store file (6 hours ago)
* fcdf96a0e8 - HBASE-18958 Removed the IS annotation from
SpaceLimitingException (16 hours ago)
{code}
> add test that establishes branch-1 behavior for filterlist w/OR and revert as
> needed to make it pass.
> -
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Sean Busbey
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch,
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch,
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on
> OR prior to our filterlist improvements so we have a baseline to show
> compatibility (and/or document incompatibilities that end up being
> introduced).
> Specifically (paraphrased from HBASE-18368 description): Using 2
> FamilyFilters in a FilterList using MUST_PASS_ONE operator should return
> results that match either of the FamilyFilters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197116#comment-16197116 ] stack commented on HBASE-18957: --- bq. Maybe also I should update the JIRA subject to say the same? Yeah. No harm. For stuff like filters, no harm a comment or method javadoc saying what is expected... Can add on commit. Then the change in FilterList, is that part of the revert you and Peter are talking of doing? Thats odd, that there are two mentions of a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java in the patch. Am I reading it wrong? (First there is removal of some breaks, then there is more substantial change) > add test that establishes branch-1 behavior for filterlist w/OR and revert as > needed to make it pass. > - > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). > Specifically (paraphrased from HBASE-18368 description): Using 2 > FamilyFilters in a FilterList using MUST_PASS_ONE operator should return > results that match either of the FamilyFilters. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197096#comment-16197096 ] Sean Busbey commented on HBASE-18957: - bq. Is there description of what "branch-1 behavior for filterlist w/OR" should be? Thanks. Updated the description with: bq. Specifically (paraphrased from HBASE-18368 description): Using 2 FamilyFilters in a FilterList using MUST_PASS_ONE operator should return results that match either of the FamilyFilters. Sound good? That's the only behavior the test checks for. Maybe also I should update the JIRA subject to say the same? > add test that establishes branch-1 behavior for filterlist w/OR and revert as > needed to make it pass. > - > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). > Specifically (paraphrased from HBASE-18368 description): Using 2 > FamilyFilters in a FilterList using MUST_PASS_ONE operator should return > results that match either of the FamilyFilters. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197089#comment-16197089 ] stack commented on HBASE-18957: --- Is there description of what "branch-1 behavior for filterlist w/OR" should be? Thanks. > add test that establishes branch-1 behavior for filterlist w/OR and revert as > needed to make it pass. > - > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196984#comment-16196984 ] Sean Busbey commented on HBASE-18957: - Looking through the unit test failures, I don't think any of them are related. I think it's just our current problems with precommit getting really bad performance whenever the hbase-server module has to be tested. > add test that establishes branch-1 behavior for filterlist w/OR and revert as > needed to make it pass. > - > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR and revert as needed to make it pass.
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196978#comment-16196978 ] Sean Busbey commented on HBASE-18957: - I made a feature version for HBASE-18410 now, which I'll use for fixVersion on impacted jiras that move to the feature branch. > add test that establishes branch-1 behavior for filterlist w/OR and revert as > needed to make it pass. > - > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196973#comment-16196973 ] Sean Busbey commented on HBASE-18957: - Linking to-be-reverted-and-placed-on-feature-branch issues. > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196965#comment-16196965
]
Sean Busbey commented on HBASE-18957:
-
{quote}
-1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
Use git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply
{quote}
This looks legit. Weird that it's only on master. I'll clean this up before
pushing.
> add test that establishes branch-1 behavior for filterlist w/OR
> ---
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Sean Busbey
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch,
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch,
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on
> OR prior to our filterlist improvements so we have a baseline to show
> compatibility (and/or document incompatibilities that end up being
> introduced).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196961#comment-16196961 ] Sean Busbey commented on HBASE-18957: - bq. Should we link this to the revertible issues? Good idea. I'll do that now. > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195811#comment-16195811 ] Mike Drob commented on HBASE-18957: --- Should we link this to the revertible issues? > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195585#comment-16195585
]
Hadoop QA commented on HBASE-18957:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
33s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
2s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
12s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
19s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 19m
32s{color} | {color:red} The patch causes 178 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
51s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}402m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} |
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195374#comment-16195374
]
Hadoop QA commented on HBASE-18957:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
33s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
18s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m
14s{color} | {color:red} The patch causes 140 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}296m 14s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}336m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
|
| | hadoop.hbase.regionserver.TestRecoveredEdits |
| | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
| Timed out junit tests |
org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS |
| |
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195322#comment-16195322
]
Hadoop QA commented on HBASE-18957:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
71m 10s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
25s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 34s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
51s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}236m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestModifyNamespaceProcedure |
| Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption |
| | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| |
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195310#comment-16195310
]
Sean Busbey commented on HBASE-18957:
-
{quote}
-1 hadoopcheck 29m 49s The patch causes 178 errors with Hadoop
v3.0.0-alpha4.
{quote}
this is HBASE-18934
{quote}
Reason Tests
Timed out junit tests
org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder
{quote}
Let me take a look on if this relies on filters or something.
> add test that establishes branch-1 behavior for filterlist w/OR
> ---
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
>Reporter: Sean Busbey
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch,
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch,
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on
> OR prior to our filterlist improvements so we have a baseline to show
> compatibility (and/or document incompatibilities that end up being
> introduced).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195293#comment-16195293 ] Sean Busbey commented on HBASE-18957: - branch-1.1 and branch-1.3 both use the branch-1.2 patch with no reverts. > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch, > HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195270#comment-16195270
]
Hadoop QA commented on HBASE-18957:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
19s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
30s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
47s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
8s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
6s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
20s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
7s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
55s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
54s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 29m
49s{color} | {color:red} The patch causes 178 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
29s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
15s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
51s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
51s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 50m 55s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194994#comment-16194994 ] Sean Busbey commented on HBASE-18957: - branch-2 uses the same patch for the test as master and has the same reverted JIRAs (though their commit refs are different). > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch, HBASE-18957-master.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194854#comment-16194854 ] Peter Somogyi commented on HBASE-18957: --- +1 > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch, > HBASE-18957-branch-1.2.v1.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18957) add test that establishes branch-1 behavior for filterlist w/OR
[ https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194790#comment-16194790 ] Peter Somogyi commented on HBASE-18957: --- The indentation is off in some of the lines. Could you fix that? +1 if that is solved. > add test that establishes branch-1 behavior for filterlist w/OR > --- > > Key: HBASE-18957 > URL: https://issues.apache.org/jira/browse/HBASE-18957 > Project: HBase > Issue Type: Sub-task > Components: Filters >Reporter: Sean Busbey >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18957-branch-1.2.v0.patch > > > we need a test that shows the expected behavior for filter lists that rely on > OR prior to our filterlist improvements so we have a baseline to show > compatibility (and/or document incompatibilities that end up being > introduced). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
