[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-04 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239328#comment-16239328
 ] 

Hudson commented on HBASE-19027:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3998 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3998/])
HBASE-19027 Honor the CellComparator of ScanInfo in scanning over a (chia7712: 
rev 35a2b8e53c357f217280e4a136148ac03276d753)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestScanWildcardColumnTracker.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java


> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch, 
> HBASE-19027.v2.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-04 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239126#comment-16239126
 ] 

Hudson commented on HBASE-19027:


FAILURE: Integrated in Jenkins build HBase-2.0 #797 (See 
[https://builds.apache.org/job/HBase-2.0/797/])
HBASE-19027 Honor the CellComparator of ScanInfo in scanning over a (chia7712: 
rev b464c1eb35c4c147c4eb0901fb901677e2817caa)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestScanWildcardColumnTracker.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java


> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch, 
> HBASE-19027.v2.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-04 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239051#comment-16239051
 ] 

Chia-Ping Tsai commented on HBASE-19027:


Will commit it later.

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch, 
> HBASE-19027.v2.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-03 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237156#comment-16237156
 ] 

Chia-Ping Tsai commented on HBASE-19027:


[~mdrob] Any concerns?

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch, 
> HBASE-19027.v2.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-03 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237155#comment-16237155
 ] 

Hadoop QA commented on HBASE-19027:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
44s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
5s{color} | {color:red} hbase-server: The patch generated 1 new + 41 unchanged 
- 0 fixed = 42 total (was 41) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
46m 11s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m 
21s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}157m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19027 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12895556/HBASE-19027.v2.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 4e870a4c0739 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e79a007dd9 |
| Default Java | 1.8.0_141 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9590/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9590/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9590/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Honor the CellComparator of ScanInfo in scanning over a store
>

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-02 Thread ramkrishna.s.vasudevan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237105#comment-16237105
 ] 

ramkrishna.s.vasudevan commented on HBASE-19027:


LGTM. +1.

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch, 
> HBASE-19027.v2.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-02 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236884#comment-16236884
 ] 

Chia-Ping Tsai commented on HBASE-19027:


bq. Please add javadoc for the new parameter.
copy that.

bq. Will scan info always have a comparator? It looks like yes, but I didn't 
follow through on all the code paths. Should we default back to the store 
comparator if there isn't one.
The matcher in {{StoreScanner}} uses the {{CellComparator}} from {{ScanInfo}}, 
hence the {{StoreScanner}} should do the same as matcher.

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-11-02 Thread Mike Drob (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236354#comment-16236354
 ] 

Mike Drob commented on HBASE-19027:
---

bq. +  public ScanWildcardColumnTracker(int minVersion, int maxVersion, long 
oldestUnexpiredTS, CellComparator comparator) {
Please add javadoc for the new parameter.

Will scan info always have a comparator? It looks like yes, but I didn't follow 
through on all the code paths. Should we default back to the store comparator 
if there isn't one.

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-10-30 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225266#comment-16225266
 ] 

Chia-Ping Tsai commented on HBASE-19027:


Ping for reviews. 

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch, HBASE-19027.v1.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-10-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223775#comment-16223775
 ] 

Hadoop QA commented on HBASE-19027:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
 4s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
25s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
56m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m 
50s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 10s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19027 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894596/HBASE-19027.v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 7778bc70d649 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e5e2bde87b |
| Default Java | 1.8.0_141 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9477/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9477/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
>

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-10-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223720#comment-16223720
 ] 

Hadoop QA commented on HBASE-19027:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
57s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
48s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
49m 30s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m 
28s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
18s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}165m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19027 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894576/HBASE-19027.v0.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 4e5acf3a4d72 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 281bbc40c5 |
| Default Java | 1.8.0_141 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9472/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9472/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
>

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-10-28 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223659#comment-16223659
 ] 

Chia-Ping Tsai commented on HBASE-19027:


bq. Is the reference to ScanInfo necessary ?
You are right. Storing only the comparator is more suitable. Will address ur 
comment in next patch.

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19027) Honor the CellComparator of ScanInfo in scanning over a store

2017-10-28 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223650#comment-16223650
 ] 

Ted Yu commented on HBASE-19027:


For StoreScanner.java, ScanInfo is stored in a variable but only comparator is 
used.
Is the reference to ScanInfo necessary ?

> Honor the CellComparator of ScanInfo in scanning over a store
> -
>
> Key: HBASE-19027
> URL: https://issues.apache.org/jira/browse/HBASE-19027
> Project: HBase
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19027.v0.patch
>
>
> All components in the scan path should honor the cell comparator from 
> scaninfo rather than arbitrarily choose the comparator from store, scaninfo, 
> or static COMPARATOR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)