[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241254#comment-16241254
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-2.0 #809 (See
[https://builds.apache.org/job/HBase-2.0/809/])
HBASE-19131 (Addendum) Use the emptyList() to replace EMPTY_LIST (chia7712: rev
43b4aab6485a9cb2c4c2db62d5e5fb533f827f52)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241243#comment-16241243
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4009 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4009/])
HBASE-19131 (Addendum) Use the emptyList() to replace EMPTY_LIST (chia7712: rev
33ede55164421b40c0bfe1c9d47c1db6701265c2)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240825#comment-16240825
]
Chia-Ping Tsai commented on HBASE-19131:
bq. Let me revert the changes.
done
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240770#comment-16240770
]
Chia-Ping Tsai commented on HBASE-19131:
bq. Why change from Collections.emptyList to Collections.EMPTY_LIST?
I would rather use the code to say "I don't want to have a new list here".
However, it is just my philosophy which is unrelated to this issue. Let me
revert the changes. Thanks for the suggestions. [~mdrob]
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240496#comment-16240496
]
Mike Drob commented on HBASE-19131:
---
Why change from Collections.emptyList to Collections.EMPTY_LIST?
>From the javadoc:
bq. Implementation note: Implementations of this method need not create a
separate List object for each call. Using this method is likely to have
comparable cost to using the like-named field. (Unlike this method, the field
does not provide type safety.)
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239771#comment-16239771
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-1.4 #996 (See
[https://builds.apache.org/job/HBase-1.4/996/])
HBASE-19131 Add the ClusterStatus hook and cleanup other hooks which can
(apurtell: rev 152672f03b68d2bd427cede7a3994b3a35c8d2bc)
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* (edit) hbase-protocol/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239727#comment-16239727
]
Hudson commented on HBASE-19131:
SUCCESS: Integrated in Jenkins build HBase-1.4 #995 (See
[https://builds.apache.org/job/HBase-1.4/995/])
Revert "HBASE-19131 Add the ClusterStatus hook and cleanup other hooks
(apurtell: rev 7148982a607ac4b4c510f8a76ea06510812c92af)
* (edit) hbase-protocol/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* (delete)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239690#comment-16239690
]
Chia-Ping Tsai commented on HBASE-19131:
bq. Actually I have to reapply this to branch-1.4, otherwise the RPC changes
that are added and removed in branch-1 would be released in 1.4.
Thanks!
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239682#comment-16239682
]
Chia-Ping Tsai commented on HBASE-19131:
bq. Ok. In the future I strongly recommend explaining things like this when
committing changes that would be breaking changes if they had been released,
because none of us are aware of every single commit to every single branch and
their release status. Otherwise this may happen again.
Sorry for troubling you.
bq. So keeping this out of 1.4 would be good for me,
The hbase1 client should be able to connect to hbase2 server, so we should
revert this from all branchs for wire compatibility. I will file another issue
to introduce the ClusterStatus hook.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239680#comment-16239680
]
Andrew Purtell commented on HBASE-19131:
Actually I have to reapply this to branch-1.4, otherwise the RPC changes that
are added and removed in branch-1 would be released in 1.4.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239676#comment-16239676
]
Andrew Purtell commented on HBASE-19131:
bq. The ListDeadServersRequest, which is introduced by HBASE-18131, is megred
to branch-1/branch-1.4 which are not released,
Ok. In the future I strongly recommend explaining things like this when
committing changes that would be breaking changes if they had been released,
because none of us are aware of every single commit to every single branch and
their release status. Otherwise this may happen again.
I also don't like the additional breakage in the coprocessor APIs after I've
already filed two JIRAs to work through compatibility concerns for the 1.4
release. So keeping this out of 1.4 would be good for me, so I don't have to do
that analysis again, but I have no strong objection to a reapplication.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239674#comment-16239674
]
Chia-Ping Tsai commented on HBASE-19131:
bq. This changes the wire protocol by removing support for
ListDeadServersRequest, so is an inappropriate change for branch-1 and
branch-1.4.
The ListDeadServersRequest, which is introduced by HBASE-18131, is megred to
branch-1/branch-1.4 which are not released, so the changes should be fine i
think. [~apurtell] Would you please help me to understand your concerns?
Thanks.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239672#comment-16239672
]
Andrew Purtell commented on HBASE-19131:
I have reverted this from branch-1.4. It should probably be reverted from
branch-1 too but we can discuss it. The rest of the changes look ok. Put back
support for this RPC, but deprecate it, and my concern will be resolved.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239671#comment-16239671
]
Andrew Purtell commented on HBASE-19131:
This changes the wire protocol by removing support for ListDeadServersRequest,
so is an inappropriate change for branch-1 and branch-1.4. What happens when a
client issues a ListDeadServersRequest to an upgraded server? Some kind of
error. Does it break the client functionality? I expect so. Was this change
tested in this kind of scenario?
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239452#comment-16239452
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-2.0 #800 (See
[https://builds.apache.org/job/HBase-2.0/800/])
HBASE-19131 Add the ClusterStatus hook and cleanup other hooks which can
(chia7712: rev d592b29619fb6c4d65e45ade9fb595947d2480fc)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit) src/main/asciidoc/_chapters/appendix_acl_matrix.adoc
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239439#comment-16239439
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4000 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4000/])
HBASE-19131 Add the ClusterStatus hook and cleanup other hooks which can
(chia7712: rev 2085958216281a0df56393f3d40b464ef2a81245)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
* (edit) src/main/asciidoc/_chapters/appendix_acl_matrix.adoc
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
* (edit) hbase-protocol-shaded/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239408#comment-16239408
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-1.4 #994 (See
[https://builds.apache.org/job/HBase-1.4/994/])
HBASE-19131 Add the ClusterStatus hook and cleanup other hooks which can
(chia7712: rev 9ad69e446529e5b48595063039ef58730e9fd842)
* (edit) hbase-protocol/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239401#comment-16239401
]
Hudson commented on HBASE-19131:
FAILURE: Integrated in Jenkins build HBase-1.5 #137 (See
[https://builds.apache.org/job/HBase-1.5/137/])
HBASE-19131 Add the ClusterStatus hook and cleanup other hooks which can
(chia7712: rev 56fd75e8e2e1467e757aec9975dc6f82f3303554)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientClusterStatus.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit)
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterAndRegionObserver.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit)
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/ClusterStatusChore.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) hbase-protocol/src/main/protobuf/Master.proto
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch,
> HBASE-19131.branch-1.v1.patch, HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239031#comment-16239031
]
Chia-Ping Tsai commented on HBASE-19131:
The build died again. Will run the build locally..
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.branch-1.v0.patch, HBASE-19131.v0.patch,
> HBASE-19131.v1.patch, HBASE-19131.v2.patch, HBASE-19131.v3.patch,
> HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238733#comment-16238733
]
Chia-Ping Tsai commented on HBASE-19131:
The failed tests pass locally. Will submit the patch for branch-1.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238709#comment-16238709
]
Reid Chan commented on HBASE-19131:
---
+1
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238696#comment-16238696
]
Guanghao Zhang commented on HBASE-19131:
+1
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238497#comment-16238497
]
Hadoop QA commented on HBASE-19131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 6m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} hbase-client: The patch generated 0 new + 768
unchanged - 8 fixed = 768 total (was 776) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} hbase-server: The patch generated 0 new + 368
unchanged - 3 fixed = 368 total (was 371) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} root: The patch generated 0 new + 1136 unchanged -
11 fixed = 1136 total (was 1147) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
5m 16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}138m 34s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}245m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue |
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238129#comment-16238129
]
stack commented on HBASE-19131:
---
+1
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch, HBASE-19131.v4.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237186#comment-16237186
]
Hadoop QA commented on HBASE-19131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 10m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 7m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} hbase-client: The patch generated 0 new + 764
unchanged - 15 fixed = 764 total (was 779) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} hbase-server: The patch generated 0 new + 366
unchanged - 5 fixed = 366 total (was 371) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
49s{color} | {color:red} root: The patch generated 1 new + 1129 unchanged - 21
fixed = 1130 total (was 1150) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
52m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
4m 56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}122m 30s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}230m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19131 |
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237049#comment-16237049
]
Reid Chan commented on HBASE-19131:
---
bq. resolve the checkstyle warnings
Yah, the {{import layout}} in "checkstyle" should keep consistency with code
base, or there are plenty of unnecessary changes on imports.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237032#comment-16237032
]
Chia-Ping Tsai commented on HBASE-19131:
bq. while i prefer not to rearrange import packages order, though it is mostly
IDE's fault.
The imports changes is due to checkstyle warnings. I handle the import warnings
via IDE so it also reorders the imports. I can manually make a minimum changes
of imports to resolve the checkstyle warnings. Perhaps we should file a issue
to optimize the imports at once.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237023#comment-16237023
]
Reid Chan commented on HBASE-19131:
---
Looks good overall, while i prefer not to rearrange import packages order,
though it is mostly IDE's fault.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch, HBASE-19131.v3.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236389#comment-16236389
]
Hadoop QA commented on HBASE-19131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
57s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} hbase-client: The patch generated 0 new + 764
unchanged - 15 fixed = 764 total (was 779) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} hbase-server: The patch generated 0 new + 366
unchanged - 5 fixed = 366 total (was 371) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
48s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}123m 55s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
48s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}209m 3s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236227#comment-16236227
]
stack commented on HBASE-19131:
---
bq. Binary compatibility can be broken on major release, hence it is ok to
change the returned type to subclass. It doesn't break the API compatibility.
My concern is a hbase1 client being able to go against an hbase2 cluster. The
query will go via a protobuf convertion... so should be ok.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235887#comment-16235887
]
Chia-Ping Tsai commented on HBASE-19131:
[~zghaobac] https://reviews.apache.org/r/63512/
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 1.4.0, 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch,
> HBASE-19131.v2.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235653#comment-16235653
]
Chia-Ping Tsai commented on HBASE-19131:
bq. The listDeadServers() can be implemented as a default method in
Admin/AsyncAdmin interface. The patch didn't upload to review board, right? I
can help to review.
Copy that!
bq. Is it ok changing the return from Collection to List? ClusterStatus is
public. We are changing the signature.
Binary compatibility can be broken on major release, hence it is ok to change
the returned type to subclass. It doesn't break the API compatibility.
bq. Is listDeadServers an API that was in branch-1?
Yes. will update the {{fix version}} for this issue.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235229#comment-16235229
]
Hadoop QA commented on HBASE-19131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} hbase-client: The patch generated 0 new + 637
unchanged - 7 fixed = 637 total (was 644) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
11s{color} | {color:red} hbase-server: The patch generated 40 new + 365
unchanged - 6 fixed = 405 total (was 371) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}180m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem ||
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235223#comment-16235223
]
stack commented on HBASE-19131:
---
Is it ok changing the return from Collection to List? ClusterStatus is public.
We are changing the signature.
public List getDeadServerNames() {
Is listDeadServers an API that was in branch-1?
Skimmed patch. Looks great. Thanks.
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235106#comment-16235106
]
Guanghao Zhang commented on HBASE-19131:
The listDeadServers() can be implemented as a default method in
Admin/AsyncAdmin interface.
The patch didn't upload to review board, right? I can help to review. :-)
> Add the ClusterStatus hook and cleanup other hooks which can be replaced by
> ClusterStatus hook
> --
>
> Key: HBASE-19131
> URL: https://issues.apache.org/jira/browse/HBASE-19131
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
>Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19131.v0.patch, HBASE-19131.v1.patch
>
>
> This issue will add the hook for {{ClusterStatus}} and cleanup other hooks
> which can be replaced by {{ClusterStatus}} hook.
> # {{ListDeadServers}} - introduced by HBASE-18131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19131) Add the ClusterStatus hook and cleanup other hooks which can be replaced by ClusterStatus hook
[
https://issues.apache.org/jira/browse/HBASE-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233803#comment-16233803
]
Hadoop QA commented on HBASE-19131:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
39s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} hbase-client: The patch generated 2 new + 641
unchanged - 3 fixed = 643 total (was 644) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
8s{color} | {color:red} hbase-server: The patch generated 4 new + 301 unchanged
- 1 fixed = 305 total (was 302) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
48m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}106m
34s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
52s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}187m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19131 |
| JIRA Patch URL |
