[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284579#comment-16284579 ] Hudson commented on HBASE-19180: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4192 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4192/]) HBASE-19180 Removed unused imports from AlwaysPasses (jan.hentschel: rev 114b62e637bf4aff1873cc20f87888f514f40079) * (edit) hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284312#comment-16284312 ] Jan Hentschel commented on HBASE-19180: --- Pushed to master, branch-2, branch-1 and branch-1.4. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268741#comment-16268741 ] Jan Hentschel commented on HBASE-19180: --- I meant the Checkstyle reports contain a lot more errors than just the errors related to unused imports, but you're right, uploading the reports wasn't really worth it. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268737#comment-16268737 ] Mike Drob commented on HBASE-19180: --- bq. because the reports contain a lot more errors I'm not seeing that? I see a handful of unused imports in both reports you upload, probably not worth including the reports on the jira if you are uploading a patch too. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268725#comment-16268725 ] Jan Hentschel commented on HBASE-19180: --- I started adding sub-tasks to HBASE-12521 (see HBASE-19360 and HBASE-19362) for each module. I attached a report from IntelliJ instead from the Checkstyle report, because the reports contain a lot more errors, which maybe could also be added as tickets. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258342#comment-16258342 ] Chia-Ping Tsai commented on HBASE-19180: bq. Chia-Ping Tsai I already had HBASE-17663 for this half a year ago, but I would guess that this one is way out of date. I would close it, because it handles the whole code base, instead of breaking it down into smaller pieces. We can put it as sub-tasks into HBASE-12521. Any update? > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241668#comment-16241668 ] Jan Hentschel commented on HBASE-19180: --- [~chia7712] I already had HBASE-17663 for this half a year ago, but I would guess that this one is way out of date. I would close it, because it handles the whole code base, instead of breaking it down into smaller pieces. We can put it as sub-tasks into HBASE-12521. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239286#comment-16239286 ] Chia-Ping Tsai commented on HBASE-19180: bq. I would suggest that we file an umbrella issue for that and sub-tasks for the different modules (or on package basis, depending on the size of the module). Doing it through the whole codebase would make backports more complicated. Had this once with a similar task. +1 on both of idea and patch. HBASE-12521? > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239283#comment-16239283 ] Jan Hentschel commented on HBASE-19180: --- I would suggest that we file an umbrella issue for that and sub-tasks for the different modules (or on package basis, depending on the size of the module). Doing it through the whole codebase would make backports more complicated. Had this once with a similar task. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239276#comment-16239276 ] Chia-Ping Tsai commented on HBASE-19180: Personally, I prefer filing a issue to optimize the imports for all java files at once. > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Trivial > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[
https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239035#comment-16239035
]
Hadoop QA commented on HBASE-19180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} hbase-build-support/hbase-error-prone: The patch
generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
60m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
12s{color} | {color:green} hbase-error-prone in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19180 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896050/HBASE-19180.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 39dbe8a1fea5 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ac6b998afe |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_141 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9621/testReport/ |
| modules | C: hbase-build-support/hbase-error-prone U:
hbase-build-support/hbase-error-prone |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9621/console |
|
[jira] [Commented] (HBASE-19180) Remove unused imports from AlwaysPasses
[ https://issues.apache.org/jira/browse/HBASE-19180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239015#comment-16239015 ] Mike Drob commented on HBASE-19180: --- +1 > Remove unused imports from AlwaysPasses > --- > > Key: HBASE-19180 > URL: https://issues.apache.org/jira/browse/HBASE-19180 > Project: HBase > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Jan Hentschel >Assignee: Jan Hentschel > Attachments: HBASE-19180.master.001.patch > > > The class org.apache.hadoop.hbase.errorprone.AlwaysPasses currently has some > unused imports, which should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
