[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253352#comment-16253352
 ] 

Hudson commented on HBASE-19235:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4056 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4056/])
HBASE-19235 CoprocessorEnvironment should be exposed to CPs. (anoopsamjohn: rev 
7d704874423fbb387ef3251db220d5d2455e343d)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorHost.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEnvironment.java


> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch, 
> HBASE-19235_V3.patch, HBASE-19235_V3.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253206#comment-16253206
 ] 

Hudson commented on HBASE-19235:


FAILURE: Integrated in Jenkins build HBase-2.0 #855 (See 
[https://builds.apache.org/job/HBase-2.0/855/])
HBASE-19235 CoprocessorEnvironment should be exposed to CPs. (anoopsamjohn: rev 
a1d86d90ba9f57051223558cf7177076829871bc)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEnvironment.java
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorHost.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java


> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch, 
> HBASE-19235_V3.patch, HBASE-19235_V3.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252965#comment-16252965
 ] 

stack commented on HBASE-19235:
---

+1 for v3.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch, 
> HBASE-19235_V3.patch, HBASE-19235_V3.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Chia-Ping Tsai (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252958#comment-16252958
 ] 

Chia-Ping Tsai commented on HBASE-19235:


+1

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch, 
> HBASE-19235_V3.patch, HBASE-19235_V3.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252710#comment-16252710
 ] 

Appy commented on HBASE-19235:
--

Seems to be turning into bikeshed. I am fine with latest v3 mainly because I 
think it's probably better to have bad code internally than have users deal 
with the confusion (if those are the only two options).

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch, 
> HBASE-19235_V3.patch, HBASE-19235_V3.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252147#comment-16252147
 ] 

Hadoop QA commented on HBASE-19235:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  7m 
25s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
17s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
59m 23s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}122m  6s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
27s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}212m 18s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12897586/HBASE-19235_V3.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 2a8c5ec58f2f 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e0580b20d1 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit | 

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251699#comment-16251699
 ] 

Hadoop QA commented on HBASE-19235:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  8m 
 7s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
28s{color} | {color:red} hbase-server: The patch generated 1 new + 40 unchanged 
- 0 fixed = 41 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
10s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
73m 29s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
1s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 16s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
32s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 56s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestCoprocessorHost |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12897557/HBASE-19235_V3.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 49e71c583d20 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / e0580b20d1 |
| maven | version: Apache Maven 3.5.2 

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251200#comment-16251200
 ] 

Anoop Sam John commented on HBASE-19235:


If we have to avoid the instance of check while calling startup or shutdown, we 
have to change
public abstract class CoprocessorHost>
Note  BaseEnvironment instead of CoprocessorEnvironment.

Subsequently we will have to make changes in all CPHost impls.  Now we have
RegionServerCoprocessorHost extends CoprocessorHost 
RegionCoprocessorHost  extends CoprocessorHost 
Like these.

I feel all these changes will be much more ugly than having an instance of 
check.  Infact we need all our internal impls of the CPEnv to be extending 
BaseEnv.  So we can even have just an assert and type casting way.. In future 
any one make a new impl of CPEnv not extending BaseEnv, this will break any way.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250897#comment-16250897
 ] 

stack commented on HBASE-19235:
---

I should say that in my chat w/ [~appy] , he said we should write up what we 
decide about IA inheritance so we clear what to do next time we run into it. I 
like how [~chia7712] calls it: "It makes sense to me that sub-class can always 
narrow the declaration (ex. IA.Public -> IA.Private/IA.LP)..." Added 
HBASE-19254 to write up our understanding here.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250785#comment-16250785
 ] 

Anoop Sam John commented on HBASE-19235:


Appy.  IMHO #2 is not at all good.  Am not sure any other place we have like 
super interface is private and sub type as LP or public.  I did not check.  If 
so, we have to fix. I raised this issue after seeing a patch in Phoenix.   The 
sub interfaces are LP exposed. So any functions available to it, can be called 
by user.  Else the CP user has to really check in which interface it is 
declared and see its declaration. It will be very difficult task and confusing 
for sure.
Ya we were having CPEnv interface as private till now. But we can cleanup now. 
Better late than never.
I understood Chia comment to avoid the instance of check. Let me see. I thought 
we can make it simple. Like in old way.  Let me see.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Chia-Ping Tsai (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250632#comment-16250632
 ] 

Chia-Ping Tsai commented on HBASE-19235:


bq. I misunderstood the suggestion above. BaseEnvironment is internal... yeah, 
could be good to refer directly to it internally.
I try to avoid the instanceof checks.

bq. if we should allow it so super class can have different IA from subclass. 
Suggested we take that up elsewhere, especially if we can turn up another 
example where a super IA.Private when children are IA.LP or public would be 
convenient.
It makes sense to me that sub-class can always narrow the declaration (ex. 
IA.Public -> IA.Private/IA.LP). Widening the declaration is like a issue we 
need to fix. 

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250463#comment-16250463
 ] 

stack commented on HBASE-19235:
---

[~chia7712] [~anoop.hbase]
bq. My sense is there is nothing that requires that a CP implement 
BaseEnironment and besides it is IA.Private.

I misunderstood the suggestion above. BaseEnvironment is internal... yeah, 
could be good to refer directly to it internally.

On [~appy] comment, we chatted offline. Appy is interested in the broader issue 
of IA labelling and if we should allow it so super class can have different IA 
from subclass. Suggested we take that up elsewhere, especially if we can turn 
up another example where a super IA.Private when children are IA.LP or public 
would be convenient.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250429#comment-16250429
 ] 

Appy commented on HBASE-19235:
--

Oh, i said "let's clean this up" earlier but forgot to make an alternative 
suggestion:
If we have this in multiple places i.e. child public but parent private, let's 
try to find a global solution first? We can either:
1) Make all parent's public 
2) Explicitly say in our docs how these labels are to be interpreted w.r.t. 
inheritance.
(Any other way am missing?)
I think both of the above solutions will tackle the overall problem, but one 
makes more sense than other (at least to me ..smile) since there will be parent 
interfaces we just can't make public.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250414#comment-16250414
 ] 

Appy commented on HBASE-19235:
--

bq. My sense is there is nothing that requires that a CP implement 
BaseEnironment and besides it is IA.Private.

No CP have to/should implement any Env interface. Env is how Hbase manages CPs  
and all implementations are strictly internal. Even if a CP extends Env, that'd 
be waste since we ask CP for only observers & service (for eg. 
MasterCp#getMasterObserver) and anything more is not used.

I guess the issue is very legit, if even we have different interpretations of 
whether parent interfaces are included, user's are definitely gonna be 
confused. Let's clean this up.
I am fine with making it public. But what's seems unsettling to me here is that 
it has been Private all the way till now, and has been seen/edited and 
functions added to it what that expectation. And now we are just exposing all 
of them out? Isn't that counter to all our cleanup effort in past few months - 
'don't expose stuff unless required'.
Sorry for making it difficult [~anoop.hbase], i totally understand the 
motivation here, it's confusing for users and needs fixing, but just making it 
Public seems like shooting ourself in the foot.




> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250335#comment-16250335
 ] 

stack commented on HBASE-19235:
---

bq. It seems all CPEnvs extend the BaseEnvironment. What about using the 
BaseEnvironment directly in private scope? Make the CoprocessorEnvironment be a 
cp-only interface.

[~anoop.hbase] See the [~chia7712] comment above.

My sense is there is nothing that requires that a CP implement BaseEnironment 
and besides it is IA.Private.

I'd be +1 on the patch (fix checkstyle on commit).

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250140#comment-16250140
 ] 

Appy commented on HBASE-19235:
--

sg.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249356#comment-16249356
 ] 

Hadoop QA commented on HBASE-19235:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
51s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
9s{color} | {color:red} hbase-server: The patch generated 1 new + 40 unchanged 
- 0 fixed = 41 total (was 40) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 7s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
60m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
5s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}134m 
47s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
30s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}226m 30s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12897285/HBASE-19235_V2.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 6bb1caca8a0c 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 1ba7cc2164 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle | 

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Chia-Ping Tsai (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249268#comment-16249268
 ] 

Chia-Ping Tsai commented on HBASE-19235:


It seems all CPEnvs extend the {{BaseEnvironment}}. What about using the 
{{BaseEnvironment}} directly in private scope? Make the CoprocessorEnvironment 
be a cp-only interface.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249132#comment-16249132
 ] 

Anoop Sam John commented on HBASE-19235:


Ya I too feel #2 is fine.

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248630#comment-16248630
 ] 

stack commented on HBASE-19235:
---

Options:

 # The [~appy] interpretation of IA.Private on superclass means superclass 
methods are not for CPs (I think this too much attention-to-detail to expect of 
users...)
 # Hiding the problematic as per Anoop's suggestion that we restore the old 
hackery?
 # Just mark CP as LP and if a CP calls shutdown, they are shooting themselves 
in the foot (Annotate IA.Private?)

I like option #2.


> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247278#comment-16247278
 ] 

Anoop Sam John commented on HBASE-19235:


I see now..  The startup and shutdown were there in Environment only(Now 
BaseEnv)  . All 4 types of  CPEnv impls are sub types of BaseEnv.  Previously 
we were doing type casting and call these 2 methods.
{code}
if (env instanceof Environment) {
  ((Environment)env).startup();
}
if (e instanceof Environment) {
  if (LOG.isDebugEnabled()) {
LOG.debug("Stop coprocessor " + e.getInstance().getClass().getName());
  }
  ((Environment)e).shutdown();
}
{code}
I think we can continue this way. Its ok and so avoid these 2 APIs being 
exposed to CPs

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Anoop Sam John (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247230#comment-16247230
 ] 

Anoop Sam John commented on HBASE-19235:


>From ObserverContext the CP user get RegionCPEnv. This is marked LP for CP and 
>any functions available there can be used . That is what we say.  So all 
>functions from super type is already exposed right?   Checking other CP 
>exposed interfaces, I see we have their super type also as LP not private.  We 
>should some way clean this.  Discussed with Stack offline. We both felt its ok 
>to expose..   We have some getters which might not be really needed for CPs 
>but harmless to expose. Start and Shutdown are some thing which should not be 
>used by CP users.  Start() even if called it is a noop in impl.  Shutdown ya...
Checking some old code base, we did not have these start and shutdown over in 
CoprocessorEnvironment.  Seems some recent jira added this..  Why? We can even 
avoid. Ya I see this startup was there in CPHost .

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247183#comment-16247183
 ] 

Appy commented on HBASE-19235:
--

CPHosts use CPEnv to load and manage CP instances.
The functions startup(), shutdown(), loadSequence(), getPriority(), 
getInstance, etc are all related to management of a loaded Coprocessor. No 
observer needs them. Also we'll want to freely add/remove functions here. 

bq. Its sub interfaces are exposed with 
LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions in 
this are.
Is this how our audience annotations are interpreted? To me, i always saw it 
like, IA.Foo on a class/interface is for that class/interface only, it doesn't 
translate to parent.
In fact in this case, we have explicitly marked CPEnv as Private, so there 
shouldn't be any confusion?

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247182#comment-16247182
 ] 

Hadoop QA commented on HBASE-19235:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 3s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
64m 20s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  
8s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 84m 55s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12897022/HBASE-19235.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 27240e75313d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 35a1e43348 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9730/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9730/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> CoprocessorEnvironment should be exposed to CPs
> 

[jira] [Commented] (HBASE-19235) CoprocessorEnvironment should be exposed to CPs

[Rajeshbabu Chintaguntla (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247063#comment-16247063
 ] 

Rajeshbabu Chintaguntla commented on HBASE-19235:
-

[~anoop.hbase] +1. 

> CoprocessorEnvironment should be exposed to CPs
> ---
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
>  Issue Type: Sub-task
>  Components: Coprocessors
>Affects Versions: 2.0.0-alpha-4
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)