[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[
https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266162#comment-16266162
]
Chia-Ping Tsai commented on HBASE-19240:
Sorry for missing this jira.
{quote}
attached branch-1 patch which was only the parts the didn't have any conflicts.
for anything that did have conflicts, i left the code unchanged on the
assumption that because the base is different we will need to review it
separately anyway.
{quote}
Let me file a jira to complete the fixes for branch-1. see HBASE-19348
> Fix error-prone errors, part four?
> --
>
> Key: HBASE-19240
> URL: https://issues.apache.org/jira/browse/HBASE-19240
> Project: HBase
> Issue Type: Bug
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 1.5.0, 2.0.0-beta-1
>
> Attachments: HBASE-19240.branch-1.patch,
> HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250856#comment-16250856 ] Hudson commented on HBASE-19240: FAILURE: Integrated in Jenkins build HBase-1.4 #1013 (See [https://builds.apache.org/job/HBase-1.4/1013/]) HBASE-19240 more error-prone results (apurtell: rev 626d74f79a3d663850ab9c75f5bb0621bb82483d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverForAddingMutationsFromCoprocessors.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerNonceManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250834#comment-16250834 ] Hudson commented on HBASE-19240: FAILURE: Integrated in Jenkins build HBase-1.5 #154 (See [https://builds.apache.org/job/HBase-1.5/154/]) HBASE-19240 more error-prone results (apurtell: rev dbcda15ae71ddcec1e380ed88d1307e12d2da055) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerNonceManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverForAddingMutationsFromCoprocessors.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250687#comment-16250687 ] Andrew Purtell commented on HBASE-19240: Looking at this now > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250245#comment-16250245 ] Mike Drob commented on HBASE-19240: --- Jenkins has been having issues today... going to manually try to start a build. > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249912#comment-16249912 ] Andrew Purtell commented on HBASE-19240: I'm going to be back in this area working on HBASE-19239 later today. Will apply this first and check it that way if we don't have precommit results first. > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, > HBASE-19240.branch-1.v2.patch, HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249134#comment-16249134 ] Hudson commented on HBASE-19240: FAILURE: Integrated in Jenkins build HBase-2.0 #846 (See [https://builds.apache.org/job/HBase-2.0/846/]) HBASE-19240 more error-prone results (mdrob: rev cd681f26bc27c2f5d6386060d456e233568044b4) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestCachedMobFile.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureSchedulerConcurrency.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverForAddingMutationsFromCoprocessors.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/VersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerNonceManager.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, HBASE-19240.patch, > HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[
https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249057#comment-16249057
]
Hadoop QA commented on HBASE-19240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 15 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
58s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
36s{color} | {color:red} branch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
27s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
35s{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_141.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 35s{color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0_141. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
33s{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_151.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 33s{color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
22s{color} | {color:red} hbase-rest: The patch generated 5 new + 0 unchanged -
0 fixed = 5 total (was 0) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} hbase-it: The patch generated 0 new + 0 unchanged -
16 fixed = 0 total (was 16) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
37s{color} | {color:red} patch has 16 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
37s{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.0. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
35s{color} | {color:red} The patch causes 16 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
32s{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.0. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
32s{color} | {color:red} The patch causes 16 errors with Hadoop v2.5.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
30s{color} | {color:red} The patch
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249047#comment-16249047 ] Andrew Purtell commented on HBASE-19240: +1 assuming tests pass > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, HBASE-19240.patch, > HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249041#comment-16249041 ] Mike Drob commented on HBASE-19240: --- attached branch-1 patch which was only the parts the didn't have any conflicts. for anything that did have conflicts, i left the code unchanged on the assumption that because the base is different we will need to review it separately anyway. > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 1.5.0, 2.0.0-beta-1 > > Attachments: HBASE-19240.branch-1.patch, HBASE-19240.patch, > HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248671#comment-16248671 ] Hudson commented on HBASE-19240: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4038 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4038/]) HBASE-19240 more error-prone results (stack: rev c87189d41888b504489492181dee486886414513) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationEndpoint.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerNonceManager.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverForAddingMutationsFromCoprocessors.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/VersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestMasterProcedureSchedulerConcurrency.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestCachedMobFile.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Fix For: 3.0.0 > > Attachments: HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248641#comment-16248641 ] stack commented on HBASE-19240: --- +1 > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19240.patch, HBASE-19240.v2.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[
https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248636#comment-16248636
]
Hadoop QA commented on HBASE-19240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 26 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
38s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
12s{color} | {color:red} hbase-server: The patch generated 1 new + 621
unchanged - 1 fixed = 622 total (was 622) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} hbase-endpoint: The patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} hbase-it: The patch generated 0 new + 1 unchanged -
16 fixed = 1 total (was 17) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} hbase-rest: The patch generated 8 new + 18 unchanged -
1 fixed = 26 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 30s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}109m
28s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
15s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
26s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black}
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[
https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248285#comment-16248285
]
Hadoop QA commented on HBASE-19240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 26 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
56s{color} | {color:red} hbase-server: The patch generated 11 new + 621
unchanged - 1 fixed = 632 total (was 622) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} hbase-endpoint: The patch generated 0 new + 0
unchanged - 1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} hbase-it: The patch generated 0 new + 1 unchanged -
16 fixed = 1 total (was 17) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
13s{color} | {color:red} hbase-rest: The patch generated 4 new + 18 unchanged -
1 fixed = 22 total (was 19) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 49s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
11s{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 31s{color}
| {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} |
[jira] [Commented] (HBASE-19240) Fix error-prone errors, part four?
[ https://issues.apache.org/jira/browse/HBASE-19240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248122#comment-16248122 ] Andrew Purtell commented on HBASE-19240: Thanks [~mdrob] [~chia7712]. Over on HBASE-19239 I'm making a pass over important findbugs issues and most error-prone issues in branch-1 / branch-1.4. Done with hbase-common. Working on hbase-client. Will post the result to reviewboard, and a separate patch for each module to the JIRA. > Fix error-prone errors, part four? > -- > > Key: HBASE-19240 > URL: https://issues.apache.org/jira/browse/HBASE-19240 > Project: HBase > Issue Type: Bug >Reporter: Mike Drob >Assignee: Mike Drob > Attachments: HBASE-19240.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
