[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251035#comment-16251035
]
Hudson commented on HBASE-19249:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #2028 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/2028/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
434097db0fe6e7f47097446a4061bf2133ae8b83)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250913#comment-16250913
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-2.0 #850 (See
[https://builds.apache.org/job/HBase-2.0/850/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
d5df4c04268bef36e5c0f6f4fc37602c6f77c032)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250903#comment-16250903
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #1016 (See
[https://builds.apache.org/job/HBase-1.2-IT/1016/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
79cc3b3145378c994c59c80ca27a1bd9f48f5d75)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250900#comment-16250900
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #284 (See
[https://builds.apache.org/job/HBase-1.3-IT/284/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
dea935dab72afeb4b366bb5307ee69f04a4bc50e)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250899#comment-16250899
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.5 #155 (See
[https://builds.apache.org/job/HBase-1.5/155/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
bac254bd4249bbe2d8ccc377409719c9e59c78ae)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250895#comment-16250895
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #276 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/276/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
79cc3b3145378c994c59c80ca27a1bd9f48f5d75)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250896#comment-16250896
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #273 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/273/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
79cc3b3145378c994c59c80ca27a1bd9f48f5d75)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250893#comment-16250893
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #345 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/345/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
dea935dab72afeb4b366bb5307ee69f04a4bc50e)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1, 1.1.13
>
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250892#comment-16250892
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #364 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/364/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
dea935dab72afeb4b366bb5307ee69f04a4bc50e)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250891#comment-16250891
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4050 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4050/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
7406c83ef6f5c2f4620e8cbb48630d983c8ad57e)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250886#comment-16250886
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.1-JDK7 #1943 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1943/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
434097db0fe6e7f47097446a4061bf2133ae8b83)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250887#comment-16250887
]
Hudson commented on HBASE-19249:
FAILURE: Integrated in Jenkins build HBase-1.4 #1014 (See
[https://builds.apache.org/job/HBase-1.4/1014/])
HBASE-19249 test for "hbase antipatterns" should check _count_ of (busbey: rev
ade166d5f80be1a6f57a36b9fc4a8ecee6e40d4d)
* (edit) dev-support/hbase-personality.sh
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250469#comment-16250469
]
Appy commented on HBASE-19249:
--
+1
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250384#comment-16250384
]
Hadoop QA commented on HBASE-19249:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19249 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897392/HBASE-19249.0.patch |
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux dc2fea4929ef 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / df82abb159 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9776/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250382#comment-16250382
]
Sean Busbey commented on HBASE-19249:
-
No current hits, fyi.
{code}
Busbey-MBA:hbase busbey$ find . -name '*.java' -exec grep -l 'new
TreeMap master) HBASE-19249 test for "hbase antipatterns"
should check _count_ of occurance rather than text of (16 minutes ago)
* df82abb159 - (origin/master, origin/HEAD) HBASE-19210
TestNamespacesInstanceResource fails (Ted Yu) (36 minutes ago)
{code}
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of
[
https://issues.apache.org/jira/browse/HBASE-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250379#comment-16250379
]
Hadoop QA commented on HBASE-19249:
---
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://builds.apache.org/job/PreCommit-HBASE-Build/9776/console in case of
problems.
> test for "hbase antipatterns" should check _count_ of occurance rather than
> text of
> ---
>
> Key: HBASE-19249
> URL: https://issues.apache.org/jira/browse/HBASE-19249
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: HBASE-19249.0.patch
>
>
> [~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed
> to flag a use.
> looking at our check:
> {code}
> warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
> if [[ ${warnings} -gt 0 ]]; then
> add_vote_table -1 hbaseanti "" "The patch appears use Hadoop
> classification instead of HBase: ${warnings}."
> ((result=result+1))
> fi
> {code}
> That should have been a "grep -c" and not a "grep". So we've been falsely
> giving a negative on all these checks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
