[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291912#comment-16291912 ] Hudson commented on HBASE-19267: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4226 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4226/]) HBASE-19267 Remove compiler-plugin mapping executions as it breaks Java8 (elserj: rev 4a1c3b4210b27b04a09e0c4d2f005b2ba7fd884d) * (edit) hbase-mapreduce/pom.xml * (edit) hbase-rsgroup/pom.xml * (edit) hbase-shell/pom.xml * (edit) hbase-zookeeper/pom.xml * (edit) hbase-replication/pom.xml * (edit) hbase-common/pom.xml * (edit) hbase-backup/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-protocol/pom.xml * (edit) hbase-client/pom.xml * (edit) hbase-examples/pom.xml * (edit) hbase-hadoop-compat/pom.xml * (edit) hbase-hadoop2-compat/pom.xml * (edit) hbase-it/pom.xml * (edit) hbase-http/pom.xml > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch, HBASE-19267.002.branch-2.patch, > HBASE-19267.002.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291570#comment-16291570 ] Dave Latham commented on HBASE-19267: - Sweet, thanks, Josh! > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch, HBASE-19267.002.branch-2.patch, > HBASE-19267.002.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291528#comment-16291528 ] Josh Elser commented on HBASE-19267: Awesome. Thanks for the quick reply, Dave! I'll push this to master. bq. except hbase-spark and hbase-spark-it, which sounds like they are expected Yeah, I think that would be some more investigation/digging, especially given what Mike said earlier. We can revisit that one :) > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch, HBASE-19267.002.branch-2.patch, > HBASE-19267.002.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291469#comment-16291469 ] Dave Latham commented on HBASE-19267: - Looks good - everything imports without errors, except hbase-spark and hbase-spark-it, which sounds like they are expected. Thanks, Josh. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch, HBASE-19267.002.branch-2.patch, > HBASE-19267.002.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291243#comment-16291243 ] Dave Latham commented on HBASE-19267: - [~elserj], it looks like the patch you just uploaded is the same file as the one from a couple weeks ago - still for branch-2. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch, HBASE-19267.002.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286854#comment-16286854 ] Josh Elser commented on HBASE-19267: [~davelatham], shoot, did I not shove this over to master too? That was a mistake. Let me try to take up the cherry-picking cross. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286626#comment-16286626 ] Dave Latham commented on HBASE-19267: - Thanks, [~elserj]. Nice to see a clean import. Would love to see it hit master or any other branches. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269692#comment-16269692 ] Hudson commented on HBASE-19267: FAILURE: Integrated in Jenkins build HBase-2.0 #932 (See [https://builds.apache.org/job/HBase-2.0/932/]) HBASE-19267 Remove compiler-plugin mapping executions as it breaks Java8 (elserj: rev 4fef4cfc300b18879bdfae746aaaf623da1b0928) * (edit) hbase-hadoop-compat/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-client/pom.xml * (edit) hbase-hadoop2-compat/pom.xml * (edit) hbase-examples/pom.xml * (edit) hbase-it/pom.xml * (edit) hbase-shell/pom.xml * (edit) hbase-http/pom.xml * (edit) hbase-replication/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-backup/pom.xml * (edit) hbase-common/pom.xml * (edit) hbase-rsgroup/pom.xml * (edit) hbase-zookeeper/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-mapreduce/pom.xml > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269637#comment-16269637
]
Hadoop QA commented on HBASE-19267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
46s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 18m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
14s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
24s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
45m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
54s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
51s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
50s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}112m
9s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m
0s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
20s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
11s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
14s{color} | {color:green}
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269294#comment-16269294 ] Josh Elser commented on HBASE-19267: bq. I tried your patch yesterday with the latest Eclipse. It is kind of working, except the issue in hbase-protocol module: Yeah, I'm seeing this on master. Going to push the branch-2 variant and then try to fix up the master branch version. The spark integration is also causing trouble :) > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch, > HBASE-19267.002.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269281#comment-16269281
]
Vladimir Rodionov commented on HBASE-19267:
---
[~elserj], I tried your patch yesterday with the latest Eclipse. It kind of
working, except the issue in hbase-protocol module:
{quote}
Plugin execution not covered by lifecycle configuration:
com.google.code.maven-replacer-plugin:replacer:1.5.3:replace (execution:
default, phase: generate-sources) pom.xml /hbase-protocol line 90 Maven
Project Build Lifecycle Mapping Problem
{quote}
> Eclipse project import issues on 2.0
>
>
> Key: HBASE-19267
> URL: https://issues.apache.org/jira/browse/HBASE-19267
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19267.001.branch-2.patch,
> HBASE-19267.002.branch-2.patch
>
>
> Trying to do a fresh import of branch-2 nets some errors..
> It seems like a previous change I made to clean up errors (HBASE-13236),
> specifically adding the maven-compiler-plugin lifecycle mapping for
> m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the
> lifecycle mapping fixes this.
> I assume this only needs to happen for 2.0.
> I keep having issues with the JavaNature being ignored. Not yet sure if this
> is a result of something we're doing wrong (or just Eclipse being Eclipse).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269214#comment-16269214 ] Josh Elser commented on HBASE-19267: Thanks! Let me commit this today so I don't forget about it :) > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260434#comment-16260434 ] Guanghao Zhang commented on HBASE-19267: Try it on branch-2. And it worked for me. :-) Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T00:41:47+08:00) Maven home: /opt/soft/apache-maven-3.3.9 Java version: 1.8.0_131, vendor: Oracle Corporation Java home: /opt/soft/jdk1.8.0_131/jre Default locale: zh_CN, platform encoding: UTF-8 OS name: "linux", version: "3.13.0-46-generic", arch: "amd64", family: "unix" Eclipse Version: Version: Oxygen.1a Release (4.7.1a). Meanwhile, I got the NullPointerException (as [~vrodionov] said) too when use the old version eclipse(4.4.2). > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259399#comment-16259399
]
Josh Elser commented on HBASE-19267:
Thanks, [~zghaobac]! That would be very appreciated.
On a fresh import of HBase into Eclipse, you would notice that many of the
modules are missing the "Java Nature" in Eclipse which would result in Eclipse
not actually building the projects. As a result, you'll see lots of compilation
errors (e.g. in hbase-server) because previous modules containing necessary
classes like those from hbase-common or hbase-client would not be found.
With this patch (and a {{mvn clean package -DskipTests}} before trying the
import), Eclipse should import everything correctly and have no errors reported
:)
> Eclipse project import issues on 2.0
>
>
> Key: HBASE-19267
> URL: https://issues.apache.org/jira/browse/HBASE-19267
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19267.001.branch-2.patch
>
>
> Trying to do a fresh import of branch-2 nets some errors..
> It seems like a previous change I made to clean up errors (HBASE-13236),
> specifically adding the maven-compiler-plugin lifecycle mapping for
> m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the
> lifecycle mapping fixes this.
> I assume this only needs to happen for 2.0.
> I keep having issues with the JavaNature being ignored. Not yet sure if this
> is a result of something we're doing wrong (or just Eclipse being Eclipse).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258792#comment-16258792 ] Guanghao Zhang commented on HBASE-19267: What the error looks like? I still use eclipse and I can take a try for the patch. [~elserj] > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255977#comment-16255977 ] Vladimir Rodionov commented on HBASE-19267: --- Eclipse project build is broken on master as well. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255871#comment-16255871
]
Josh Elser commented on HBASE-19267:
Thanks for trying it out Vlad!
{noformat}
Version: Oxygen.1a Release (4.7.1a)
{noformat}
Is what I'm on locally :)
> Eclipse project import issues on 2.0
>
>
> Key: HBASE-19267
> URL: https://issues.apache.org/jira/browse/HBASE-19267
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19267.001.branch-2.patch
>
>
> Trying to do a fresh import of branch-2 nets some errors..
> It seems like a previous change I made to clean up errors (HBASE-13236),
> specifically adding the maven-compiler-plugin lifecycle mapping for
> m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the
> lifecycle mapping fixes this.
> I assume this only needs to happen for 2.0.
> I keep having issues with the JavaNature being ignored. Not yet sure if this
> is a result of something we're doing wrong (or just Eclipse being Eclipse).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255868#comment-16255868 ] Vladimir Rodionov commented on HBASE-19267: --- It failed for me with : "An internal error occurred during: "Updating Maven Project". java.lang.NullPointerException My Eclipse is quite old though - 4.4.2 > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255633#comment-16255633 ] stack commented on HBASE-19267: --- [~elserj] Would this be good for the dev list? Would also help figure if you are the lonely outlier or part of a silent majority! > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255494#comment-16255494 ] Mike Drob commented on HBASE-19267: --- I don't actually have eclipse installed anymore, sorry boss. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19267.001.branch-2.patch > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255488#comment-16255488
]
Josh Elser commented on HBASE-19267:
[~mdrob], do you have a minute to take this for a spin on branch2? The general
steps I took locally which worked:
* Apply patch
* {{for d in .settings .classpath .project; do find . -name $d | xargs rm -r;
done}}
* {{mvn clean package -DskipTests}} (to work around the build plugins that we
ignore in the lifecycle mapping)
* Import as Maven Project
> Eclipse project import issues on 2.0
>
>
> Key: HBASE-19267
> URL: https://issues.apache.org/jira/browse/HBASE-19267
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19267.001.branch-2.patch
>
>
> Trying to do a fresh import of branch-2 nets some errors..
> It seems like a previous change I made to clean up errors (HBASE-13236),
> specifically adding the maven-compiler-plugin lifecycle mapping for
> m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the
> lifecycle mapping fixes this.
> I assume this only needs to happen for 2.0.
> I keep having issues with the JavaNature being ignored. Not yet sure if this
> is a result of something we're doing wrong (or just Eclipse being Eclipse).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[
https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254558#comment-16254558
]
Hadoop QA commented on HBASE-19267:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
34s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
31s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
19s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
49s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
41s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 97m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
25s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
6s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m
28s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
43s{color} | {color:green}
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253852#comment-16253852 ] Josh Elser commented on HBASE-19267: bq. I gave up on eclipse when it refused to recognize the scala code in the spark module I suppose I'm lucky that Scala code is now gone ;) I doubt I'll get it 100% of the way there, but I can definitely some things which are causing problems now that I can make better. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19267) Eclipse project import issues on 2.0
[ https://issues.apache.org/jira/browse/HBASE-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253842#comment-16253842 ] Mike Drob commented on HBASE-19267: --- FWIW I gave up on eclipse when it refused to recognize the scala code in the spark module, so I salute your efforts here, Josh. > Eclipse project import issues on 2.0 > > > Key: HBASE-19267 > URL: https://issues.apache.org/jira/browse/HBASE-19267 > Project: HBase > Issue Type: Task > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-beta-1 > > > Trying to do a fresh import of branch-2 nets some errors.. > It seems like a previous change I made to clean up errors (HBASE-13236), > specifically adding the maven-compiler-plugin lifecycle mapping for > m2eclipse, is now causing Eclipse to not compile HBase as Java8. Removing the > lifecycle mapping fixes this. > I assume this only needs to happen for 2.0. > I keep having issues with the JavaNature being ignored. Not yet sure if this > is a result of something we're doing wrong (or just Eclipse being Eclipse). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
