[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269909#comment-16269909 ] Hudson commented on HBASE-19351: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4134 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4134/]) HBASE-19351 Deprecated is missing in Table implementations (stack: rev b5a01685f4aff0d97ec53a6eca26bd37dd9d9037) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/RegionAsTable.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269691#comment-16269691 ] Hudson commented on HBASE-19351: FAILURE: Integrated in Jenkins build HBase-2.0 #932 (See [https://builds.apache.org/job/HBase-2.0/932/]) HBASE-19351 Deprecated is missing in Table implementations (stack: rev 12efae4829830f920c5a7d47ea00f8f3c9c7c342) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/RegionAsTable.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268264#comment-16268264 ] Peter Somogyi commented on HBASE-19351: --- Just checked, javadoc has the Deprecation tags. > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267815#comment-16267815 ] stack commented on HBASE-19351: --- The checkstyle may just be confused. Did you look at HTable produced javadoc to make sure it looks right [~psomogyi]? Thanks sir. > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267497#comment-16267497 ] Peter Somogyi commented on HBASE-19351: --- Should I fix the checkstyle warnings? > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267424#comment-16267424 ] Ted Yu commented on HBASE-19351: I see. Appy: Please go ahead with commit. > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267419#comment-16267419 ] Peter Somogyi commented on HBASE-19351: --- No, the one with CompareOp parameter is the deprecated one. > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[
https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267405#comment-16267405
]
Ted Yu commented on HBASE-19351:
{code}
848 @Override
849 public boolean checkAndMutate(byte[] row, byte[] family, byte[]
qualifier,
850 CompareOperator compareOp, byte[] value, RowMutations rm) throws
IOException {
{code}
The above should be deprecated, right ?
The other changes look good.
> Deprecated is missing in Table implementations
> --
>
> Key: HBASE-19351
> URL: https://issues.apache.org/jira/browse/HBASE-19351
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-4
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19351.master.001.patch
>
>
> Table interface has some deprecated methods and the implementations do not
> have it so those methods are visible as non-deprecated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[
https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267320#comment-16267320
]
Hadoop QA commented on HBASE-19351:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 11m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-client: The patch generated 4 new + 63 unchanged
- 0 fixed = 67 total (was 63) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
4s{color} | {color:red} hbase-server: The patch generated 7 new + 18 unchanged
- 0 fixed = 25 total (was 18) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
15s{color} | {color:red} hbase-rest: The patch generated 7 new + 111 unchanged
- 1 fixed = 118 total (was 112) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
21s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}189m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19351 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12899435/HBASE-19351.master.001.patch
|
| Optional Tests
[jira] [Commented] (HBASE-19351) Deprecated is missing in Table implementations
[ https://issues.apache.org/jira/browse/HBASE-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267293#comment-16267293 ] Appy commented on HBASE-19351: -- +1 > Deprecated is missing in Table implementations > -- > > Key: HBASE-19351 > URL: https://issues.apache.org/jira/browse/HBASE-19351 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19351.master.001.patch > > > Table interface has some deprecated methods and the implementations do not > have it so those methods are visible as non-deprecated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
