[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420934#comment-17420934 ] Bryan Beaudreault commented on HBASE-19407: --- Thank you for the details [~apurtell]. I'm not surprised there is not enough interested parties since it only exists in master branch, which is unreleased. It makes the barrier to entry too high for users who aren't already actively working on 3.0-alpha. I created https://issues.apache.org/jira/browse/HBASE-26301 for consideration of backporting to branch-2, which might increase awareness, adoption, and thus contribution. > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Blocker > Fix For: 2.0.0-beta-1, 2.0.0 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420925#comment-17420925 ] Andrew Kyle Purtell commented on HBASE-19407: - [~bbeaudreault] The backup/restore code in master branch is still not finished and unstable (test flakes can pollute precommit results). It needs more interested parties to pay it attention or it's at risk of the ultimate removal. > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Blocker > Fix For: 2.0.0-beta-1, 2.0.0 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420902#comment-17420902 ] Bryan Beaudreault commented on HBASE-19407: --- The link in the original description does not work for me. If anyone else stumbles on this issue, see [https://lists.apache.org/thread.html/52972686e458fe36c63998c0d87065f4282e86245111ce501a40c89f%40%3Cdev.hbase.apache.org%3E] I saw the native Backup/Restore feature and was briefly excited that it might be in hbase2 based on some of the history, but unfortunately it was removed seemingly due to not being finished before 2.0 release deadlines. > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Blocker > Fix For: 2.0.0-beta-1, 2.0.0 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275345#comment-16275345 ] stack commented on HBASE-19407: --- Pushed to branch-2. Lurking timeouts need to address in branch-2 but unrelated. [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 53.839 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [ERROR] testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) Time elapsed: 6.337 s <<< FAILURE! java.lang.AssertionError: Expected snapshot to contain family 'fam', but it does not. at org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(TestFlushSnapshotFromClient.java:201) [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 63.994 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [ERROR] testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) Time elapsed: 3.789 s <<< FAILURE! java.lang.AssertionError: Expected snapshot to contain family 'fam', but it does not. at org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(TestFlushSnapshotFromClient.java:201) [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.611 s - in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient [INFO] [INFO] Results: [INFO] [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy.testPurgeExpiredFiles(org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy) [ERROR] Run 1: TestFIFOCompactionPolicy.testPurgeExpiredFiles:129 Waiting timed out after [30,000] msec The store file count 2 is still greater than 1 [INFO] Run 2: PASS [INFO] [WARNING] org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testSkipFlushTableSnapshot(org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient) [ERROR] Run 1: TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:201 Expected snapshot to contain family 'fam', but it does not. [ERROR] Run 2: TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:201 Expected snapshot to contain family 'fam', but it does not. [INFO] Run 3: PASS [INFO] [INFO] [WARNING] Tests run: 3162, Failures: 0, Errors: 0, Skipped: 39, Flakes: 2 > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[
https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275322#comment-16275322
]
Hadoop QA commented on HBASE-19407:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
8s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 31 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
53s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch hbase-protocol-shaded passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} hbase-it: The patch generated 0 new + 0 unchanged -
3 fixed = 0 total (was 3) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-assembly passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} root: The patch generated 0 new + 0 unchanged - 265
fixed = 0 total (was 265) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
5s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
3m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}170m 40s{color}
| {color:red} root in the patch failed. {col
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275185#comment-16275185 ] Andrew Purtell commented on HBASE-19407: +1 Sorry to see this didn't make 2.0 > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19407) [branch-2] Remove backup/restore
[ https://issues.apache.org/jira/browse/HBASE-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274959#comment-16274959 ] stack commented on HBASE-19407: --- .001 remove hbase-backup, it tests, backup/restore verbs from bin/hbase > [branch-2] Remove backup/restore > > > Key: HBASE-19407 > URL: https://issues.apache.org/jira/browse/HBASE-19407 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack >Priority: Blocker > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19407.branch-2.001.patch > > > As per thread up on dev list [1], we won't be including the backup/restore in > hbase2. This issue purges it. > 1. > http://apache-hbase.679495.n3.nabble.com/DISCUSS-Plan-to-avoid-backup-restore-removal-from-2-0-td4091807.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
