[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293652#comment-16293652 ] Hudson commented on HBASE-19498: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4233 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4233/]) HBASE-19498 Fix findbugs and error-prone warnings in hbase-client (stack: rev 59529a78f039965a4c08805c9087d82d64621c20) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestSaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/NotServingRegionException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestBufferedMutatorParams.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLocations.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RandomRowFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BitComparator.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMasterRequestRpcRetryingCaller.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/BinaryComparator.java * (edit) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRegionInfoDisplay.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SubstringComparator.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/PerClientRandomNonceGenerator.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcClient.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKLeaderManager.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/InvalidFamilyOperationException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/EmptyWatcher.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java * (edit)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293425#comment-16293425 ] stack commented on HBASE-19498: --- [~psomogyi] Appy and I had questions up on RB when you have a chance thanks. > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293422#comment-16293422 ] stack commented on HBASE-19498: --- bq. But if we really want to move to specifying charset manually, then it's better to have a util function StringtoBytesUtf8 and use it everywhere then current approach. This we have and we use it everywhere. See Bytes.toString. bq. I also found https://stackoverflow.com/questions/361975/setting-the-default-java-character-encoding While happy at first, but it might not be good idea to change default charset globally. Might have very bad consequence in some places. Yeah, thats about setting the platform coding. We have setting the charset encoding Strings when we write to zk or the db since near-to day-one as UTF-8 (see Bytes class). When we write out web pages, they have at the head that they are encoded as UTF-8. We don't advertise it and we should but we log data in UTF-8. When we dump on the console its usually UTF-8 (this might clash w/ terminal charset). This patch adds UTF-8 specification in remaining places where it goes unspecified. Some is silly (tests), some makes sense, dumping mbean output, and while there are cases where if data had been encoded with one charset and read back w/ another, i don't see instances in this patch. I was going to commit to get it in because it will rot if we leave it hang. Having it in also makes backport to 1.4 run smoother since it already has these patches. Good on you [~appy] > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293401#comment-16293401 ] Appy commented on HBASE-19498: -- Is there anything in here that's urgent to get into beta1? If yes, commit then followup with refactor. If not, let's introduce the util function as part of this patch itself. > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293386#comment-16293386 ] Appy commented on HBASE-19498: -- I also found https://stackoverflow.com/questions/361975/setting-the-default-java-character-encoding While happy at first, it might not be good idea to change default charset globally. Might have very bad consequence in some places. > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293314#comment-16293314 ] Appy commented on HBASE-19498: -- Took a look at usages with [~stack] again. The uses are either: - in tests - printing to logs - on md5 checksum of encoded region name so these are fine. But if we really want to move to specifying charset manually, then it's better to have a util function StringtoBytesUtf8 and use it everywhere then current approach. > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293272#comment-16293272 ] stack commented on HBASE-19498: --- I took a look at usage here too. Yeah. Strings or dumping stuff on UI or test. UTF-8 is the systems charset. Picking up default charset of the OS we do not want. I hear you on perhaps something that worked will now throw odd errors but I don't see a case in the patch. What you reckon [~appy] > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293259#comment-16293259 ] stack commented on HBASE-19498: --- It'll be different for characters > position 128. Otherwise its ASCII. Specifying the charset was on PrintStream and toString, stuff we are going to dump on console or in UI... in this case UTF-8 would be better (probably harmless -- though famous last words). Thanks [~appy] > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293229#comment-16293229 ] Appy commented on HBASE-19498: -- (Same comment as on HABSE-19497) i am not sure about charactersets thing. What was the old default? If it was different, then we shouldn't do it until we have made sure that this stuff is not serialized and stored anywhere. > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[ https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293098#comment-16293098 ] stack commented on HBASE-19498: --- This looks good to go. You have questions [~appy] but they seem just out of interest? Code changes seem right. Push? +1 up on RB > Fix findbugs and error-prone warnings in hbase-client (branch-2) > > > Key: HBASE-19498 > URL: https://issues.apache.org/jira/browse/HBASE-19498 > Project: HBase > Issue Type: Sub-task >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19498.master.001.patch, > HBASE-19498.master.002.patch, HBASE-19498.master.003.patch, > HBASE-19498.master.004.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[
https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291818#comment-16291818
]
Hadoop QA commented on HBASE-19498:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} hbase-common: The patch generated 0 new + 25
unchanged - 2 fixed = 25 total (was 27) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} hbase-client: The patch generated 0 new + 862
unchanged - 116 fixed = 862 total (was 978) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-replication passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 25s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
20s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}101m
56s{color} | {color:green} hbase-server in the patch
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[
https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291592#comment-16291592
]
Hadoop QA commented on HBASE-19498:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
22s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
11s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 11s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} hbase-common: The patch generated 0 new + 25
unchanged - 2 fixed = 25 total (was 27) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
17s{color} | {color:red} hbase-client: The patch generated 2 new + 0 unchanged
- 978 fixed = 2 total (was 978) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-replication passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
46s{color} | {color:red} patch has 20 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
40s{color} | {color:red} The patch causes 20 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
36s{color} | {color:red} The patch causes 20 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
36s{color} | {color:red} The patch causes 20 errors with Hadoop v3.0.0-beta1.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
10s{color} | {color:red} hbase-client in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
6s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 11s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-zookeeper in the patch passed.
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[
https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291171#comment-16291171
]
Hadoop QA commented on HBASE-19498:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} hbase-common: The patch generated 0 new + 25
unchanged - 2 fixed = 25 total (was 27) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} hbase-client: The patch generated 7 new + 930
unchanged - 48 fixed = 937 total (was 978) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-replication passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 13s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
18s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
41s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
14s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}103m
42s{color} | {color:green} hbase-server in the patch passed. {color}
[jira] [Commented] (HBASE-19498) Fix findbugs and error-prone warnings in hbase-client (branch-2)
[
https://issues.apache.org/jira/browse/HBASE-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291139#comment-16291139
]
Hadoop QA commented on HBASE-19498:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} hbase-common: The patch generated 0 new + 25
unchanged - 2 fixed = 25 total (was 27) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
45s{color} | {color:red} hbase-client: The patch generated 7 new + 930
unchanged - 48 fixed = 937 total (was 978) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch hbase-replication passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 34s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
32s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
57s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} hbase-zookeeper in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
18s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}103m 51s{color}
| {color:red} hbase-server in the patch failed. {color} |
|
