[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292184#comment-16292184 ] Hudson commented on HBASE-19513: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4228 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4228/]) HBASE-19513 Fix the wrapped AsyncFSOutput implementation (zhangduo: rev 661491b56b250a8faa0f375f83815c0aa69bac24) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/AsyncFSOutputHelper.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/asyncfs/TestFanOutOneBlockAsyncDFSOutput.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/asyncfs/TestSendBufSizePredictor.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/asyncfs/TestLocalAsyncOutput.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/asyncfs/TestSaslFanOutOneBlockAsyncDFSOutput.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/AsyncFSOutput.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.master.001.patch, HBASE-19513.patch, > HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291983#comment-16291983 ] Hadoop QA commented on HBASE-19513: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m 10s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 10s{color} | {color:green} hbase-server: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 30s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 22m 35s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0-beta1. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 94m 38s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}138m 56s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19513 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12902188/HBASE-19513.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 71a2799aa8d2 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 6ab8ce9829 | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10465/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10465/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 >
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291899#comment-16291899 ] stack commented on HBASE-19513: --- +1 Lets try it. Let me know if you want me to commit. The TestZKSecretWatcher shows up in a few hadoopqas currently. I can't repro locally. I'm thinking its just that slow zk up on jenkins cluster (zk seems real slow to connection on jenkins for whatever reason...) > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.master.001.patch, HBASE-19513.patch, > HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291896#comment-16291896 ] stack commented on HBASE-19513: --- Go for it @don zhang > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.master.001.patch, HBASE-19513.patch, > HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291890#comment-16291890 ] Duo Zhang commented on HBASE-19513: --- Thanks [~stack] for the rebasing. Let commit it and run the simple patch in HBASE-15536 again? The TestZKSecretWatcher is not related I think. Thanks. > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.master.001.patch, HBASE-19513.patch, > HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291864#comment-16291864 ] stack commented on HBASE-19513: --- .001 rebase needed after commit 2c9ef8a471148ece655b881cc490b6b685d634f4 Author: Mike DrobDate: Tue Dec 5 14:25:37 2017 -0600 HBASE-19289 Add flag to disable stream capability enforcement > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.master.001.patch, HBASE-19513.patch, > HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291721#comment-16291721 ] Hadoop QA commented on HBASE-19513: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color} | {color:red} HBASE-19513 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-19513 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12902165/HBASE-19513.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10462/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org | This message was automatically generated. > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.patch, HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291011#comment-16291011 ] Hadoop QA commented on HBASE-19513: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 4 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 26s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} hbase-server: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 25s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 18m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0-beta1. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}103m 9s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}142m 54s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-19513 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12902071/HBASE-19513.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f1c699b28c37 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / fe316fe7ac | | maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/10446/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10446/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10446/console | | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org
[jira] [Commented] (HBASE-19513) Fix the wrapped AsyncFSOutput implementation
[ https://issues.apache.org/jira/browse/HBASE-19513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290814#comment-16290814 ] Duo Zhang commented on HBASE-19513: --- [~stack] FYI. This should fix the flakey TestHRegion and TestWalAndCompactingMemStoreFlush. Thanks. > Fix the wrapped AsyncFSOutput implementation > > > Key: HBASE-19513 > URL: https://issues.apache.org/jira/browse/HBASE-19513 > Project: HBase > Issue Type: Bug > Components: wal >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19513.patch > > > It causes several flakey tests. Let me rewrite it with more caution... -- This message was sent by Atlassian JIRA (v6.4.14#64029)