subject:"\[jira\] \[Commented\] \(HBASE\-19549\) Change path comparison in CommonFSUtils"

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296180#comment-16296180
 ] 

Hudson commented on HBASE-19549:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4251 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4251/])
HBASE-19549 Change path comparison in CommonFSUtils (stack: rev 
abae90787fdf2a207ebacae3223eee21cf3f7659)
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
* (edit) 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java


> Change path comparison in CommonFSUtils
> ---
>
> Key: HBASE-19549
> URL: https://issues.apache.org/jira/browse/HBASE-19549
> Project: HBase
>  Issue Type: Bug
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19549.master.001.patch, 
> HBASE-19549.master.002.patch
>
>
> CommonFSUtils had a reference comparison in isValidWALRootDir. It was changed 
> to equals and [~stack] recommended to use Path:makeQualified.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295270#comment-16295270
 ] 

Hadoop QA commented on HBASE-19549:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
13s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 32s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 
28s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 52s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19549 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12902670/HBASE-19549.master.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux a0eefaa61311 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 62b591bdc7 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| De

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Chia-Ping Tsai (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295192#comment-16295192
 ] 

Chia-Ping Tsai commented on HBASE-19549:


+1 on v2

> Change path comparison in CommonFSUtils
> ---
>
> Key: HBASE-19549
> URL: https://issues.apache.org/jira/browse/HBASE-19549
> Project: HBase
>  Issue Type: Bug
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
> Attachments: HBASE-19549.master.001.patch, 
> HBASE-19549.master.002.patch
>
>
> CommonFSUtils had a reference comparison in isValidWALRootDir. It was changed 
> to equals and [~stack] recommended to use Path:makeQualified.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Peter Somogyi (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295191#comment-16295191
 ] 

Peter Somogyi commented on HBASE-19549:
---

Thanks for checking [~chia7712]! Just attached a new patch.

> Change path comparison in CommonFSUtils
> ---
>
> Key: HBASE-19549
> URL: https://issues.apache.org/jira/browse/HBASE-19549
> Project: HBase
>  Issue Type: Bug
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
> Attachments: HBASE-19549.master.001.patch, 
> HBASE-19549.master.002.patch
>
>
> CommonFSUtils had a reference comparison in isValidWALRootDir. It was changed 
> to equals and [~stack] recommended to use Path:makeQualified.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Chia-Ping Tsai (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295168#comment-16295168
 ] 

Chia-Ping Tsai commented on HBASE-19549:


LGTM. There is a similar issue in our production code. fix it in this jira?
{code:title=TableMapReduceUtil.java}
  private static Path findOrCreateJar(Class my_class, FileSystem fs,
  Map packagedClasses)
  throws IOException {
// attempt to locate an existing jar for the class.
String jar = findContainingJar(my_class, packagedClasses);
if (null == jar || jar.isEmpty()) {
  jar = getJar(my_class);
  updateMap(jar, packagedClasses);
}

if (null == jar || jar.isEmpty()) {
  return null;
}

LOG.debug(String.format("For class %s, using jar %s", my_class.getName(), 
jar));
return new Path(jar).makeQualified(fs); // here
  }
{code}

> Change path comparison in CommonFSUtils
> ---
>
> Key: HBASE-19549
> URL: https://issues.apache.org/jira/browse/HBASE-19549
> Project: HBase
>  Issue Type: Bug
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
> Attachments: HBASE-19549.master.001.patch
>
>
> CommonFSUtils had a reference comparison in isValidWALRootDir. It was changed 
> to equals and [~stack] recommended to use Path:makeQualified.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

2017-12-18 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294956#comment-16294956
 ] 

Hadoop QA commented on HBASE-19549:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
19s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m  4s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19549 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12902638/HBASE-19549.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 481a68f34995 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 62b591bdc7 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/10529/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/10529/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> Change path comparison in CommonFSUtils
> -

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

[jira] [Commented] (HBASE-19549) Change path comparison in CommonFSUtils

6 matches

Site Navigation

Mail list logo

Footer information