[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298469#comment-16298469 ] Chia-Ping Tsai commented on HBASE-19565: Pardon me, I overlooked it. :( > TestSafemodeBringsDownMaster constantly hangs > - > > Key: HBASE-19565 > URL: https://issues.apache.org/jira/browse/HBASE-19565 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-2 > > > TestSafemodeBringsDownMaster always hangs. The problem is with HDFS > dependency: > SafeMode is turned on for HDFS which will throw SafeModeException. > FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception > but when unwrapRemoteException() is called NoSuchMethodError is thrown > because SafeMode does not have constructor with String parameter in 2.7.4 > release. > This was fixed by HDFS-8592 but it is not part of 2.7 release line since it > is a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298463#comment-16298463 ] Peter Somogyi commented on HBASE-19565: --- Yes, that's what I wrote in the description. > TestSafemodeBringsDownMaster constantly hangs > - > > Key: HBASE-19565 > URL: https://issues.apache.org/jira/browse/HBASE-19565 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-2 > > > TestSafemodeBringsDownMaster always hangs. The problem is with HDFS > dependency: > SafeMode is turned on for HDFS which will throw SafeModeException. > FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception > but when unwrapRemoteException() is called NoSuchMethodError is thrown > because SafeMode does not have constructor with String parameter in 2.7.4 > release. > This was fixed by HDFS-8592 but it is not part of 2.7 release line since it > is a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298460#comment-16298460 ] Chia-Ping Tsai commented on HBASE-19565: We can't get the SafeModeException from RemoteException since we use the hadoop-2.7 now. see HDFS-8592 > TestSafemodeBringsDownMaster constantly hangs > - > > Key: HBASE-19565 > URL: https://issues.apache.org/jira/browse/HBASE-19565 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-2 > > > TestSafemodeBringsDownMaster always hangs. The problem is with HDFS > dependency: > SafeMode is turned on for HDFS which will throw SafeModeException. > FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception > but when unwrapRemoteException() is called NoSuchMethodError is thrown > because SafeMode does not have constructor with String parameter in 2.7.4 > release. > This was fixed by HDFS-8592 but it is not part of 2.7 release line since it > is a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298438#comment-16298438 ] Peter Somogyi commented on HBASE-19565: --- Thanks [~Apache9], I haven't noticed that issue. Closing this one as duplicate. > TestSafemodeBringsDownMaster constantly hangs > - > > Key: HBASE-19565 > URL: https://issues.apache.org/jira/browse/HBASE-19565 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-2 > > > TestSafemodeBringsDownMaster always hangs. The problem is with HDFS > dependency: > SafeMode is turned on for HDFS which will throw SafeModeException. > FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception > but when unwrapRemoteException() is called NoSuchMethodError is thrown > because SafeMode does not have constructor with String parameter in 2.7.4 > release. > This was fixed by HDFS-8592 but it is not part of 2.7 release line since it > is a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[ https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298426#comment-16298426 ] Duo Zhang commented on HBASE-19565: --- See HBASE-19542. And I'm not sure whether we should give up on SafeModeException. Is it means that the file has already been closed? > TestSafemodeBringsDownMaster constantly hangs > - > > Key: HBASE-19565 > URL: https://issues.apache.org/jira/browse/HBASE-19565 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 2.0.0-alpha-4 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Fix For: 2.0.0-beta-2 > > > TestSafemodeBringsDownMaster always hangs. The problem is with HDFS > dependency: > SafeMode is turned on for HDFS which will throw SafeModeException. > FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception > but when unwrapRemoteException() is called NoSuchMethodError is thrown > because SafeMode does not have constructor with String parameter in 2.7.4 > release. > This was fixed by HDFS-8592 but it is not part of 2.7 release line since it > is a breaking change. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19565) TestSafemodeBringsDownMaster constantly hangs
[
https://issues.apache.org/jira/browse/HBASE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298320#comment-16298320
]
Peter Somogyi commented on HBASE-19565:
---
FanOutOneBlockAsyncDFSOutputHelper#completeFile method also needs modification
to catch SafeModeException.
{code}
try {
if (namenode.complete(src, clientName, block, fileId)) {
endFileLease(client, fileId);
return;
} else {
LOG.warn("complete file " + src + " not finished, retry = " + retry);
}
} catch (RemoteException e) {
IOException ioe = e.unwrapRemoteException();
if (ioe instanceof LeaseExpiredException) {
LOG.warn("lease for file " + src + " is expired, give up", e);
return;
} else if (ioe instanceof SafeModeException) { // here we have to
catch SafeModeException
return;
} else {
LOG.warn("complete file " + src + " failed, retry = " + retry, e);
}
} catch (Exception e) {
LOG.warn("complete file " + src + " failed, retry = " + retry, e);
}
sleepIgnoreInterrupt(retry);
{code}
> TestSafemodeBringsDownMaster constantly hangs
> -
>
> Key: HBASE-19565
> URL: https://issues.apache.org/jira/browse/HBASE-19565
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0-alpha-4
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
> Fix For: 2.0.0-beta-2
>
>
> TestSafemodeBringsDownMaster always hangs. The problem is with HDFS
> dependency:
> SafeMode is turned on for HDFS which will throw SafeModeException.
> FanOutOneBlockAsyncDFSOutputHelper#completeFile should catch that exception
> but when unwrapRemoteException() is called NoSuchMethodError is thrown
> because SafeMode does not have constructor with String parameter in 2.7.4
> release.
> This was fixed by HDFS-8592 but it is not part of 2.7 release line since it
> is a breaking change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
