[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307317#comment-16307317
]
Chia-Ping Tsai commented on HBASE-19662:
Or use the full path instead.
{code}
${maven.checkstyle.version}
- org.apache.hbase
- hbase-checkstyle
- ${project.version}
-
-
com.puppycrawl.tools
checkstyle
${checkstyle.version}
-hbase/checkstyle.xml
-
hbase/checkstyle-suppressions.xml
+
hbase-checkstyle/src/main/resources/hbase/checkstyle.xml
+
hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
true
{code}
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306510#comment-16306510
]
Chia-Ping Tsai commented on HBASE-19662:
[~mdrob] Should jenkins run the {{install}} first? Otherwise the similar error
may happen in the future.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306506#comment-16306506
]
Chia-Ping Tsai commented on HBASE-19662:
bq. can somebody manually deploy the latest snapshot and see if that fixes
things?
I get the error if I remove hbase from local repository. Seems maven use the
checkstyle rule from the snapshot file.
{code}
[DEBUG] The resource 'hbase/checkstyle.xml' was not found with resourceLoader
org.codehaus.plexus.resource.loader.URLResourceLoader.
[DEBUG] The resource 'hbase/checkstyle.xml' was not found with resourceLoader
org.codehaus.plexus.resource.loader.JarResourceLoader.
[DEBUG] The resource 'hbase/checkstyle.xml' was not found with resourceLoader
org.codehaus.plexus.resource.loader.FileResourceLoader.
[DEBUG] The resource 'hbase/checkstyle.xml' was found as
jar:file:/home/chia7712/.m2/repository/org/apache/hbase/hbase-checkstyle/3.0.0-SNAPSHOT/hbase-checkstyle-3.0.0-SNAPSHOT.jar!/hbase/checkstyle.xml.
{code}
And the rule is decrepit.
{code}
{code}
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306490#comment-16306490
]
Chia-Ping Tsai commented on HBASE-19662:
I run the command - {{mvn clean -DskipTests package findbugs:findbugs}} and
{{mvn -DskipTests package checkstyle:checkstyle}} - used by jenkis. still
pass..
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306472#comment-16306472
]
Chia-Ping Tsai commented on HBASE-19662:
bq. Oh, interesting, I get this error locally when running mvn site! That's
some kind of progress.
I run the {{mvn clean site}} but no failure happen.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306354#comment-16306354
]
Mike Drob commented on HBASE-19662:
---
What I suspect is happening is that instead of using the current ruleset, that
job is downloading the old checkstyle jar from snapshots repo and using ruleset
from there (which hasn't been updated for new import order rules).
can somebody manually deploy the latest snapshot and see if that fixes things?
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306351#comment-16306351
]
Mike Drob commented on HBASE-19662:
---
Oh, interesting, I get this error locally when running {{mvn site}}! That's
some kind of progress.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306346#comment-16306346
]
Mike Drob commented on HBASE-19662:
---
That is a very confusing error. Like [~chia7712], I also do not get that error
running locally.
[~tedyu] - can you reproduce it outside of the jenkins env? Maybe it is a
problem with our build job.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306263#comment-16306263
]
Ted Yu commented on HBASE-19662:
See
https://builds.apache.org/job/HBase-TRUNK_matrix/jdk=JDK%201.8%20(latest),label=(Hadoop%20&&%20!H5)/4305/
which was based on 8d0da1a77f50b730b366c28b5b477141aa83cc55
The error was still there.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306212#comment-16306212
]
Chia-Ping Tsai commented on HBASE-19662:
I run the same commend for hbase-metrics-api.
{code}
grep ImportOrderCheck hbase-metrics-api/target/checkstyle-result.xml | wc
0 0 0
{code}
The commit of HBASE-19552 are divided into 2 parts. If you build hbase on top
of ea7d5fc88454cc8d623d837e2d8975643e354bda, you will encounter the build
error. I believe the error is gone now.
{quote}
Maybe we should temporarily disable the import order rule.
What do you think ?
{quote}
I prefer to resolved all checkstyle issuesya, a difficult job. There is a
related issue. HBASE-12521.
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305965#comment-16305965
]
Hadoop QA commented on HBASE-19662:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
1s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
9s{color} | {color:red} hbase-metrics-api in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 9s{color}
| {color:red} hbase-metrics-api in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} hbase-metrics-api: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
27s{color} | {color:red} The patch causes 12 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
14s{color} | {color:red} The patch causes 12 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
5s{color} | {color:red} The patch causes 12 errors with Hadoop v3.0.0. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
9s{color} | {color:red} hbase-metrics-api in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 10s{color}
| {color:red} hbase-metrics-api in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19662 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12903972/19662.v1.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d50506c75c97 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8d0da1a77f |
| maven | version: Apache Maven 3.5.2
[jira] [Commented] (HBASE-19662) hbase-metrics-api fails checkstyle due to wrong import order
[
https://issues.apache.org/jira/browse/HBASE-19662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305952#comment-16305952
]
Ted Yu commented on HBASE-19662:
There are many other import order warnings.
e.g.
{code}
grep ImportOrderCheck hbase-server/target/checkstyle-result.xml | wc
1319 11871 262660
{code}
[~chia7712]
Maybe we should temporarily disable the import order rule.
What do you think ?
> hbase-metrics-api fails checkstyle due to wrong import order
>
>
> Key: HBASE-19662
> URL: https://issues.apache.org/jira/browse/HBASE-19662
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Attachments: 19662.v1.txt
>
>
> In recent trunk builds, there were the following errors:
> {code}
> [ERROR]
> src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java:[31]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting'
> import.
> [ERROR]
> src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java:[28]
> (imports) ImportOrder: Wrong order for
> 'org.apache.hbase.thirdparty.com.google.common.collect.Lists' import.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
