[jira] [Commented] (HBASE-19677) Miscellaneous HFileCleaner Improvements

2017-12-31 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307300#comment-16307300
 ] 

Hudson commented on HBASE-19677:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4320 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4320/])
HBASE-19677 Miscellaneous HFileCleaner Improvements (BELUGA BEHR) (tedyu: rev 
360d465a4a22fa5457e475b7d62ba5fec5d0b27b)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java


> Miscellaneous HFileCleaner Improvements
> ---
>
> Key: HBASE-19677
> URL: https://issues.apache.org/jira/browse/HBASE-19677
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19677.1.patch
>
>
> * Remove superfluous logging code guards
> * Introduce SLF4J parameter logging
> * Some simplifying:
> {code}
> -for (HFileDeleteTask task : largeFileQueue) {
> -  leftOverTasks.add(task);
> -}
> -for (HFileDeleteTask task : smallFileQueue) {
> -  leftOverTasks.add(task);
> -}
> +leftOverTasks.addAll(largeFileQueue);
> +leftOverTasks.addAll(smallFileQueue);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19677) Miscellaneous HFileCleaner Improvements

2018-01-02 Thread Appy (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308636#comment-16308636
 ] 

Appy commented on HBASE-19677:
--

I liked the change from just thread name to thread name + priority + groupname.
Thanks for the nice fixes [~belugabehr]!

> Miscellaneous HFileCleaner Improvements
> ---
>
> Key: HBASE-19677
> URL: https://issues.apache.org/jira/browse/HBASE-19677
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19677.1.patch
>
>
> * Remove superfluous logging code guards
> * Introduce SLF4J parameter logging
> * Some simplifying:
> {code}
> -for (HFileDeleteTask task : largeFileQueue) {
> -  leftOverTasks.add(task);
> -}
> -for (HFileDeleteTask task : smallFileQueue) {
> -  leftOverTasks.add(task);
> -}
> +leftOverTasks.addAll(largeFileQueue);
> +leftOverTasks.addAll(smallFileQueue);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)