[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448168#comment-16448168 ] Balazs Meszaros commented on HBASE-20465: - It is gone from the flaky dashboard :) > Fix TestEnableRSGroup flaky > --- > > Key: HBASE-20465 > URL: https://issues.apache.org/jira/browse/HBASE-20465 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20465.master.001.patch > > > Most recent {{TestEnableRSGroup}} tests failed on branch-2.0 according to our > flaky dashboard. > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.rsgroup.TestEnableRSGroup.testEnableRSGroup(TestEnableRSGroup.java:80) > {code} > TestEnableRSGroup:80: > {code:java} > // check if master started successfully > assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448054#comment-16448054 ] Hudson commented on HBASE-20465: Results for branch master [build #309 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/309/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/309//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/309//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/309//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Fix TestEnableRSGroup flaky > --- > > Key: HBASE-20465 > URL: https://issues.apache.org/jira/browse/HBASE-20465 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20465.master.001.patch > > > Most recent {{TestEnableRSGroup}} tests failed on branch-2.0 according to our > flaky dashboard. > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.rsgroup.TestEnableRSGroup.testEnableRSGroup(TestEnableRSGroup.java:80) > {code} > TestEnableRSGroup:80: > {code:java} > // check if master started successfully > assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447565#comment-16447565 ] Hudson commented on HBASE-20465: Results for branch branch-2.0 [build #211 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/211/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/211//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/211//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/211//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Fix TestEnableRSGroup flaky > --- > > Key: HBASE-20465 > URL: https://issues.apache.org/jira/browse/HBASE-20465 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20465.master.001.patch > > > Most recent {{TestEnableRSGroup}} tests failed on branch-2.0 according to our > flaky dashboard. > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.rsgroup.TestEnableRSGroup.testEnableRSGroup(TestEnableRSGroup.java:80) > {code} > TestEnableRSGroup:80: > {code:java} > // check if master started successfully > assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447537#comment-16447537 ] Hudson commented on HBASE-20465: Results for branch branch-2 [build #648 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/648/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/648//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/648//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/648//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Fix TestEnableRSGroup flaky > --- > > Key: HBASE-20465 > URL: https://issues.apache.org/jira/browse/HBASE-20465 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20465.master.001.patch > > > Most recent {{TestEnableRSGroup}} tests failed on branch-2.0 according to our > flaky dashboard. > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.rsgroup.TestEnableRSGroup.testEnableRSGroup(TestEnableRSGroup.java:80) > {code} > TestEnableRSGroup:80: > {code:java} > // check if master started successfully > assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445881#comment-16445881 ] Hadoop QA commented on HBASE-20465: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 14s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 29s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 13m 8s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 4s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f | | JIRA Issue | HBASE-20465 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12920022/HBASE-20465.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b93953e3fa15 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 914de11416 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC3 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12568/testReport/ | | Max. process+thread count | 1738 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12568/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fix TestEnableRSGroup
[jira] [Commented] (HBASE-20465) Fix TestEnableRSGroup flaky
[ https://issues.apache.org/jira/browse/HBASE-20465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445843#comment-16445843 ] Balazs Meszaros commented on HBASE-20465: - I was not able to reproduce the error locally, but I think the cause of the problem is that master stop and start overlap each other, because we did not wait until master stops. {code:java} TEST_UTIL.getMiniHBaseCluster().stopMaster(0); // ... TEST_UTIL.getMiniHBaseCluster().startMaster(); TEST_UTIL.getMiniHBaseCluster().waitForActiveAndReadyMaster(6); assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); {code} One possible scenario for the error: 1. Previous master is still running {{mt.getMaster().isActiveMaster() && mt.getMaster().isInitialized()}}, then {{waitForActiveAndReadyMaster}} will return. 2. Previous master stops, but new master hasn't started yet. 3. {{getMaster}} will return {{null}}, because no master thread satisfies this condition {{mt.getMaster().isActiveMaster() && !mt.getMaster().isStopped()}}. > Fix TestEnableRSGroup flaky > --- > > Key: HBASE-20465 > URL: https://issues.apache.org/jira/browse/HBASE-20465 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.0.0 >Reporter: Balazs Meszaros >Assignee: Balazs Meszaros >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20465.master.001.patch > > > Most recent {{TestEnableRSGroup}} tests failed on branch-2.0 according to our > flaky dashboard. > {code} > java.lang.AssertionError > at > org.apache.hadoop.hbase.rsgroup.TestEnableRSGroup.testEnableRSGroup(TestEnableRSGroup.java:80) > {code} > TestEnableRSGroup:80: > {code:java} > // check if master started successfully > assertTrue(TEST_UTIL.getMiniHBaseCluster().getMaster() != null); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)