[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761377#comment-16761377
]
Hudson commented on HBASE-20485:
Results for branch branch-2.0
[build #1322 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1322/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1322//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1322//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1322//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Copy constructor of Scan doesn't copy the readType and replicaId
>
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Nihal Jain
>Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0, 2.1.0, 2.0.5
>
> Attachments: HBASE-20485.master.001.patch,
> HBASE-20485.master.002.patch, HBASE-20485.master.003.patch,
> HBASE-20485.master.004.patch
>
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469111#comment-16469111
]
Hudson commented on HBASE-20485:
Results for branch branch-2
[build #714 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/714/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/714//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/714//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/714//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Copy constructor of Scan doesn't copy the readType and replicaId
>
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Nihal Jain
>Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20485.master.001.patch,
> HBASE-20485.master.002.patch, HBASE-20485.master.003.patch,
> HBASE-20485.master.004.patch
>
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468770#comment-16468770
]
Hudson commented on HBASE-20485:
Results for branch master
[build #325 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/325/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Copy constructor of Scan doesn't copy the readType and replicaId
>
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Nihal Jain
>Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20485.master.001.patch,
> HBASE-20485.master.002.patch, HBASE-20485.master.003.patch,
> HBASE-20485.master.004.patch
>
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468562#comment-16468562 ] Chia-Ping Tsai commented on HBASE-20485: The failure should bot unrelated to the patch. Also loop the TestSaslFanOutOneBlockAsyncDFSOutput with patch 10 times. All pass. Will commit it to master and branch-2. [~stack] This is not a critical bug so I ignore the branch-2.0 > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-20485.master.001.patch, > HBASE-20485.master.002.patch, HBASE-20485.master.003.patch, > HBASE-20485.master.004.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464874#comment-16464874
]
Hadoop QA commented on HBASE-20485:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
15s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}162m 21s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}215m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12922145/HBASE-20485.master.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 43d443f93b32 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11
12:16:42 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / acd0d1e446 |
| maven | version: Apache Maven 3.5.3
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464814#comment-16464814 ] Nihal Jain commented on HBASE-20485: Sure. Attaching a new patch in a moment. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch, > HBASE-20485.master.002.patch, HBASE-20485.master.003.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464809#comment-16464809 ] Chia-Ping Tsai commented on HBASE-20485: The patch LGTM but it would be better to have tests of hbase-server pass before commit. Could you add a trivial change to hbase-server to trigger more tests? > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch, > HBASE-20485.master.002.patch, HBASE-20485.master.003.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464805#comment-16464805 ] Nihal Jain commented on HBASE-20485: Gentle ping [~chia7712]. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch, > HBASE-20485.master.002.patch, HBASE-20485.master.003.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456160#comment-16456160
]
Hadoop QA commented on HBASE-20485:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
56s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
10s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 35s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920971/HBASE-20485.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 0010cb4d1f75 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 39cf42be9a |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12669/testReport/ |
| Max. process+thread count | 262 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12669/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Copy constructor of Scan
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456111#comment-16456111 ] Nihal Jain commented on HBASE-20485: Fixed check-style issue. Please review. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch, > HBASE-20485.master.002.patch, HBASE-20485.master.003.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453350#comment-16453350
]
Hadoop QA commented on HBASE-20485:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
25s{color} | {color:red} hbase-client: The patch generated 1 new + 12 unchanged
- 0 fixed = 13 total (was 12) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
0s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920670/HBASE-20485.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8ea92bdaad7f 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12
21:23:04 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 8a30acf46f |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/12646/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12646/testReport/ |
| Max. process+thread count | 285 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453077#comment-16453077
]
Hadoop QA commented on HBASE-20485:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
39s{color} | {color:red} hbase-client: The patch generated 1 new + 12 unchanged
- 0 fixed = 13 total (was 12) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
3s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920670/HBASE-20485.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b3f016515939 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 12c45cb2e8 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/12639/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12639/testReport/ |
| Max. process+thread count | 279 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452516#comment-16452516 ] Anoop Sam John commented on HBASE-20485: Nice.. I too thought of having a reflection based UT for preventing such things in future. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452097#comment-16452097 ] Ashish Singhi commented on HBASE-20485: --- Good finding, [~nihaljain.cs]!! > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452093#comment-16452093
]
Nihal Jain commented on HBASE-20485:
[~chia7712] Seems like we already have an API for this in package
org.apache.commons.lang3.builder.EqualsBuilder.
It also has an option to exclude field, if any.
{{Appending the following statement at the end of *testScanCopyConstructor()*
in above patch.}}
{code:java}
assertTrue("Make sure copy constructor adds all fields in copied object",
EqualsBuilder.reflectionEquals(scan, scanCopy));
{code}
[~mdrob] This will only be in test, so won't be an issue.
> Copy constructor of Scan doesn't copy the readType and replicaId
>
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Nihal Jain
>Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0
>
> Attachments: HBASE-20485.master.001.patch
>
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452083#comment-16452083 ] Mike Drob commented on HBASE-20485: --- Is reflection going to be slow? > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451987#comment-16451987 ] Ashish Singhi commented on HBASE-20485: --- I think by some means if we can check the size of actual and copied object in test then that should be fine. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451985#comment-16451985
]
Chia-Ping Tsai commented on HBASE-20485:
{quote}I think we can use reflection for a generic solution. Something like
this: [Compare two objects field by
field|https://stackoverflow.com/questions/32196069/compare-two-objects-field-by-field-and-show-the-difference]?
{quote}
Seems good. Most fields are primitive type so the equal() should work. How to
omit the fields which won't be copied? Introduce an annotation?
> Copy constructor of Scan doesn't copy the readType and replicaId
>
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Nihal Jain
>Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0
>
> Attachments: HBASE-20485.master.001.patch
>
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451974#comment-16451974 ] Nihal Jain commented on HBASE-20485: I think we can use reflection for a generic solution. Something like this: [Compare two objects field by field|https://stackoverflow.com/questions/32196069/compare-two-objects-field-by-field-and-show-the-difference]? > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451956#comment-16451956 ] Ashish Singhi commented on HBASE-20485: --- Just thinking, is there any way to avoid such mistakes in the future ? Where any new property added for Scan is not missed from the copy constructor. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451870#comment-16451870 ] Nihal Jain commented on HBASE-20485: Sure [~chia7712]. I will attach a new patch with the afore-mentioned APIs. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451839#comment-16451839 ] Chia-Ping Tsai commented on HBASE-20485: Nice testing! nit: Could we avoid use the deprecated APIs? All of them have replacement stuffs. # setMaxVersions -> readVersions # setStartRow -> withStartRow # setStopRow -> withStopRow > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0 > > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451817#comment-16451817
]
Hadoop QA commented on HBASE-20485:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
18s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20485 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920592/HBASE-20485.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 49279cbe9d3b 4.4.0-98-generic #121-Ubuntu SMP Tue Oct 10
14:24:03 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a8be3bb814 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12628/testReport/ |
| Max. process+thread count | 300 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12628/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Copy constructor of Scan
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType and replicaId
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451739#comment-16451739 ] Nihal Jain commented on HBASE-20485: Hi I have attached a patch which sets readType and replicaId for scan object. please review. > Copy constructor of Scan doesn't copy the readType and replicaId > > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Nihal Jain >Priority: Minor > Labels: beginner, beginners > Attachments: HBASE-20485.master.001.patch > > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451711#comment-16451711
]
Chia-Ping Tsai commented on HBASE-20485:
{quote}Okay should we fix setting of replicaId for scan (get/scan) along with
the readtype fix.?
{quote}
Ya, we should fix both of them and add a test to compare the fields of scan.
Are you going to take over this issue? If so, could you update the topic?
> Copy constructor of Scan doesn't copy the readType
> --
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: beginner, beginners
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451704#comment-16451704 ] Nihal Jain commented on HBASE-20485: Okay should we fix setting of replicaId for scan (get/scan) along with the readtype fix.? > Copy constructor of Scan doesn't copy the readType > -- > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Priority: Minor > Labels: beginner, beginners > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType
[
https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451703#comment-16451703
]
Chia-Ping Tsai commented on HBASE-20485:
{quote}I was writing some UT and found that copy constructor does not even copy
the replicaId of the original scan object. Is it deliberate?
{quote}
Good catching. The replicaId should be copied also. BTW, we also neglect to
copy replicaId when constructing a scan by get
> Copy constructor of Scan doesn't copy the readType
> --
>
> Key: HBASE-20485
> URL: https://issues.apache.org/jira/browse/HBASE-20485
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: beginner, beginners
>
> The field was introduced by HBASE-17045.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451693#comment-16451693 ] Nihal Jain commented on HBASE-20485: Hi, I was writing some UT and found that copy constructor does not even copy the replicaId of the original scan object. Is it deliberate? > Copy constructor of Scan doesn't copy the readType > -- > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Priority: Minor > Labels: beginner, beginners > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20485) Copy constructor of Scan doesn't copy the readType
[ https://issues.apache.org/jira/browse/HBASE-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451601#comment-16451601 ] Anoop Sam John commented on HBASE-20485: We should add a UT in testScan to make sure all fields are copied. In the past also similar issues were raised after adding new fields to Scan > Copy constructor of Scan doesn't copy the readType > -- > > Key: HBASE-20485 > URL: https://issues.apache.org/jira/browse/HBASE-20485 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Priority: Trivial > Labels: beginner, beginners > > The field was introduced by HBASE-17045. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
