[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-10 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470325#comment-16470325
 ] 

Hudson commented on HBASE-20539:


Results for branch master
[build #326 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/326/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/326//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/326//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/326//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch, HBASE-20539.branch-2.0.002.patch, 
> HBASE-20539.branch-2.0.003.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-09 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469730#comment-16469730
 ] 

Hudson commented on HBASE-20539:


Results for branch branch-2.0
[build #279 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/279/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/279//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/279//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/279//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch, HBASE-20539.branch-2.0.002.patch, 
> HBASE-20539.branch-2.0.003.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-09 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469684#comment-16469684
 ] 

Hudson commented on HBASE-20539:


Results for branch branch-2
[build #715 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/715/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/715//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/715//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/715//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch, HBASE-20539.branch-2.0.002.patch, 
> HBASE-20539.branch-2.0.003.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468485#comment-16468485
 ] 

Hadoop QA commented on HBASE-20539:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 8s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
19s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 1s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
11s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
21s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
12m  3s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}113m 
54s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m  
6s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
43s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}175m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:369877d |
| JIRA Issue | HBASE-20539 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12922587/HBASE-20539.branch-2.0.003.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e0c78d45c04d 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2.0 / c15fd6b00a |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
|

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468175#comment-16468175
 ] 

Hadoop QA commented on HBASE-20539:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
12s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
57s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
14s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
26s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
41s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
 7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
35s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
9m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}108m 57s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m  
8s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
38s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}160m  5s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestAcidGuaranteesWithNoInMemCompaction |
|   | hadoop.hbase.quotas.TestQuotaTableUtil |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:369877d |
| JIRA Issue | HBASE-20539 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12922538/HBASE-20539.branch-2.0.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 86e793d63c8f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468024#comment-16468024
 ] 

stack commented on HBASE-20539:
---

Retry. Failure was the old DLS... failed to close XML flie failure.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch, HBASE-20539.branch-2.0.002.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467972#comment-16467972
 ] 

Hadoop QA commented on HBASE-20539:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
20s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
59s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
30s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
35s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
10m  1s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}154m 35s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 
26s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
46s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}209m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:369877d |
| JIRA Issue | HBASE-20539 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12922490/HBASE-20539.branch-2.0.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 07f6ea3a7d0d 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 
19:38:41 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2.0 / 9e3b28804d |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467969#comment-16467969
 ] 

Hadoop QA commented on HBASE-20539:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.0 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
28s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
15s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
19s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
58s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
43s{color} | {color:green} branch-2.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} branch-2.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
47s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
11m  1s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m 
52s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m  
2s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
32s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 33s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:369877d |
| JIRA Issue | HBASE-20539 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12922507/HBASE-20539.branch-2.0.002.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 2202e020096a 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2.0 / 9e3b28804d |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
|

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread Peter Somogyi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467796#comment-16467796
 ] 

Peter Somogyi commented on HBASE-20539:
---

Thanks [~stack]!

+1

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467790#comment-16467790
 ] 

stack commented on HBASE-20539:
---

.002 addresses [~psomogyi] comment. Thanks for the review.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch, 
> HBASE-20539.branch-2.0.002.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread Peter Somogyi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467768#comment-16467768
 ] 

Peter Somogyi commented on HBASE-20539:
---

I left this comment on ReviewBoard: The test name suggests that we assert for 
NONE compaction policy but actually the test verifies that PE uses the default 
value. I would either change the test name or change the assertion to 
MemoryCompactionPolicy.NONE instead of the default value.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467724#comment-16467724
 ] 

stack commented on HBASE-20539:
---

See subtask for a corner missed by this patch when changing defaults back to 
having IMC on by default.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467711#comment-16467711
 ] 

stack commented on HBASE-20539:
---

.001 Set default for in-memory compaction to NONE. PE was using this value 
creating its table. Add test to ensure expected default.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
> Attachments: HBASE-20539.branch-2.0.001.patch
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467696#comment-16467696
 ] 

stack commented on HBASE-20539:
---

Ok. Minor issue in PE. It picks up whatever the 
COMPACTING_MEMSTORE_TYPE_DEFAULT is for in-memory-compaction on the TestTable 
family. Small fix.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.1
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20539) Disable IMC; part 2

2018-05-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467667#comment-16467667
 ] 

stack commented on HBASE-20539:
---

Having a bit of trouble with this one. Locally wth unit test all looks good but 
out on my cluster I am not picking up the default NONE in hbase-default.xml... 
and so see stuff like this:

  25453 2018-05-08 09:34:11,871 INFO  
[StoreOpener-88eb562860c251ec625f301da56e4123-1] regionserver.HStore: 
inMemoryCompactionPolicy=BASIC, ms=class 
org.apache.hadoop.hbase.regionserver.CompactingMemStore

Or, running w/ a bad patch that throws NPEs... I see we are referring to 
compactingmemstore...

{code}
1198945 java.lang.NullPointerException
1198946   at 
org.apache.hadoop.hbase.util.CollectionBackedScanner.init(CollectionBackedScanner.java:77)
1198947   at 
org.apache.hadoop.hbase.util.CollectionBackedScanner.(CollectionBackedScanner.java:50)
1198948   at 
org.apache.hadoop.hbase.regionserver.Segment.getScannersForSnapshot(Segment.java:141)
1198949   at 
org.apache.hadoop.hbase.regionserver.MemStoreSnapshot.(MemStoreSnapshot.java:44)
1198950   at 
org.apache.hadoop.hbase.regionserver.CompactingMemStore.snapshot(CompactingMemStore.java:216)
1198951   at 
org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.prepare(HStore.java:2203)
1198952   at 
org.apache.hadoop.hbase.regionserver.HRegion.lambda$internalPrepareFlushCache$2(HRegion.java:2493)
1198953   at java.util.TreeMap.forEach(TreeMap.java:1005)
1198954   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2492)
1198955   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2364)
1198956   at 
org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2338)
1198957   at 
org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2229)
1198958   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:607)
1198959   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushOneForGlobalPressure(MemStoreFlusher.java:290)
1198960   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$700(MemStoreFlusher.java:68)
1198961   at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:346)
1198962   at java.lang.Thread.run(Thread.java:748)
{code}

It may be just an issue on my cluster... but I'm running tip of branch-2.0.

> Disable IMC; part 2
> ---
>
> Key: HBASE-20539
> URL: https://issues.apache.org/jira/browse/HBASE-20539
> Project: HBase
>  Issue Type: Sub-task
>  Components: in-memory-compaction
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.1
>
>
> Just noticed that post-flush, we are picking up a CompactingMemStore though 
> IMC is supposed to be off. We are picking up an inMemoryCompaction of BASIC 
> (noticed a day or so ago by [~chia7712]) and so, we fall into the default in 
> HStore#getMemstore which is set to be a CompactingMemStore
> No real perf difference going by the compares I've been running but let me 
> clean this up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)