[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528774#comment-16528774 ] Mingdao Yang commented on HBASE-20575: -- [~chia7712] Thanks for the review. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528404#comment-16528404 ] Hudson commented on HBASE-20575: Results for branch branch-1.3 [build #377 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/377/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/377//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/377//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/377//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528309#comment-16528309 ] Hudson commented on HBASE-20575: Results for branch branch-1.2 [build #381 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/381/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/381//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/381//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/381//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527952#comment-16527952 ] Hudson commented on HBASE-20575: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1125 (See [https://builds.apache.org/job/HBase-1.2-IT/1125/]) HBASE-20575 Fail to config COMPACTION_ENABLED by hbase shell (chia7712: rev 3845c089dfdc4e2f7d880d87ee555fd49318020b) * (edit) hbase-shell/src/main/ruby/hbase/admin.rb * (edit) hbase-shell/src/test/ruby/hbase/admin_test.rb > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527934#comment-16527934 ] Hudson commented on HBASE-20575: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #426 (See [https://builds.apache.org/job/HBase-1.3-IT/426/]) HBASE-20575 Fail to config COMPACTION_ENABLED by hbase shell (chia7712: rev 673e6333781261573a5c536558ad9b40056920aa) * (edit) hbase-shell/src/test/ruby/hbase/admin_test.rb > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527905#comment-16527905 ] Chia-Ping Tsai commented on HBASE-20575: +1 nice fix. Will commit it later. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-20575-branch-1.2.v4.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527902#comment-16527902 ] Hadoop QA commented on HBASE-20575: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 48s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 18s{color} | {color:green} branch-1.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 17s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 5 new + 996 unchanged - 4 fixed = 1001 total (was 1000) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 20s{color} | {color:orange} The patch generated 19 new + 877 unchanged - 0 fixed = 896 total (was 877) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} the patch passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 30s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 52s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:13ca256 | | JIRA Issue | HBASE-20575 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12929723/HBASE-20575-branch-1.2.v4.patch | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 17c50f7d054e 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-1.2 / 20772f1 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_181 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 | | rubocop | v0.57.2 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/13453/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/13453/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13453/testReport/ | | Max. process+thread count | 565 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13453/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch, HBASE-205
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526401#comment-16526401 ] Chia-Ping Tsai commented on HBASE-20575: {code:java} /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:202:17: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:205:7: C: Layout/AlignParameters: Align the parameters of a method call if they span more than one line. /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:205:25: C: Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them. /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:207:81: C: Metrics/LineLength: Line is too long. [87/80] /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:208:81: C: Metrics/LineLength: Line is too long. [101/80] /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:213:81: C: Metrics/LineLength: Line is too long. [118/80] /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:213:84: C: Layout/SpaceAfterComma: Space missing after comma. /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:214:81: C: Metrics/LineLength: Line is too long. [132/80] /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:214:98: C: Layout/SpaceAfterComma: Space missing after comma.{code} Seems some suggestions can be addressed. [~mingdaoy] Could you update the patch? thanks. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525915#comment-16525915 ] Mingdao Yang commented on HBASE-20575: -- Yes, they are. But, I found those are actually false warnings or Ruby style suggestions. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521817#comment-16521817 ] Chia-Ping Tsai commented on HBASE-20575: Are the rubocop warnings related to the patch? > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520984#comment-16520984 ] Hadoop QA commented on HBASE-20575: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 17m 52s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 25s{color} | {color:green} branch-1.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 9s{color} | {color:red} The patch generated 12 new + 996 unchanged - 4 fixed = 1008 total (was 1000) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 14s{color} | {color:orange} The patch generated 19 new + 877 unchanged - 0 fixed = 896 total (was 877) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s{color} | {color:green} the patch passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green} the patch passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 36s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 29m 32s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:13ca256 | | JIRA Issue | HBASE-20575 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928855/HBASE-20575-branch-1.2.v3.patch | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 1b8d62e55ff5 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-1.2 / 20772f1 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_181 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 | | rubocop | v0.57.2 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/13356/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/13356/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13356/testReport/ | | Max. process+thread count | 619 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13356/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch, > HBASE-20575-branch-1.2.v3.patch > > > HBA
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520249#comment-16520249 ] Hadoop QA commented on HBASE-20575: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color} | {color:red} HBASE-20575 does not apply to branch-1.2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-20575 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928750/HBASE-20575-branch-1.2.v2.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13349/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch, > HBASE-20575-branch-1.2.v1.patch, HBASE-20575-branch-1.2.v2.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513411#comment-16513411 ] Hadoop QA commented on HBASE-20575: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 37s{color} | {color:green} branch-1.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 16s{color} | {color:red} The patch generated 13 new + 997 unchanged - 3 fixed = 1010 total (was 1000) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 19s{color} | {color:orange} The patch generated 19 new + 877 unchanged - 0 fixed = 896 total (was 877) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} the patch passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} the patch passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 43s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 20m 29s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:13ca256 | | JIRA Issue | HBASE-20575 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12927935/HBASE-20575-branch-1.2.v1.patch | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 6df5bff59eb1 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-1.2 / 20772f1 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_181 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 | | rubocop | v0.57.2 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/artifact/patchprocess/diff-patch-ruby-lint.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/artifact/patchprocess/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/artifact/patchprocess/whitespace-tabs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/testReport/ | | Max. process+thread count | 619 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13269/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://i
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473559#comment-16473559 ] Chia-Ping Tsai commented on HBASE-20575: Could you add a test? There is already a test against the table options. It is a nice reference. {code:java|title=admin.test.rb} define_test "create should be able to set table options" do drop_test_table(@create_test_name) admin.create(@create_test_name, 'a', 'b', 'MAX_FILESIZE' => 12345678, OWNER => '987654321', FLUSH_POLICY => 'org.apache.hadoop.hbase.regionserver.FlushAllLargeStoresPolicy', SPLIT_POLICY => 'org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy', REGION_MEMSTORE_REPLICATION => 'TRUE') assert_equal(['a:', 'b:'], table(@create_test_name).get_all_columns.sort) assert_match(/12345678/, admin.describe(@create_test_name)) assert_match(/987654321/, admin.describe(@create_test_name)) assert_match(/org.apache.hadoop.hbase.regionserver.FlushAllLargeStoresPolicy/,admin.describe(@create_test_name)) assert_match(/org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy/,admin.describe(@create_test_name)) assert_match(/REGION_MEMSTORE_REPLICATION/, admin.describe(@create_test_name)) end{code} > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473548#comment-16473548 ] Hadoop QA commented on HBASE-20575: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-1.2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 4s{color} | {color:green} branch-1.2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s{color} | {color:red} The patch generated 2 new + 735 unchanged - 2 fixed = 737 total (was 737) {color} | | {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m 3s{color} | {color:green} There were no new ruby-lint issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s{color} | {color:green} the patch passed with JDK v1.8.0_172 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed with JDK v1.7.0_181 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 14s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:e77c578 | | JIRA Issue | HBASE-20575 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12923205/HBASE-20575-branch-1.2.patch | | Optional Tests | asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux ddd0ad228cde 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-1.2 / 797a352 | | maven | version: Apache Maven 3.0.5 | | Default Java | 1.7.0_181 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_172 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_181 | | rubocop | v0.55.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/12800/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12800/testReport/ | | Max. process+thread count | 630 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12800/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompact
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473443#comment-16473443 ] Mingdao Yang commented on HBASE-20575: -- On master branch, it is htd.setCompactionEnabled(JBoolean.valueOf(arg.delete{color:red}(org.apache.hadoop.hbase.HTableDescriptor::{color}COMPACTION_ENABLED))) if arg{color:red}.include?(org.apache.hadoop.hbase.HTableDescriptor::{color}COMPACTION_ENABLED) > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > Attachments: HBASE-20575-branch-1.2.patch > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472949#comment-16472949 ] Chia-Ping Tsai commented on HBASE-20575: {quote}I'd like to try my hand at this. Thanks {quote} Thanks for picking this jira. > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20575) Fail to config COMPACTION_ENABLED by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472948#comment-16472948 ] Mingdao Yang commented on HBASE-20575: -- Hi, I'd like to try my hand at this. Thanks > Fail to config COMPACTION_ENABLED by hbase shell > > > Key: HBASE-20575 > URL: https://issues.apache.org/jira/browse/HBASE-20575 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.3.2 >Reporter: Chia-Ping Tsai >Assignee: Mingdao Yang >Priority: Major > Fix For: 1.2.7, 1.3.3 > > > HBASE-19340 backported the missing option from 1.4+ to 1.3 and 1.2. However, > we made a mistaken to COMPACTION_ENABLED. > {code:java} > htd.setCompactionEnabled(JBoolean.valueOf(arg.delete[COMPACTION_ENABLED])) if > arg[COMPACTION_ENABLED]{code} > arg.delete[COMPACTION_ENABLED] should be changed to > arg.delete(COMPACTION_ENABLED) -- This message was sent by Atlassian JIRA (v7.6.3#76005)