[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961887#comment-16961887
]
Hudson commented on HBASE-20626:
Results for branch branch-1
[build #1121 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1121/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1121//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1121//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1121//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Change the value of "Requests Per Second" on WEBUI
> --
>
> Key: HBASE-20626
> URL: https://issues.apache.org/jira/browse/HBASE-20626
> Project: HBase
> Issue Type: Improvement
> Components: metrics, UI
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8, 1.5.1
>
> Attachments: HBASE-20626.master.001.patch,
> HBASE-20626.master.002.patch, HBASE-20626.master.003.patch
>
>
> Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate
> requests per second.
> After HBASE-18469, "totalRequestCount" count only once for multi
> request.(Includes requests that are not serviced by regions.)
> When we have a large number of read and write requests, the value of
> "Requests Per Second" is very small which does not reflect the load of the
> cluster.
> Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate
> RPS?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953374#comment-16953374
]
Hudson commented on HBASE-20626:
Results for branch branch-2.1
[build #1681 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1681/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1681//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1681//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1681//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Change the value of "Requests Per Second" on WEBUI
> --
>
> Key: HBASE-20626
> URL: https://issues.apache.org/jira/browse/HBASE-20626
> Project: HBase
> Issue Type: Improvement
> Components: metrics, UI
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-20626.master.001.patch,
> HBASE-20626.master.002.patch, HBASE-20626.master.003.patch
>
>
> Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate
> requests per second.
> After HBASE-18469, "totalRequestCount" count only once for multi
> request.(Includes requests that are not serviced by regions.)
> When we have a large number of read and write requests, the value of
> "Requests Per Second" is very small which does not reflect the load of the
> cluster.
> Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate
> RPS?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953336#comment-16953336
]
Hudson commented on HBASE-20626:
Results for branch branch-2
[build #2325 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2325/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2325//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2325//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2325//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Change the value of "Requests Per Second" on WEBUI
> --
>
> Key: HBASE-20626
> URL: https://issues.apache.org/jira/browse/HBASE-20626
> Project: HBase
> Issue Type: Improvement
> Components: metrics, UI
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-20626.master.001.patch,
> HBASE-20626.master.002.patch, HBASE-20626.master.003.patch
>
>
> Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate
> requests per second.
> After HBASE-18469, "totalRequestCount" count only once for multi
> request.(Includes requests that are not serviced by regions.)
> When we have a large number of read and write requests, the value of
> "Requests Per Second" is very small which does not reflect the load of the
> cluster.
> Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate
> RPS?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953309#comment-16953309
]
Hudson commented on HBASE-20626:
Results for branch branch-2.2
[build #664 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/664/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/664//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/664//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/664//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Change the value of "Requests Per Second" on WEBUI
> --
>
> Key: HBASE-20626
> URL: https://issues.apache.org/jira/browse/HBASE-20626
> Project: HBase
> Issue Type: Improvement
> Components: metrics, UI
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-20626.master.001.patch,
> HBASE-20626.master.002.patch, HBASE-20626.master.003.patch
>
>
> Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate
> requests per second.
> After HBASE-18469, "totalRequestCount" count only once for multi
> request.(Includes requests that are not serviced by regions.)
> When we have a large number of read and write requests, the value of
> "Requests Per Second" is very small which does not reflect the load of the
> cluster.
> Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate
> RPS?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952879#comment-16952879
]
Hudson commented on HBASE-20626:
Results for branch master
[build #1507 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1507/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1507//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1507//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1507//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Change the value of "Requests Per Second" on WEBUI
> --
>
> Key: HBASE-20626
> URL: https://issues.apache.org/jira/browse/HBASE-20626
> Project: HBase
> Issue Type: Improvement
> Components: metrics, UI
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: HBASE-20626.master.001.patch,
> HBASE-20626.master.002.patch, HBASE-20626.master.003.patch
>
>
> Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate
> requests per second.
> After HBASE-18469, "totalRequestCount" count only once for multi
> request.(Includes requests that are not serviced by regions.)
> When we have a large number of read and write requests, the value of
> "Requests Per Second" is very small which does not reflect the load of the
> cluster.
> Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate
> RPS?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952724#comment-16952724 ] Guangxu Cheng commented on HBASE-20626: --- All tests pass locally. Pushed to master and branch-2. [~apurtell] branch-1 and branch-1.4 need this ? [~zhangduo] [~zghao] What about branch-2.2 and branch-2.1 ? > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch, > HBASE-20626.master.002.patch, HBASE-20626.master.003.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952693#comment-16952693
]
HBase QA commented on HBASE-20626:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
6s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
31s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 32s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}163m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}220m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.3 Server=19.03.3 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/958/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-20626 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983127/HBASE-20626.master.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f0de2a476122 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 7924ba39e7 |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[
https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952569#comment-16952569
]
HBase QA commented on HBASE-20626:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
30s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}240m 4s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}300m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterShutdown |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.3 Server=19.03.3 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/956/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-20626 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966336/HBASE-20626.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6dc6a9d67b7b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 7924ba39e7 |
| Default Java | 1.
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951668#comment-16951668 ] Guangxu Cheng commented on HBASE-20626: --- Thanks all for reviewing. Will commit it tomorrow if no objections. Thanks > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch, > HBASE-20626.master.002.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824264#comment-16824264 ] stack commented on HBASE-20626: --- Makes sense to me too. [~zghaobac] for 2.2.0? > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch, > HBASE-20626.master.002.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824265#comment-16824265 ] stack commented on HBASE-20626: --- When did this change [~andrewcheng] ? > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch, > HBASE-20626.master.002.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821647#comment-16821647 ] Yu Li commented on HBASE-20626: --- Makes sense. Patch LGTM, +1. Thanks for the efforts [~andrewcheng]. > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch, > HBASE-20626.master.002.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820871#comment-16820871 ] Guangxu Cheng commented on HBASE-20626: --- ping [~carp84] [~zghaobac] mind taking a look at it ? thanks > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20626) Change the value of "Requests Per Second" on WEBUI
[ https://issues.apache.org/jira/browse/HBASE-20626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487103#comment-16487103 ] Guangxu Cheng commented on HBASE-20626: --- 1. totalRowActionRequestCount = writeRequestCount + readRequestCount; 2. readRequestsCount = sum(HRegion#readRequestsCount) writeRequestsCount = sum(HRegion#writeRequestsCount) "totalRowActionRequestCount" equals writeRequestCount plus readRequestCount. And "writeRequestCount" and "readRequestCount" are obtained from each region. If some regions move from the RegionserverA to RegionserverB. The current value of "totalRowActionRequestCount" on RegionserverA may be less than the last time. So the value "Requests Per Second" on RegionserverA may be negative in a short time. [~carp84] mind taking a look at it ? thanks > Change the value of "Requests Per Second" on WEBUI > -- > > Key: HBASE-20626 > URL: https://issues.apache.org/jira/browse/HBASE-20626 > Project: HBase > Issue Type: Improvement > Components: metrics, UI >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-20626.master.001.patch > > > Now we use "totalRequestCount"(RSRpcServices#requestCount) to calculate > requests per second. > After HBASE-18469, "totalRequestCount" count only once for multi > request.(Includes requests that are not serviced by regions.) > When we have a large number of read and write requests, the value of > "Requests Per Second" is very small which does not reflect the load of the > cluster. > Maybe it is more reasonable to use "totalRowActionRequestCount" to calculate > RPS? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
