[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548597#comment-16548597
]
Jack Bearden commented on HBASE-20823:
--
Hey [~reidchan]! I wanted to put in a patch for this one and a few other HBase
tickets I found. I am a Hadoop contributor but not yet a contributor for HBase
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Trivial
> Labels: beginner
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548684#comment-16548684
]
Reid Chan commented on HBASE-20823:
---
[~jackbearden] Please feel free to take it.
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Trivial
> Labels: beginner
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548758#comment-16548758
]
Reid Chan commented on HBASE-20823:
---
ping [~stack], can you help grant [~jackbearden] contributor.
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Trivial
> Labels: beginner
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548772#comment-16548772
]
Jack Bearden commented on HBASE-20823:
--
Ok, thanks [~reidchan]. I sent a message [to
d...@hbase.apache.org|mailto:to%c2%a0...@hbase.apache.org]. I'll upload the
patch as soon as I get elevated
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Trivial
> Labels: beginner
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548794#comment-16548794
]
stack commented on HBASE-20823:
---
[~reidchan] Looks like it was done. Shout if you need anything else sir.
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Jack Bearden
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-20823.001.patch
>
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548917#comment-16548917
]
Hadoop QA commented on HBASE-20823:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
40s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}152m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-20823 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12932195/HBASE-20823.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux faf545a5e9fa 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 619e0fdab8 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13683/testReport/ |
| Max. process+thread count | 4246 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13683/console |
| Pow
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549022#comment-16549022
]
Reid Chan commented on HBASE-20823:
---
+1
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Jack Bearden
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-20823.001.patch
>
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549098#comment-16549098
]
Reid Chan commented on HBASE-20823:
---
Pushed to master branch.
Thanks for your contribution [~jackbearden]
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Jack Bearden
>Priority: Trivial
> Labels: beginner
> Attachments: HBASE-20823.001.patch
>
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20823) Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
[
https://issues.apache.org/jira/browse/HBASE-20823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550787#comment-16550787
]
Hudson commented on HBASE-20823:
Results for branch master
[build #402 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/402/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/402//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/402//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/402//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Wrong param name in javadoc for HRegionServer#buildRegionSpaceUseReportRequest
> --
>
> Key: HBASE-20823
> URL: https://issues.apache.org/jira/browse/HBASE-20823
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Jack Bearden
>Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0
>
> Attachments: HBASE-20823.001.patch
>
>
> {code}
> /**
>* Builds a {@link RegionSpaceUseReportRequest} protobuf message from the
> region size map.
>*
>* @param regionSizeStore The size in bytes of regions
>* @return The corresponding protocol buffer message.
>*/
> RegionSpaceUseReportRequest
> buildRegionSpaceUseReportRequest(RegionSizeStore regionSizes)
> {code}
> {{@param regionSizeStore}}, but actual name is regionSizes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
