[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798732#comment-16798732 ] Hudson commented on HBASE-20917: Results for branch branch-1 [build #732 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/732/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/732//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/732//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/732//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.4.6, 2.2.0, 2.0.4, 2.1.3 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798703#comment-16798703 ] Hudson commented on HBASE-20917: Results for branch branch-1.4 [build #709 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/709/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/709//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/709//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/709//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.4.6, 2.2.0, 2.0.4, 2.1.3 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795677#comment-16795677 ] Xu Cang commented on HBASE-20917: - Sounds good [~jatsakthi] Thanks > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.4.6, 2.2.0, 2.0.4, 2.1.3 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795670#comment-16795670 ] Sakthi commented on HBASE-20917: [~xucang], The addendum patch hasn't landed in branch-1 & branch-1.4 though the original patch is present in those 2 branches. Could you please get them in? :) > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.4.6, 2.2.0, 2.0.4, 2.1.3 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743638#comment-16743638 ] Hudson commented on HBASE-20917: Results for branch branch-2.1 [build #774 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/774/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/774//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/774//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/774//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0, 2.0.4, 2.1.3 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727036#comment-16727036 ] stack commented on HBASE-20917: --- Thanks [~busbey] > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0, 2.0.4 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725057#comment-16725057 ] Sean Busbey commented on HBASE-20917: - sorry for not updating. the 2.0.4 patch already landed, so you should be good to go. this is open still for the branch-2.1 backport, which is blocked on HBASE-19722. I think no rush on that one; can wait for the next 2.1 release. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0, 2.0.4 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724693#comment-16724693 ] stack commented on HBASE-20917: --- What should I do here [~busbey]? Or will I push it out of 2.0.4? > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0, 2.0.4 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721995#comment-16721995 ] Hudson commented on HBASE-20917: Results for branch branch-2.0 [build #1165 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1165/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1165//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1165//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1165//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721696#comment-16721696 ] stack commented on HBASE-20917: --- Go for it [~busbey] > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721669#comment-16721669 ] Sean Busbey commented on HBASE-20917: - This is also missing from branch-2.0 and it looks like the same problem is there. [~stack] unless I hear otherwise from you I'm going to push the same patch there that I send to branch-2.1. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug > Components: meta, metrics >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586528#comment-16586528 ] Ted Yu commented on HBASE-20917: Looks like HBASE-19722 had wrong fix version. Waiting for Andrew's confirmation over HBASE-19722. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.0.2, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586516#comment-16586516 ] stack commented on HBASE-20917: --- A bad backport or the fix versions is wrong on HBASE-19722? > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.0.2, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586494#comment-16586494 ] Ted Yu commented on HBASE-20917: Just found out that HBASE-19722 wasn't in branch-2.1 - I cannot find hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MetaTableMetrics.java > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.0.2, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586485#comment-16586485 ] Ted Yu commented on HBASE-20917: bq. is there anything to stop requestsMap being set to null after the check but before the use? As far as I can tell, requestsMap is private. I only found one assignment to this field in the start() method. Meaning after the field is assigned, it wouldn't be set to null. As to why the null check is needed, see the following from description: bq. requestsMap is only initialized for the meta region. bq. It doesn't look like its committed yet. Let me know if I should merge the fix to 2.0 branch or you're going to merge the fix yourself. thanks > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.0.2, 2.2.0, 2.1.1 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586475#comment-16586475 ] stack commented on HBASE-20917: --- Ok. It doesn't look like its committed yet. On the patch, is there anything to stop requestsMap being set to null after the check but before the use? > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586469#comment-16586469 ] Ted Yu commented on HBASE-20917: bq. Should this be in 2.1 and 2.0 branches? I think so. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.0.0, 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586449#comment-16586449 ] stack commented on HBASE-20917: --- Should this be in 2.1 and 2.0 branches? Should mark 3.0 as fixed if it is in master and in branch-2. Thanks. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585668#comment-16585668 ] Hudson commented on HBASE-20917: Results for branch master [build #444 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/444/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/444//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/444//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/444//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585405#comment-16585405 ] Hudson commented on HBASE-20917: Results for branch branch-2 [build #1135 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1135/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1135//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1135//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1135//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585054#comment-16585054 ] Xu Cang commented on HBASE-20917: - [~yuzhih...@gmail.com] Looks good! +1 right, TableName can be compared directly. Thanks. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585014#comment-16585014 ] Ted Yu commented on HBASE-20917: Ping [~xucang] > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576643#comment-16576643 ] Ted Yu commented on HBASE-20917: [~xucang]: Can you take a look at the addendum ? thanks > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.addendum, 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553797#comment-16553797 ] Hudson commented on HBASE-20917: Results for branch branch-1 [build #390 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/390/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/390//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/390//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/390//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553353#comment-16553353 ] Hudson commented on HBASE-20917: Results for branch branch-1.4 [build #394 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/394/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/394//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/394//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/394//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 1.5.0, 1.4.6, 2.2.0 > > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552878#comment-16552878 ] Hudson commented on HBASE-20917: Results for branch master [build #405 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/405/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/405//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/405//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/405//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 2.2.0 > > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552677#comment-16552677 ] Hudson commented on HBASE-20917: Results for branch branch-2 [build #1015 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1015/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1015//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1015//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1015//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 2.2.0 > > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551900#comment-16551900 ] Hadoop QA commented on HBASE-20917: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s{color} | {color:blue} The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.7.0/precommit-patchnames for instructions. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 35s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 39s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 10m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}111m 50s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}153m 41s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20917 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12932571/20917.v2.txt | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b7069b5469d7 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 682aa69677 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_171 | | findbugs | v3.1.0-RC3 | | Test Results |
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551886#comment-16551886 ] Ted Yu commented on HBASE-20917: Looped TestMetaTableMetrics 30 times with v1 - all passed. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551858#comment-16551858 ] Xu Cang commented on HBASE-20917: - [~yuzhih...@gmail.com] You are right, I checked other code, tableName can be compared directly. Using #getName() was unnecessary. Thanks for your fix! +1 > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551854#comment-16551854 ] Ted Yu commented on HBASE-20917: [~xucang]: If read your code correctly, {{start}} method checks hbase:meta table. Since TableName can be compared directly, I simplified the code a little bit in patch v2. Can you take a look ? thanks > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 20917.v1.txt, 20917.v2.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551846#comment-16551846 ] Xu Cang commented on HBASE-20917: - [~yuzhih...@gmail.com] Thanks for fixing this bug! Looks good to me. > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 20917.v1.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20917) MetaTableMetrics#stop references uninitialized requestsMap for non-meta region
[ https://issues.apache.org/jira/browse/HBASE-20917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551844#comment-16551844 ] Ted Yu commented on HBASE-20917: [~xucang]: Can you take a look ? thanks > MetaTableMetrics#stop references uninitialized requestsMap for non-meta region > -- > > Key: HBASE-20917 > URL: https://issues.apache.org/jira/browse/HBASE-20917 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 20917.v1.txt > > > I noticed the following in test output: > {code} > 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] > executor.EventHandler(186): Caught throwable while processing event > M_RS_CLOSE_REGION > java.lang.NullPointerException > at > org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) > at > org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) > at > org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) > at > org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) > at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) > at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) > at > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) > at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > {code} > {{requestsMap}} is only initialized for the meta region. > However, check for meta region is absent in the stop method: > {code} > public void stop(CoprocessorEnvironment e) throws IOException { > // since meta region can move around, clear stale metrics when stop. > for (String meterName : requestsMap.keySet()) { > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)