[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026415#comment-17026415 ] Hudson commented on HBASE-20950: Results for branch branch-2.1 [build #1788 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1788/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1788//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1788//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1788//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch, HBASE-20950.master.003.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565369#comment-16565369 ] Hudson commented on HBASE-20950: Results for branch master [build #415 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/415/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/415//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/415//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/415//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch, HBASE-20950.master.003.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564683#comment-16564683 ] Hudson commented on HBASE-20950: Results for branch branch-2 [build #1051 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1051/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1051//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1051//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1051//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch, HBASE-20950.master.003.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564353#comment-16564353 ] Wei-Chiu Chuang commented on HBASE-20950: - Thanks, [~yuzhih...@gmail.com]! > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch, HBASE-20950.master.003.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564286#comment-16564286 ] Hadoop QA commented on HBASE-20950: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 32s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 54s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 10s{color} | {color:green} hbase-server: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} The patch hbase-thrift passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 35s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}124m 15s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 43s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 18s{color} | {color:green} hbase-endpoint in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}181m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20950 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933792/HBASE-20950.master.003.patch | | Optional Tests |
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563954#comment-16563954 ] Wei-Chiu Chuang commented on HBASE-20950: - Attach rev003 to fix the test failure and correct the checkstyle warning. > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch, HBASE-20950.master.003.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560582#comment-16560582 ] Hadoop QA commented on HBASE-20950: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 40s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 57s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 14s{color} | {color:red} hbase-server: The patch generated 3 new + 5 unchanged - 1 fixed = 8 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 43s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 10m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}124m 45s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 20s{color} | {color:red} hbase-thrift in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 54s{color} | {color:green} hbase-endpoint in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 2s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}183m 42s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.thrift.TestThriftSpnegoHttpServer | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20950 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933451/HBASE-20950.master.002.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 53b74c794f95 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560558#comment-16560558 ] Hadoop QA commented on HBASE-20950: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 21s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 53s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 3s{color} | {color:red} hbase-server: The patch generated 3 new + 5 unchanged - 1 fixed = 8 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 22s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}159m 56s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 5s{color} | {color:red} hbase-thrift in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 25s{color} | {color:green} hbase-endpoint in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}217m 43s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.thrift.TestThriftSpnegoHttpServer | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20950 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12933443/HBASE-20950.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e21a938c7658 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven |
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560514#comment-16560514 ] Wei-Chiu Chuang commented on HBASE-20950: - Attach patch v002 to address Ted's review comments. > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Attachments: HBASE-20950.master.001.patch, > HBASE-20950.master.002.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560483#comment-16560483 ] Ted Yu commented on HBASE-20950: If the test normally passes, there is no need for this change. > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Attachments: HBASE-20950.master.001.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560467#comment-16560467 ] Wei-Chiu Chuang commented on HBASE-20950: - Thanks for the review, [~yuzhih...@gmail.com]. This particular change is actually unrelated to the main issue found in this jira, but while testing I found the CLUSTER object could throw NPE if the test fails unexpectedly. I can restore this change for sure. > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Attachments: HBASE-20950.master.001.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20950) Helper method to configure secure DFS cluster for tests
[ https://issues.apache.org/jira/browse/HBASE-20950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560452#comment-16560452 ] Ted Yu commented on HBASE-20950: Looks good overall. {code} + CLUSTER.join(); } -CLUSTER.join(); {code} I am a bit curious - why moving the join call outside the if ? > Helper method to configure secure DFS cluster for tests > --- > > Key: HBASE-20950 > URL: https://issues.apache.org/jira/browse/HBASE-20950 > Project: HBase > Issue Type: Sub-task > Components: test >Affects Versions: 3.0.0 >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > Attachments: HBASE-20950.master.001.patch > > > There is quite some boilerplate code for configuring a secure HDFS cluster > for tests. The code is repeated in a number of test files within HBase code > base. Convert the boilerplate code into a helper method to avoid duplication > and lower maintenance effort. > SecureTestCluster#setHdfsSecuredConfiguration > TestSecureExport#setUpClusterKdc > TestThriftSpnegoHttpServer#addSecurityConfigurations > TestSaslFanOutOneBlockAsyncDFSOutput#setHdfsSecuredConfiguration -- This message was sent by Atlassian JIRA (v7.6.3#76005)