[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663227#comment-16663227 ] Hadoop QA commented on HBASE-21265: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 9 new or modified test files. {color} | || || || || {color:brown} branch-2.1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 7s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 33s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 39s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} branch-2.1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 34s{color} | {color:red} hbase-rsgroup generated 1 new + 103 unchanged - 4 fixed = 104 total (was 107) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} hbase-rsgroup: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 38s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 46s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 58s{color} | {color:red} hbase-rsgroup in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 37s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsBasics | | | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 | | JIRA Issue | HBASE-21265 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12945523/HBASE-21265.branch-2.1.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0f9d136fcc2b 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2.1 / 5309c3389d | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14854/artifact/patchprocess/diff-compile-javac-hbase-rsgroup.txt | |
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639716#comment-16639716 ] Hudson commented on HBASE-21265: Results for branch master [build #527 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/527/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- Something went wrong running this stage, please [check relevant console output|https://builds.apache.org/job/HBase%20Nightly/job/master/527//console]. (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/527//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/527//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639692#comment-16639692 ] Hudson commented on HBASE-21265: Results for branch branch-1.4 [build #494 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/494/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/494//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- Something went wrong running this stage, please [check relevant console output|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/494//console]. (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/494//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639650#comment-16639650 ] Hudson commented on HBASE-21265: Results for branch branch-1 [build #491 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/491/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/491//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/491//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/491//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639316#comment-16639316 ] Hudson commented on HBASE-21265: Results for branch branch-2 [build #1343 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1343/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- Something went wrong running this stage, please [check relevant console output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1343//console]. (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1343//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1343//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639233#comment-16639233 ] Andrew Purtell commented on HBASE-21265: File an issue for that. I’d prefer to remove it as last I checked it was broken. > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639225#comment-16639225 ] Ted Yu commented on HBASE-21265: {code} public class IntegrationTestRSGroup extends TestRSGroupsBase { {code} Now that the RS Group tests are broken out of TestRSGroupsBase, should IntegrationTestRSGroup incur similar changes ? Thanks > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639080#comment-16639080 ] Andrew Purtell commented on HBASE-21265: I looped TestRSGroupsKillRS on branch-2 10 times. It passed on each iteration. At any rate I only moved the code. If this test broken out into its own unit eventually tests out as flaky we can file an issue to look at it. > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639051#comment-16639051 ] Andrew Purtell commented on HBASE-21265: Test results on old branch-2 not valid > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639044#comment-16639044 ] Hadoop QA commented on HBASE-21265: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 9 new or modified test files. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 40s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 38s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 47s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 34s{color} | {color:red} hbase-rsgroup generated 1 new + 102 unchanged - 4 fixed = 103 total (was 106) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} hbase-rsgroup: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 39s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 47s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 22s{color} | {color:red} hbase-rsgroup in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 46m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsKillRS | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 | | JIRA Issue | HBASE-21265 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942472/HBASE-21265-branch-2.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8cb2c4fe15b2 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2 / 9e3f3fdc1f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14571/artifact/patchprocess/diff-compile-javac-hbase-rsgroup.txt | | checkstyle |
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639040#comment-16639040 ] Andrew Purtell commented on HBASE-21265: Normal concurrent "second part" testing looks better. Here's a typical master run, I did 5 of them: {noformat} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.352 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.873 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] [INFO] Results: [INFO] [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-surefire-plugin:2.21.0:test (secondPartTestsExecution) @ hbase-rsgroup --- [INFO] [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.703 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 63.344 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 54.882 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.859 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Running org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.505 s - in org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.043 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.499 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.085 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] [INFO] Results: [INFO] [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0 {noformat} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639031#comment-16639031 ] Andrew Purtell commented on HBASE-21265: Checkstyle and javac warning fixes > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265-branch-2.patch, HBASE-21265.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639011#comment-16639011 ] Andrew Purtell commented on HBASE-21265: Results from the branch-2 version {noformat} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.79 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.392 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.948 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.922 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 64.299 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.237 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.056 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.421 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.293 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] [INFO] Results: [INFO] [INFO] Tests run: 45, Failures: 0, Errors: 0, Skipped: 0 {noformat} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639014#comment-16639014 ] Andrew Purtell commented on HBASE-21265: I see the checkstyle nits, fixing > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265-branch-2.patch, HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639010#comment-16639010 ] Hadoop QA commented on HBASE-21265: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 9 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 21s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 36s{color} | {color:red} hbase-rsgroup generated 1 new + 102 unchanged - 4 fixed = 103 total (was 106) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} hbase-rsgroup: The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 21s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 11m 5s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 46s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 38s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21265 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942466/HBASE-21265.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3977898d62bf 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 4508f670b1 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/14570/artifact/patchprocess/diff-compile-javac-hbase-rsgroup.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14570/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt | | Test Results |
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638978#comment-16638978 ] Andrew Purtell commented on HBASE-21265: Attached the same refactor to master branch. Not a port of the branch-1 patch, too many differences, but I made the same changes and have the tests ordered in the respective files in the same order. {noformat} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.992 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.381 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.113 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.433 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.359 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.528 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 102.458 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.808 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.907 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] [INFO] Results: [INFO] [INFO] Tests run: 51, Failures: 0, Errors: 0, Skipped: 0 {noformat} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch, HBASE-21265-branch-1.patch, > HBASE-21265.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637768#comment-16637768 ] Andrew Purtell commented on HBASE-21265: Thanks for the reviews. I see the checkstyle report and will fix them upon commit. > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637746#comment-16637746 ] Vikas Vishwakarma commented on HBASE-21265: --- looks good +1 few minor checkstyle and whitespace warnings in the generated test report [~apurtell] > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637685#comment-16637685 ] Ted Yu commented on HBASE-21265: +1 > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.9 > > Attachments: HBASE-21265-branch-1.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637649#comment-16637649 ] Hadoop QA commented on HBASE-21265: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 9 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 51s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 39s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 13s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} hbase-rsgroup: The patch generated 10 new + 10 unchanged - 6 fixed = 20 total (was 16) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 37s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 36s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 47s{color} | {color:green} hbase-rsgroup in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 29s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 | | JIRA Issue | HBASE-21265 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942335/HBASE-21265-branch-1.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux
[jira] [Commented] (HBASE-21265) Split up TestRSGroups
[ https://issues.apache.org/jira/browse/HBASE-21265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637615#comment-16637615 ] Andrew Purtell commented on HBASE-21265: Here's a patch for branch-1. Patch for master and later branches would follow the same approach. When run in suite, results look approximately like this now: {noformat} [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.715 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsWithACL [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 103.974 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin1 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 68.73 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsAdmin2 [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.154 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.288 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics [INFO] Running org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.844 s - in org.apache.hadoop.hbase.rsgroup.TestEnableRSGroups [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.899 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsBalance [INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.817 s - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.622 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancerWithStochasticLoadBalancerAsInternal [INFO] Running org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.874 s - in org.apache.hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer [INFO] [INFO] Results: [INFO] [INFO] Tests run: 43, Failures: 0, Errors: 0, Skipped: 0 {noformat} > Split up TestRSGroups > - > > Key: HBASE-21265 > URL: https://issues.apache.org/jira/browse/HBASE-21265 > Project: HBase > Issue Type: Task > Components: rsgroup, test >Affects Versions: 1.4.8 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Minor > Labels: beginner, beginners > Fix For: 3.0.0, 1.5.0, 2.2.0 > > Attachments: HBASE-21265-branch-1.patch > > > TestRSGroups is flaky. It is stable when run in isolation but when run as > part of the suite with concurrent executors it can fail. The current running > time of this unit on my dev box is ~240 seconds (4 minutes), which is far too > much time. This unit should be broken up 5 to 8 ways, grouped by > functionality under test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)