[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797139#comment-16797139 ] Pankaj Kumar commented on HBASE-21455: -- +1, LGTM. [~wenbang], can you please add UT for this. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Attachments: HBASE-21455.master.001.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800605#comment-16800605 ] Pankaj Kumar commented on HBASE-21455: -- SnapshotQuotaObserverChore should also handle this scenario, {noformat} // Collect either the table name itself, or all of the tables in the namespace if (null != ns) { tablesToFetchSnapshotsFrom.addAll(Arrays.asList(admin.listTableNamesByNamespace(ns))); } else { tablesToFetchSnapshotsFrom.add(tn); } {noformat} > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Attachments: HBASE-21455.master.001.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801347#comment-16801347 ] wenbang commented on HBASE-21455: - [~pankaj2461] Would you please take a look at v2 ? Thanks. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801419#comment-16801419 ] Pankaj Kumar commented on HBASE-21455: -- A minor change, can you move list namespace table code to QuotaUtil and use it. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801519#comment-16801519 ] Hadoop QA commented on HBASE-21455: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m 8s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 8s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 33s{color} | {color:red} hbase-server generated 11 new + 183 unchanged - 11 fixed = 194 total (was 194) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 4s{color} | {color:red} hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 5s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}267m 44s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 25s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}311m 26s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.quotas.TestSpaceQuotas | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | hadoop.hbase.master.TestSplitWALManager | | | hadoop.hbase.client.TestAdmin1 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21455 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12963686/HBASE-21455.master.002.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 59d9574f73fb 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/compo
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802544#comment-16802544 ] Hadoop QA commented on HBASE-21455: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 21s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 45s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 45s{color} | {color:red} hbase-server generated 16 new + 178 unchanged - 16 fixed = 194 total (was 194) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 5s{color} | {color:red} hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 11s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 20s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}262m 20s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 25s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}303m 59s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.client.TestAsyncDecommissionAdminApi | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestAdmin1 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21455 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12963826/HBASE-21455.master.003.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d643c927e85c 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | mav
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802549#comment-16802549 ] Pankaj Kumar commented on HBASE-21455: -- +1 for the 003 patch. Please check the failures. Ping [~elserj]. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802619#comment-16802619 ] wenbang commented on HBASE-21455: - Fix checkstyle errors in the 004 patch. The javac & unit tests failure look unrelated. Thanks for the review [~pankaj2461]. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch, > HBASE-21455.master.004.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802725#comment-16802725 ] Hadoop QA commented on HBASE-21455: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 1s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 33s{color} | {color:red} hbase-server generated 14 new + 180 unchanged - 14 fixed = 194 total (was 194) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 1s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 7m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}131m 55s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}169m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21455 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12963854/HBASE-21455.master.004.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 198c8e74eda6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 7b3ff56202 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/16558/artifact/patchprocess/diff-compile-javac-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/16558/testReport/ | | Max. process+thread count | 4969 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802815#comment-16802815 ] Pankaj Kumar commented on HBASE-21455: -- You are welcome [~wenbang] :) > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch, > HBASE-21455.master.004.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803098#comment-16803098 ] Josh Elser commented on HBASE-21455: {code:java} +//Set a space quota on non-exist namespace + admin.setQuota(QuotaSettingsFactory.limitNamespaceSpace(testName.getMethodName(), +SpaceQuotaHelperForTests.ONE_GIGABYTE, SpaceViolationPolicy.NO_INSERTS)); {code} Open-ended question: are we sure we want to allow configuring quotas on entities that don't exist? A quick glacne doesn't indicate that we require the entity we're setting a quota on (ns, user, or table) to exist prior to configuring this quota. I wonder if this issue exists beyond just the namespace. You look into that at all [~wenbang]? {code:java} + public static TableName[] listTableNamesByNamespace(Connection conn, String namespace) + throws IOException { +TableName[] tablesInNS = null; +try { + tablesInNS = conn.getAdmin().listTableNamesByNamespace(namespace); +} catch (NamespaceNotFoundException e) { + LOG.warn("NameSpace " + namespace + " doesn't exist,skip it"); +} +return tablesInNS; + } {code} Could we change this method to return {{Optional}} instead of relying on this null-check? I think that would clean up the current patch and help prevent future bugs around this. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch, > HBASE-21455.master.004.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814290#comment-16814290 ] Pankaj Kumar commented on HBASE-21455: -- {quote}I wonder if this issue exists beyond just the namespace. {quote} Currently setting quota is allowed for non-existing entities (table, namespace or user). {quote}Open-ended question: are we sure we want to allow configuring quotas on entities that don't exist? {quote} There is a flexibility of retaining quota for the deleted table & namespace if hbase.quota.remove.on.table.delete set to false. However other system table like ACL doesn't allow acl setting for non-existing table/namespace and respective acl settings are cleared on table/namespace deletion. Therefore quota and ACL setting behaviour is not similar. Following approach can be adopted, # Treat quota as a special table. Current behavior is fine, let it be flexible ie. allow quota setting for non-existing entities also, as we have provision of retaining quota for deleted table/namespace. # Restrict quota setting for non-existing entities and mandate the cleanup on table/namespace deletion, no need to make MasterQuotasObserver configurable. # Allow quota setting for non-existing entities based on the configuration. [~elserj], please provide your opinion. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch, > HBASE-21455.master.004.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21455) Update filesystem-space quota fail if there is a space quota for non-existing namespace
[ https://issues.apache.org/jira/browse/HBASE-21455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797408#comment-17797408 ] Duo Zhang commented on HBASE-21455: --- Any updates here? [~pankaj2461] [~wenbang]. Thanks. > Update filesystem-space quota fail if there is a space quota for non-existing > namespace > --- > > Key: HBASE-21455 > URL: https://issues.apache.org/jira/browse/HBASE-21455 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.2 >Reporter: wenbang >Assignee: wenbang >Priority: Major > Labels: quota, space > Fix For: 3.0.0-beta-2 > > Attachments: HBASE-21455.master.001.patch, > HBASE-21455.master.002.patch, HBASE-21455.master.003.patch, > HBASE-21455.master.004.patch > > > QuotaObserverChore#fetchAllTablesWithQuotasDefined may fail and throw a > NamespaceNotFoundException because of namespace does not exist > {code:java} > // Collect all of the tables in the namespace > TableName[] tablesInNS = > conn.getAdmin().listTableNamesByNamespace(namespace); > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)