[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748816#comment-16748816
]
Hudson commented on HBASE-21749:
Results for branch branch-2.1
[build #794 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/794/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/794//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/794//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/794//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.3
>
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748779#comment-16748779
]
Hudson commented on HBASE-21749:
Results for branch branch-2
[build #1627 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1627/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1627//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1627//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1627//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.3
>
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748750#comment-16748750
]
Hudson commented on HBASE-21749:
Results for branch master
[build #737 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/737/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/737//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/737//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/737//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.3
>
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748586#comment-16748586
]
Hudson commented on HBASE-21749:
Results for branch branch-1
[build #646 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/646//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.3
>
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748133#comment-16748133
]
Andrew Purtell commented on HBASE-21749:
lgtm, let me commit after some local checks. Thanks [~nihaljain.cs]
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747838#comment-16747838
]
Hadoop QA commented on HBASE-21749:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}147m
41s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}190m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21749 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12955602/HBASE-21749.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ef0169ac04b0 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / a2f6768acd |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15656/testReport/ |
| Max. process+thread count | 4598 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747718#comment-16747718
]
Jingyun Tian commented on HBASE-21749:
--
Thanks [~nihaljain.cs] for reporting. Why getCurrentPath() could return null?
There should be at least one log wait to replicate?
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
[
https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747710#comment-16747710
]
Nihal Jain commented on HBASE-21749:
Ping [~tianjingyun], [~apurtell], [~zghaobac].
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and
> replication
> --
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
>Affects Versions: 3.0.0, 2.1.0
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because
> {{shipper.getCurrentPath()}} may return null.
> We should have a null check @
> [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
>
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects
> the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
