[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753404#comment-16753404
]
Hudson commented on HBASE-21789:
Results for branch branch-2
[build #1640 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
> ---
>
> Key: HBASE-21789
> URL: https://issues.apache.org/jira/browse/HBASE-21789
> Project: HBase
> Issue Type: Improvement
> Components: Client, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21789-v1.patch, HBASE-21789.patch
>
>
> Now it implements a special RegionServerCallable, which is not necessary. It
> is just a coprocessor call to MultiRowMutationEndpoint, we should use the
> coprocessor related method to do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753384#comment-16753384
]
Hudson commented on HBASE-21789:
Results for branch master
[build #750 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/750/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
> ---
>
> Key: HBASE-21789
> URL: https://issues.apache.org/jira/browse/HBASE-21789
> Project: HBase
> Issue Type: Improvement
> Components: Client, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21789-v1.patch, HBASE-21789.patch
>
>
> Now it implements a special RegionServerCallable, which is not necessary. It
> is just a coprocessor call to MultiRowMutationEndpoint, we should use the
> coprocessor related method to do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[ https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753244#comment-16753244 ] stack commented on HBASE-21789: --- Ok. +1 again on patch. > Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService > --- > > Key: HBASE-21789 > URL: https://issues.apache.org/jira/browse/HBASE-21789 > Project: HBase > Issue Type: Improvement > Components: Client, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21789-v1.patch, HBASE-21789.patch > > > Now it implements a special RegionServerCallable, which is not necessary. It > is just a coprocessor call to MultiRowMutationEndpoint, we should use the > coprocessor related method to do this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753229#comment-16753229
]
Duo Zhang commented on HBASE-21789:
---
{quote}
Is there retry under coprocessorService?
{quote}
We have retries for coprocessor call, you can see the
RegionCoprocessorRpcChannel. And there maybe a little problem, that the timeout
config is inherited from Connection, not Table, but this is the problem of our
coprocessor implemention.
{quote}
Should we file another issue to make multi row native rather than CP based?
{quote}
We could but the API needs to be carefully designed. It should only be used by
experts. We have introduced a simple method to do this in our thin hbase
client, and users always put a bunch rows across multiple regions and then ask
why only some of the puts are succeeded...
> Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
> ---
>
> Key: HBASE-21789
> URL: https://issues.apache.org/jira/browse/HBASE-21789
> Project: HBase
> Issue Type: Improvement
> Components: Client, Coprocessors
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21789-v1.patch, HBASE-21789.patch
>
>
> Now it implements a special RegionServerCallable, which is not necessary. It
> is just a coprocessor call to MultiRowMutationEndpoint, we should use the
> coprocessor related method to do this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[ https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753183#comment-16753183 ] stack commented on HBASE-21789: --- Looks good. A simplification. What is the answer to these comments that was removed now we have this new guise doing multi row? 1739// TODO: Need Retry!!! 1740// TODO: What for a timeout? Default write timeout? GET FROM HTABLE? Is there retry under coprocessorService? Should we file another issue to make multi row native rather than CP based? Thanks. +1 on patch otherwise. > Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService > --- > > Key: HBASE-21789 > URL: https://issues.apache.org/jira/browse/HBASE-21789 > Project: HBase > Issue Type: Improvement > Components: Client, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21789-v1.patch, HBASE-21789.patch > > > Now it implements a special RegionServerCallable, which is not necessary. It > is just a coprocessor call to MultiRowMutationEndpoint, we should use the > coprocessor related method to do this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753169#comment-16753169
]
Hadoop QA commented on HBASE-21789:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
14s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 58s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
40s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}226m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
43s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}286m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21789 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956455/HBASE-21789-v1.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux bdf95153152f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4f3b95b318 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[
https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753043#comment-16753043
]
Hadoop QA commented on HBASE-21789:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 11s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
28s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21789 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956448/HBASE-21789.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6c4cecfde29c 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 4f3b95b318 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15744/testReport/ |
| Max. process+thread count | 262 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
[jira] [Commented] (HBASE-21789) Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService
[ https://issues.apache.org/jira/browse/HBASE-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753029#comment-16753029 ] Zheng Hu commented on HBASE-21789: -- +1 if hadoop QA OK. > Rewrite MetaTableAccessor.multiMutate with Table.coprocessorService > --- > > Key: HBASE-21789 > URL: https://issues.apache.org/jira/browse/HBASE-21789 > Project: HBase > Issue Type: Improvement > Components: Client, Coprocessors >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21789.patch > > > Now it implements a special RegionServerCallable, which is not necessary. It > is just a coprocessor call to MultiRowMutationEndpoint, we should use the > coprocessor related method to do this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
