[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[ https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823671#comment-16823671 ] Nikhil Bafna commented on HBASE-22256: -- [~xucang] Resubmitted the patch to invoke the QA. > Enabling FavoredStochasticBalancer on existing cluster leaves regions > unassigned > > > Key: HBASE-22256 > URL: https://issues.apache.org/jira/browse/HBASE-22256 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 2.1.3 >Reporter: Nikhil Bafna >Priority: Major > Attachments: HBASE-22256.master.001.patch, > HBASE-22256.master.001.patch, HBASE-22256.master.001.patch > > > This is related to HBASE-18349. > The test that fails corresponding to this is > TestFavoredStochasticLoadBalancer#testMisplacedRegions. When a region is > misplaced w.r.t to the favored nodes, this balancer unassigns the region and > the new RegionPlan has the source server as null leading to NPE later. This > leaves the affected regions to be unassigned after the balancer run. > This is problematic especially when moving from a different balancer to the > FavoredStochasticLoadBalancer because all regions would be "misplaced" in the > favored balancer's run. > The fix is along the lines of HBASE-18602. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[
https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823076#comment-16823076
]
HBase QA commented on HBASE-22256:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}130m
50s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}171m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/137/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22256 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966614/HBASE-22256.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 589f361fbc02 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 38ff46f88f |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/137/testReport/ |
| Max. process+thread count | 5246 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/137/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Enabling
[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[ https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820870#comment-16820870 ] Nikhil Bafna commented on HBASE-22256: -- TestReplicationKillSlaveRS failed in the test on build server, but it passes locally though. > Enabling FavoredStochasticBalancer on existing cluster leaves regions > unassigned > > > Key: HBASE-22256 > URL: https://issues.apache.org/jira/browse/HBASE-22256 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 2.1.3 >Reporter: Nikhil Bafna >Priority: Major > Attachments: HBASE-22256.master.001.patch, > HBASE-22256.master.001.patch > > > This is related to HBASE-18349. > The test that fails corresponding to this is > TestFavoredStochasticLoadBalancer#testMisplacedRegions. When a region is > misplaced w.r.t to the favored nodes, this balancer unassigns the region and > the new RegionPlan has the source server as null leading to NPE later. This > leaves the affected regions to be unassigned after the balancer run. > This is problematic especially when moving from a different balancer to the > FavoredStochasticLoadBalancer because all regions would be "misplaced" in the > favored balancer's run. > The fix is along the lines of HBASE-18602. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[
https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820851#comment-16820851
]
HBase QA commented on HBASE-22256:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
41s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}169m 47s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}216m 19s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/112/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22256 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966317/HBASE-22256.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux cbe18638fec2 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 428afa9c5e |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/112/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/112/testReport/ |
| Max. process+thread count | 4839 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/112/console |
| Powered by | Apache
[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[
https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820728#comment-16820728
]
Nikhil Bafna commented on HBASE-22256:
--
Skip un-assign is required for this to work & makes the test case pass while
not breaking other UTs.
If i un-assign, the MoveRegionProcedure procedure fails because it expects the
region to be in OPEN state and the UT fails.
{code:java}
2019-04-18 10:15:16,068 WARN
[RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=64869]
master.HMaster(1682): Failed balance plan:
hri=2df26fa6b12b15fb35e3ff89ea84dac7, source=192.168.1.4,64881,162532668,
destination=, just skip it
org.apache.hadoop.hbase.client.DoNotRetryRegionException:
2df26fa6b12b15fb35e3ff89ea84dac7 is not OPEN;
regionState={2df26fa6b12b15fb35e3ff89ea84dac7 state=CLOSED, ts=162631969,
server=null}
at
org.apache.hadoop.hbase.master.procedure.AbstractStateMachineTableProcedure.checkOnline(AbstractStateMachineTableProcedure.java:194)
at
org.apache.hadoop.hbase.master.assignment.MoveRegionProcedure.(MoveRegionProcedure.java:78)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.createMoveRegionProcedure(AssignmentManager.java:741)
at
org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:555)
at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1678)
{code}
> Enabling FavoredStochasticBalancer on existing cluster leaves regions
> unassigned
>
>
> Key: HBASE-22256
> URL: https://issues.apache.org/jira/browse/HBASE-22256
> Project: HBase
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.1.3
>Reporter: Nikhil Bafna
>Priority: Major
> Attachments: HBASE-22256.master.001.patch
>
>
> This is related to HBASE-18349.
> The test that fails corresponding to this is
> TestFavoredStochasticLoadBalancer#testMisplacedRegions. When a region is
> misplaced w.r.t to the favored nodes, this balancer unassigns the region and
> the new RegionPlan has the source server as null leading to NPE later. This
> leaves the affected regions to be unassigned after the balancer run.
> This is problematic especially when moving from a different balancer to the
> FavoredStochasticLoadBalancer because all regions would be "misplaced" in the
> favored balancer's run.
> The fix is along the lines of HBASE-18602.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22256) Enabling FavoredStochasticBalancer on existing cluster leaves regions unassigned
[ https://issues.apache.org/jira/browse/HBASE-22256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820407#comment-16820407 ] Xu Cang commented on HBASE-22256: - Based on your patch, you skip un-assigning the region from not favored node. This would break the balancing logic in my opinion. Please correct me if I misunderstood something. Also, you could "submit patch" button to submit your patch in order to trigger automatic QA. Thanks [~zodvik] > Enabling FavoredStochasticBalancer on existing cluster leaves regions > unassigned > > > Key: HBASE-22256 > URL: https://issues.apache.org/jira/browse/HBASE-22256 > Project: HBase > Issue Type: Bug > Components: Balancer >Affects Versions: 2.1.3 >Reporter: Nikhil Bafna >Priority: Major > Attachments: HBASE-22256.master.001.patch > > > This is related to HBASE-18349. > The test that fails corresponding to this is > TestFavoredStochasticLoadBalancer#testMisplacedRegions. When a region is > misplaced w.r.t to the favored nodes, this balancer unassigns the region and > the new RegionPlan has the source server as null leading to NPE later. This > leaves the affected regions to be unassigned after the balancer run. > This is problematic especially when moving from a different balancer to the > FavoredStochasticLoadBalancer because all regions would be "misplaced" in the > favored balancer's run. > The fix is along the lines of HBASE-18602. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
