[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[ https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463389#comment-17463389 ] Richard Marscher commented on HBASE-22280: -- I also noticed that this means the meta call queue type now becomes the same as your normal rpc call queue type. This is since instead of passing in a FIFO queue like the fast path executor path does, the `MetaRWQueueRpcExecutor` is a child of `RpcExecutor`, which runs through the logic to load the call queue type based on the `base.ipc.server.callqueue.type` config. > Separate read/write handler for priority request(especially for meta). > -- > > Key: HBASE-22280 > URL: https://issues.apache.org/jira/browse/HBASE-22280 > Project: HBase > Issue Type: New Feature > Components: Scheduler >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.3 > > Attachments: HBASE-22280.patch > > > Client may give too many read pressure on meta, so blocking master write meta > for region open. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[ https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313454#comment-17313454 ] Huaxiang Sun commented on HBASE-22280: -- Hi [~binlijin], do you run into production issue without this change? Can you share more info? We are seeing a meta throughput regression from hbase-1 to hbase-2, due to rpc scheduler change. Changing back to FastPathBalancedQueueRpcExecutor for priority rpc queue removes the regression. > Separate read/write handler for priority request(especially for meta). > -- > > Key: HBASE-22280 > URL: https://issues.apache.org/jira/browse/HBASE-22280 > Project: HBase > Issue Type: New Feature > Components: Scheduler >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.3 > > Attachments: HBASE-22280.patch > > > Client may give too many read pressure on meta, so blocking master write meta > for region open. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[
https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992146#comment-16992146
]
Hudson commented on HBASE-22280:
Results for branch branch-2.2
[build #719 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/719/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/719//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/719//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/719//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Separate read/write handler for priority request(especially for meta).
> --
>
> Key: HBASE-22280
> URL: https://issues.apache.org/jira/browse/HBASE-22280
> Project: HBase
> Issue Type: New Feature
> Components: Scheduler
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22280.patch
>
>
> Client may give too many read pressure on meta, so blocking master write meta
> for region open.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[
https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992121#comment-16992121
]
Hudson commented on HBASE-22280:
Results for branch branch-2
[build #2380 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2380/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2380//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2380//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2380//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Separate read/write handler for priority request(especially for meta).
> --
>
> Key: HBASE-22280
> URL: https://issues.apache.org/jira/browse/HBASE-22280
> Project: HBase
> Issue Type: New Feature
> Components: Scheduler
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22280.patch
>
>
> Client may give too many read pressure on meta, so blocking master write meta
> for region open.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[
https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991640#comment-16991640
]
Hudson commented on HBASE-22280:
Results for branch master
[build #1562 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1562/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1562//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1562//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1562//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Separate read/write handler for priority request(especially for meta).
> --
>
> Key: HBASE-22280
> URL: https://issues.apache.org/jira/browse/HBASE-22280
> Project: HBase
> Issue Type: New Feature
> Components: Scheduler
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3
>
> Attachments: HBASE-22280.patch
>
>
> Client may give too many read pressure on meta, so blocking master write meta
> for region open.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[ https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991233#comment-16991233 ] Lijin Bin commented on HBASE-22280: --- Push to master/branch-2/branch-2.2 [~liyu] Thanks for the review. > Separate read/write handler for priority request(especially for meta). > -- > > Key: HBASE-22280 > URL: https://issues.apache.org/jira/browse/HBASE-22280 > Project: HBase > Issue Type: New Feature > Components: Scheduler >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.3 > > Attachments: HBASE-22280.patch > > > Client may give too many read pressure on meta, so blocking master write meta > for region open. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[
https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963913#comment-16963913
]
HBase QA commented on HBASE-22280:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-22280 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22280 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12967208/HBASE-22280.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/982/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
This message was automatically generated.
> Separate read/write handler for priority request(especially for meta).
> --
>
> Key: HBASE-22280
> URL: https://issues.apache.org/jira/browse/HBASE-22280
> Project: HBase
> Issue Type: New Feature
> Components: Scheduler
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Attachments: HBASE-22280.patch
>
>
> Client may give too many read pressure on meta, so blocking master write meta
> for region open.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[ https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829914#comment-16829914 ] binlijin commented on HBASE-22280: -- [~carp84], thanks very much, Make a PR in github. > Separate read/write handler for priority request(especially for meta). > -- > > Key: HBASE-22280 > URL: https://issues.apache.org/jira/browse/HBASE-22280 > Project: HBase > Issue Type: New Feature >Reporter: binlijin >Assignee: binlijin >Priority: Major > Attachments: HBASE-22280.patch > > > Client may give too many read pressure on meta, so blocking master write meta > for region open. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[ https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827820#comment-16827820 ] Yu Li commented on HBASE-22280: --- Long time no see bro and wish everything goes on well there [~aoxiang] (smile) Mind put the patch onto RB or submit a PR through github for easier review? Thanks. > Separate read/write handler for priority request(especially for meta). > -- > > Key: HBASE-22280 > URL: https://issues.apache.org/jira/browse/HBASE-22280 > Project: HBase > Issue Type: New Feature >Reporter: binlijin >Assignee: binlijin >Priority: Major > Attachments: HBASE-22280.patch > > > Client may give too many read pressure on meta, so blocking master write meta > for region open. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22280) Separate read/write handler for priority request(especially for meta).
[
https://issues.apache.org/jira/browse/HBASE-22280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827431#comment-16827431
]
HBase QA commented on HBASE-22280:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
43s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
14s{color} | {color:red} hbase-server: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
35s{color} | {color:red} patch has 11 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
3s{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
8s{color} | {color:red} The patch causes 11 errors with Hadoop v3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/206/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22280 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12967208/HBASE-22280.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f5768449a939 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul
13 08:53:17 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 962585d376 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/206/artifact/patchprocess
