[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827471#comment-16827471
]
Hudson commented on HBASE-22310:
Results for branch branch-1.3
[build #743 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/743/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/743//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/743//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/743//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> checkAndMutate used an incorrect row to check the condition
> ---
>
> Key: HBASE-22310
> URL: https://issues.apache.org/jira/browse/HBASE-22310
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 1.3.3, 1.4.9
>Reporter: Adonis Ling
>Assignee: Adonis Ling
>Priority: Major
> Fix For: 1.5.0, 1.4.10, 1.3.4
>
> Attachments: HBASE-22310-branch-1.patch,
> HBASE-22310.branch-1.3.001.patch, HBASE-22310.branch-1.3.002.patch,
> HBASE-22310.branch-1.4.001.patch, HBASE-22310.branch-1.4.002.patch,
> HBASE-22310.branch-1.4.003.patch
>
>
> In branch-1.4, checkAndMutate used the row of RowMutation to check the
> condition which is incorrect. It will fail in the case which is checking a
> row and mutate a different row.
> The issue doesn't happen in the master branch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827457#comment-16827457
]
Hudson commented on HBASE-22310:
Results for branch branch-1.4
[build #768 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/768/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/768//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/768//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/768//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> checkAndMutate used an incorrect row to check the condition
> ---
>
> Key: HBASE-22310
> URL: https://issues.apache.org/jira/browse/HBASE-22310
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 1.3.3, 1.4.9
>Reporter: Adonis Ling
>Assignee: Adonis Ling
>Priority: Major
> Fix For: 1.5.0, 1.4.10, 1.3.4
>
> Attachments: HBASE-22310-branch-1.patch,
> HBASE-22310.branch-1.3.001.patch, HBASE-22310.branch-1.3.002.patch,
> HBASE-22310.branch-1.4.001.patch, HBASE-22310.branch-1.4.002.patch,
> HBASE-22310.branch-1.4.003.patch
>
>
> In branch-1.4, checkAndMutate used the row of RowMutation to check the
> condition which is incorrect. It will fail in the case which is checking a
> row and mutate a different row.
> The issue doesn't happen in the master branch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827452#comment-16827452
]
Hudson commented on HBASE-22310:
Results for branch branch-1
[build #794 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/794/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/794//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/794//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/794//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> checkAndMutate used an incorrect row to check the condition
> ---
>
> Key: HBASE-22310
> URL: https://issues.apache.org/jira/browse/HBASE-22310
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 1.3.3, 1.4.9
>Reporter: Adonis Ling
>Assignee: Adonis Ling
>Priority: Major
> Fix For: 1.5.0, 1.4.10, 1.3.4
>
> Attachments: HBASE-22310-branch-1.patch,
> HBASE-22310.branch-1.3.001.patch, HBASE-22310.branch-1.3.002.patch,
> HBASE-22310.branch-1.4.001.patch, HBASE-22310.branch-1.4.002.patch,
> HBASE-22310.branch-1.4.003.patch
>
>
> In branch-1.4, checkAndMutate used the row of RowMutation to check the
> condition which is incorrect. It will fail in the case which is checking a
> row and mutate a different row.
> The issue doesn't happen in the master branch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827355#comment-16827355 ] Hudson commented on HBASE-22310: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #547 (See [https://builds.apache.org/job/HBase-1.3-IT/547/]) HBASE-22310 checkAndMutate used an incorrect row to check the condition (apurtell: [https://github.com/apache/hbase/commit/afc85c0e55d1bd9515214f7b2dd1a7838affb64f]) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestCheckAndMutate.java > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.3.3, 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Fix For: 1.5.0, 1.4.10, 1.3.4 > > Attachments: HBASE-22310-branch-1.patch, > HBASE-22310.branch-1.3.001.patch, HBASE-22310.branch-1.3.002.patch, > HBASE-22310.branch-1.4.001.patch, HBASE-22310.branch-1.4.002.patch, > HBASE-22310.branch-1.4.003.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827176#comment-16827176 ] Andrew Purtell commented on HBASE-22310: So, the hadoopcheck issues should go away after a test personality update (if we opt for that). For now I'll ignore them. I think the unit test failures are also unrelated but let me check locally. Otherwise will commit this. > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.3.3, 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Fix For: 1.5.0, 1.4.10, 1.3.4 > > Attachments: HBASE-22310.branch-1.3.001.patch, > HBASE-22310.branch-1.3.002.patch, HBASE-22310.branch-1.4.001.patch, > HBASE-22310.branch-1.4.002.patch, HBASE-22310.branch-1.4.003.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827172#comment-16827172
]
Andrew Purtell commented on HBASE-22310:
{quote}do we support Hadoop 2.4-2.6 on 1.4 release line? The personality file
defines it but Reference guide claims to be only Hadoop-2.7.1+.
{quote}
That is really a question of community consensus.
If we believe the reference guide is the most up to date representation of
consensus on support, then only Hadoop 2.7 and up are supported.
If we look at git history, the 1.4.0 release had 2.7.4 defined as
{{hadoop-two.version}} . I think this could also be construed as intent.
> checkAndMutate used an incorrect row to check the condition
> ---
>
> Key: HBASE-22310
> URL: https://issues.apache.org/jira/browse/HBASE-22310
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 1.3.3, 1.4.9
>Reporter: Adonis Ling
>Assignee: Adonis Ling
>Priority: Major
> Attachments: HBASE-22310.branch-1.3.001.patch,
> HBASE-22310.branch-1.3.002.patch, HBASE-22310.branch-1.4.001.patch,
> HBASE-22310.branch-1.4.002.patch, HBASE-22310.branch-1.4.003.patch
>
>
> In branch-1.4, checkAndMutate used the row of RowMutation to check the
> condition which is incorrect. It will fail in the case which is checking a
> row and mutate a different row.
> The issue doesn't happen in the master branch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827166#comment-16827166 ] Andrew Purtell commented on HBASE-22310: [~xucang] > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.3.3, 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.branch-1.3.001.patch, > HBASE-22310.branch-1.3.002.patch, HBASE-22310.branch-1.4.001.patch, > HBASE-22310.branch-1.4.002.patch, HBASE-22310.branch-1.4.003.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826973#comment-16826973
]
HBase QA commented on HBASE-22310:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
50s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
51s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
51s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
0s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
23s{color} | {color:green} hbase-server: The patch generated 0 new + 3
unchanged - 2 fixed = 3 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
55s{color} | {color:red} The patch causes 26 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
53s{color} | {color:red} The patch causes 26 errors with Hadoop v2.5.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
0s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
20s{color} | {color:green} hbase-client in the patch passed.
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826922#comment-16826922
]
HBase QA commented on HBASE-22310:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m
47s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
52s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} hbase-server: The patch generated 0 new + 3
unchanged - 2 fixed = 3 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
57s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 90m
10s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826882#comment-16826882 ] Adonis Ling commented on HBASE-22310: - [~psomogyi], certainly. > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.3.3, 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.branch-1.3.001.patch, > HBASE-22310.branch-1.3.002.patch, HBASE-22310.branch-1.4.001.patch, > HBASE-22310.branch-1.4.002.patch, HBASE-22310.branch-1.4.003.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826839#comment-16826839 ] Peter Somogyi commented on HBASE-22310: --- [~adonis_ling], can you change the parameter order in assertArrayEquals to be assertArrayEquals(message, expectedValue, actualValue)? > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.3.3, 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.branch-1.3.001.patch, > HBASE-22310.branch-1.4.001.patch, HBASE-22310.branch-1.4.002.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826789#comment-16826789 ] Peter Somogyi commented on HBASE-22310: --- [~apurtell], do we support Hadoop 2.4-2.6 on 1.4 release line? The personality file defines it but Reference guide claims to be only Hadoop-2.7.1+. > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.branch-1.4.001.patch, > HBASE-22310.branch-1.4.002.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826736#comment-16826736
]
HBase QA commented on HBASE-22310:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
36s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
41s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} hbase-server: The patch generated 0 new + 3
unchanged - 2 fixed = 3 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
28s{color} | {color:red} The patch causes 26 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
55s{color} | {color:red} The patch causes 26 errors with Hadoop v2.5.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
37s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
28s{color} | {color:green} hbase-client in the patch passed.
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826726#comment-16826726
]
HBase QA commented on HBASE-22310:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
37s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
34s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} hbase-server: The patch generated 0 new + 3
unchanged - 2 fixed = 3 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
41s{color} | {color:red} The patch causes 26 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
19s{color} | {color:red} The patch causes 26 errors with Hadoop v2.5.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
15s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
29s{color} | {color:green} hbase-client in the patch passed.
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826195#comment-16826195
]
HBase QA commented on HBASE-22310:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
45s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
39s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
13s{color} | {color:red} hbase-server: The patch generated 2 new + 3 unchanged
- 2 fixed = 5 total (was 5) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
25s{color} | {color:red} The patch causes 26 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
51s{color} | {color:red} The patch causes 26 errors with Hadoop v2.5.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
33s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
18s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}121m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
|
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826057#comment-16826057 ] Adonis Ling commented on HBASE-22310: - Hi, [~psomogyi]. Thanks for your reply. Yes, the patch is targeted for branch-1.4 and I renamed the patch just now. > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.branch-1.4.001.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[ https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826051#comment-16826051 ] Peter Somogyi commented on HBASE-22310: --- [~adonis_ling], is this patch targeted for branch-1.4? In that case it needs to be named HBASE-22310.branch-1.4.001.patch > checkAndMutate used an incorrect row to check the condition > --- > > Key: HBASE-22310 > URL: https://issues.apache.org/jira/browse/HBASE-22310 > Project: HBase > Issue Type: Bug > Components: API >Affects Versions: 1.4.9 >Reporter: Adonis Ling >Assignee: Adonis Ling >Priority: Major > Attachments: HBASE-22310.patch > > > In branch-1.4, checkAndMutate used the row of RowMutation to check the > condition which is incorrect. It will fail in the case which is checking a > row and mutate a different row. > The issue doesn't happen in the master branch. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22310) checkAndMutate used an incorrect row to check the condition
[
https://issues.apache.org/jira/browse/HBASE-22310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826042#comment-16826042
]
HBase QA commented on HBASE-22310:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-22310 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-22310 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12966996/HBASE-22310.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/183/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> checkAndMutate used an incorrect row to check the condition
> ---
>
> Key: HBASE-22310
> URL: https://issues.apache.org/jira/browse/HBASE-22310
> Project: HBase
> Issue Type: Bug
> Components: API
>Affects Versions: 1.4.9
>Reporter: Adonis Ling
>Assignee: Adonis Ling
>Priority: Major
> Attachments: HBASE-22310.patch
>
>
> In branch-1.4, checkAndMutate used the row of RowMutation to check the
> condition which is incorrect. It will fail in the case which is checking a
> row and mutate a different row.
> The issue doesn't happen in the master branch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
