[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975561#comment-16975561
]
Hudson commented on HBASE-23283:
Results for branch branch-2.1
[build #1711 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1711//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975551#comment-16975551
]
Hudson commented on HBASE-23283:
Results for branch branch-2
[build #2355 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2355//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975528#comment-16975528
]
Hudson commented on HBASE-23283:
Results for branch branch-2.2
[build #694 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/694//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975140#comment-16975140
]
Hudson commented on HBASE-23283:
Results for branch master
[build #1537 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1537/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1537//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975013#comment-16975013
]
Hudson commented on HBASE-23283:
Results for branch branch-1
[build #1138 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1138//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.1.8, 2.2.3
>
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974717#comment-16974717
]
Sean Busbey commented on HBASE-23283:
-
No worries, I'll push it. Patience please.
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973649#comment-16973649
]
Mingliang Liu commented on HBASE-23283:
---
[[~busbey]I don't have commit access so could you kindly do the favor...Thanks!
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973313#comment-16973313
]
Sean Busbey commented on HBASE-23283:
-
Looks great!
+1
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Assignee: Mingliang Liu
>Priority: Minor
> Attachments: HBASE-23283.000.patch
>
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973139#comment-16973139
]
HBase QA commented on HBASE-23283:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
49s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/1015/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-23283 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12985695/HBASE-23283.000.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5cd44ee177a0 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9494c12e35 |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/1015/te
[jira] [Commented] (HBASE-23283) Provide clear and consistent logging about the period of enabled chores
[
https://issues.apache.org/jira/browse/HBASE-23283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973086#comment-16973086
]
Mingliang Liu commented on HBASE-23283:
---
Thanks, this makes sense. Unless you are working on it, I assign it to me and
will provide a patch [~busbey]
> Provide clear and consistent logging about the period of enabled chores
> ---
>
> Key: HBASE-23283
> URL: https://issues.apache.org/jira/browse/HBASE-23283
> Project: HBase
> Issue Type: Improvement
> Components: Operability
>Affects Versions: 3.0.0, 2.3.0, 1.7.0
>Reporter: Sean Busbey
>Priority: Minor
>
> Similar to HBASE-23038, we should always log info about our enabled chores.
> Right now wether or not we get some information is up to particular Chore
> constructors and by and large we don't get any log messages when things can
> get started, even if the period is something impossibly long (e.g. 3000 days).
> When we go to schedule the chore here:
> {code}
> if (chore.getPeriod() <= 0) {
> LOG.info("The period is {} seconds, {} is disabled",
> chore.getPeriod(), chore.getName());
> return false;
> }
> {code}
> we should add an else clause that says it's enabled. It looks like we could
> then just call chore.toString to get the proper details about the chore and
> its period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
