[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[ https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099411#comment-17099411 ] Mingliang Liu commented on HBASE-23707: --- Cool, thanks [~ndimiduk] I'll try that and review the IntelliJ article shortly. > Add IntelliJ check style plugin configuration > - > > Key: HBASE-23707 > URL: https://issues.apache.org/jira/browse/HBASE-23707 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 1.6.0 > > > IntelliJ defines project configuration across a number of files, specifically > so that some configurations can be committed with the source repository. The > checkstyle plugin configuration is one such config file; add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[ https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099399#comment-17099399 ] Nick Dimiduk commented on HBASE-23707: -- [~liuml07] I posted up a PR based on the above materials. Mind taking a look? https://github.com/apache/hbase/pull/1647 > Add IntelliJ check style plugin configuration > - > > Key: HBASE-23707 > URL: https://issues.apache.org/jira/browse/HBASE-23707 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 1.6.0 > > > IntelliJ defines project configuration across a number of files, specifically > so that some configurations can be committed with the source repository. The > checkstyle plugin configuration is one such config file; add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[ https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099390#comment-17099390 ] Nick Dimiduk commented on HBASE-23707: -- Looks like this is the "official" knowledge base article on tracking changes to IntelliJ project files. https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 It also seems the project files can automatically be added by the IDE, https://www.jetbrains.com/help/idea/creating-and-managing-projects.html?_ga=2.28939388.1359844174.1588630841-364026928.1588630841#share-project-through-vcs > Add IntelliJ check style plugin configuration > - > > Key: HBASE-23707 > URL: https://issues.apache.org/jira/browse/HBASE-23707 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 1.6.0 > > > IntelliJ defines project configuration across a number of files, specifically > so that some configurations can be committed with the source repository. The > checkstyle plugin configuration is one such config file; add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097167#comment-17097167
]
Mingliang Liu commented on HBASE-23707:
---
[~ndimiduk]
{quote}
What happens when you select the root pom.xml instead of just the folder? Does
it detect the maven model type?
{quote}
I tried this as well, no it does not work. I also run 'mvn clean package
-DskipTests' first before open/import, and still does not help. So it seems
this ".idea" directory just makes import (directory or {{pom.xml}}) stop
working correctly. I would believe this is IntelliJ version dependent, since
it's IntelliJ who makes the decision how to initializes a new project from
source with existent ".idea" director.
{quote}
Maybe we need to commit another file from .idea directory, one that specifies
the project type?
{quote}
This seems a good idea, but I do not know what this could be. Also, this could
still be IntelliJ version dependent? On my current IntelliJ, I have following
files in ".idea"
{code}
$ ls -l .idea
-rw-r--r--1 mingliang.liu wheel 159B Apr 25 16:15 $CACHE_FILE$
-rw-r--r--1 mingliang.liu wheel 917B Apr 26 21:44 checkstyle-idea.xml
-rw-r--r--1 mingliang.liu wheel 6.6K Apr 25 16:16 compiler.xml
-rw-r--r--1 mingliang.liu wheel 3.4K Apr 25 16:16 encodings.xml
-rw-r--r--1 mingliang.liu wheel 874B Apr 25 16:16 jarRepositories.xml
drwxr-xr-x 234 mingliang.liu wheel 7.3K Apr 25 16:16 libraries/
-rw-r--r--1 mingliang.liu wheel 384B Apr 25 16:15 misc.xml
-rw-r--r--1 mingliang.liu wheel 6.8K Apr 25 16:16 modules.xml
-rw-r--r--1 mingliang.liu wheel 180B Apr 25 16:15 vcs.xml
-rw-r--r--1 mingliang.liu wheel14K Apr 27 02:27 workspace.xml
{code}
The last resort is to keep this file, but we put this plugin setting file into
the "dev-support/ " directory. And we can kindly ask developer to replace the
".idea/checkstyle-idea.xml" with "dev-support/idea/checkstyle-idea.xml" file
manually after importing project. This can be written in the book.
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093640#comment-17093640
]
Nick Dimiduk commented on HBASE-23707:
--
Maybe we need to commit another file from {{.idea}} directory, one that
specifies the project type?
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093637#comment-17093637
]
Nick Dimiduk commented on HBASE-23707:
--
Sounds like this [section|https://hbase.apache.org/book.html#_intellij_idea] in
the book needs updated. What happens when you select the root {{pom.xml}}
instead of just the folder? Does it detect the maven model type?
This used to work, in the 2019 editions.
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092053#comment-17092053
]
Mingliang Liu commented on HBASE-23707:
---
[~ndimiduk] Lovely as it is, I found this settings file being under ".idea/"
directory would make the (new) project import stop working. The problem I have
can be reproduced as following:
1. git clone g...@github.com:apache/hbase.git ./myhbase
2. IntelliJ IDEA -> File -> New project from existing sources (or Open)
3. The project is just opened, but the Maven modules, source/test code
structure and indexing, and other project auto-import stuff just do not happen.
In this situation, it fails to know a file is Java source. The reason I *guess*
is because we have existing ".idea/" directory in source code tree, where only
one checkstyle plugin file is provided. IntelliJ is not smart enough to know
this project has been imported. So I removed this checkstyle settings file (and
".idea/" directory), the import start working. I can run unit tests there.
Can you reproduce this? If this is not what I did something wrong, I propose we
put this plugin setting file into the "dev-support/ " directory. And we can
kindly let developer know (in doc somewhere) they can replace the
".idea/checkstyle-idea.xml" with "dev-support/idea/checkstyle-idea.xml" file
manually after importing project (or we have a helper script in future?). This
manual step seems fine since developer will need to manually install CheckStyle
plugin anyway. If this looks good, I can file a simple patch to rename this
file. I saw some projects commit their whole IntelliJ settings into source
code, but I'm not sure that is better give so any personal settings will get
those files "dirty" in git.
I tried with MacOS and Linux. IntelliJ version is
{code:java}
IntelliJ IDEA 2020.1 (Ultimate Edition)
Build #IU-201.6668.121, built on April 8, 2020
Runtime version: 11.0.6+8-b765.25 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.15.3
GC: ParNew, ConcurrentMarkSweep
Memory: 8029M
Cores: 8
Non-Bundled Plugins: CheckStyle-IDEA, intellij-shellscript, com.paperetto.dash,
io.protostuff.protostuff-jetbrains-plugin, org.intellij.plugins.hcl
{code}
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025159#comment-17025159
]
Hudson commented on HBASE-23707:
Results for branch master
[build #1611 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1611/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1611//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1611//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1611//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025044#comment-17025044
]
Hudson commented on HBASE-23707:
Results for branch branch-1
[build #1214 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1214/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1214//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1214//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1214//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[
https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024633#comment-17024633
]
Hudson commented on HBASE-23707:
Results for branch branch-2
[build #2433 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2433/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2431//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2428//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2427//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2433//console].
> Add IntelliJ check style plugin configuration
> -
>
> Key: HBASE-23707
> URL: https://issues.apache.org/jira/browse/HBASE-23707
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically
> so that some configurations can be committed with the source repository. The
> checkstyle plugin configuration is one such config file; add it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration
[ https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018463#comment-17018463 ] Nick Dimiduk commented on HBASE-23707: -- FYI [~stack] [~bharathv] > Add IntelliJ check style plugin configuration > - > > Key: HBASE-23707 > URL: https://issues.apache.org/jira/browse/HBASE-23707 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > > IntelliJ defines project configuration across a number of files, specifically > so that some configurations can be committed with the source repository. The > checkstyle plugin configuration is one such config file; add it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
