[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-15 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085544#comment-13085544
 ] 

Hudson commented on HBASE-2399:
---

Integrated in HBase-TRUNK #2117 (See 
[https://builds.apache.org/job/HBase-TRUNK/2117/])
HBASE-2399  Forced splits only act on the first family in a table (Ming Ma)

tedyu : 
Files : 
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/CHANGES.txt


> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Ming Ma
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-15 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085470#comment-13085470
 ] 

Ted Yu commented on HBASE-2399:
---

Integrated to TRUNK.

Thanks for the patch Ming.

Thanks for the review Michael.

This patch is only for TRUNK. So not attaching the latest patch is Okay.

> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Ming Ma
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-15 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085372#comment-13085372
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/#review1462
---

Ship it!


- Ted


On 2011-08-15 17:58:09, Ming Ma wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1484/
bq.  ---
bq.  
bq.  (Updated 2011-08-15 17:58:09)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  1. Add tests for forcesplit multi-column-family scenarios.
bq.  2. Modify HRegion so that it picks splitpoint based on largest store, 
instead of the first splittable store. It applies to both forcesplit and 
automatic split.
bq.  
bq.  
bq.  This addresses bug hbase-2399.
bq.  https://issues.apache.org/jira/browse/hbase-2399
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 
bq.  
bq.  Diff: https://reviews.apache.org/r/1484/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ming
bq.  
bq.



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Ming Ma
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-15 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085214#comment-13085214
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/
---

(Updated 2011-08-15 17:58:09.305302)


Review request for hbase.


Changes
---

Thanks, folks. Here is the patch that fixes the whitespace issues. Should I 
upload the patch to jira?


Summary
---

1. Add tests for forcesplit multi-column-family scenarios.
2. Modify HRegion so that it picks splitpoint based on largest store, instead 
of the first splittable store. It applies to both forcesplit and automatic 
split.


This addresses bug hbase-2399.
https://issues.apache.org/jira/browse/hbase-2399


Diffs (updated)
-

  
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
  
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
  
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 

Diff: https://reviews.apache.org/r/1484/diff


Testing
---


Thanks,

Ming



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Ming Ma
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-12 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084522#comment-13084522
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/#review1441
---

Ship it!


+1 after fixing the white space (can you make a new patch Ming)  Good stuff.


http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


Nice javadoc



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


Yeah, there is more in here... you can see it up here in review board ming.



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


Nice test.


- Michael


On 2011-08-12 22:58:55, Ming Ma wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1484/
bq.  ---
bq.  
bq.  (Updated 2011-08-12 22:58:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  1. Add tests for forcesplit multi-column-family scenarios.
bq.  2. Modify HRegion so that it picks splitpoint based on largest store, 
instead of the first splittable store. It applies to both forcesplit and 
automatic split.
bq.  
bq.  
bq.  This addresses bug hbase-2399.
bq.  https://issues.apache.org/jira/browse/hbase-2399
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 
bq.  
bq.  Diff: https://reviews.apache.org/r/1484/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ming
bq.  
bq.



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-12 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084509#comment-13084509
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/#review1438
---



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


whitespace



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


whitespace here and below


- Jonathan


On 2011-08-12 22:58:55, Ming Ma wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1484/
bq.  ---
bq.  
bq.  (Updated 2011-08-12 22:58:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  1. Add tests for forcesplit multi-column-family scenarios.
bq.  2. Modify HRegion so that it picks splitpoint based on largest store, 
instead of the first splittable store. It applies to both forcesplit and 
automatic split.
bq.  
bq.  
bq.  This addresses bug hbase-2399.
bq.  https://issues.apache.org/jira/browse/hbase-2399
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 
bq.  
bq.  Diff: https://reviews.apache.org/r/1484/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ming
bq.  
bq.



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch, HBASE-2399-trunk.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-12 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084493#comment-13084493
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/#review1437
---

Ship it!



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


Remove whitespace.



http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


This was used for debugging, right ?
We may not need it.


- Ted


On 2011-08-12 22:58:55, Ming Ma wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1484/
bq.  ---
bq.  
bq.  (Updated 2011-08-12 22:58:55)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  1. Add tests for forcesplit multi-column-family scenarios.
bq.  2. Modify HRegion so that it picks splitpoint based on largest store, 
instead of the first splittable store. It applies to both forcesplit and 
automatic split.
bq.  
bq.  
bq.  This addresses bug hbase-2399.
bq.  https://issues.apache.org/jira/browse/hbase-2399
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 
bq.  
bq.  Diff: https://reviews.apache.org/r/1484/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ming
bq.  
bq.



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-12 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084443#comment-13084443
 ] 

jirapos...@reviews.apache.org commented on HBASE-2399:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1484/
---

Review request for hbase.


Summary
---

1. Add tests for forcesplit multi-column-family scenarios.
2. Modify HRegion so that it picks splitpoint based on largest store, instead 
of the first splittable store. It applies to both forcesplit and automatic 
split.


This addresses bug hbase-2399.
https://issues.apache.org/jira/browse/hbase-2399


Diffs
-

  
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
 1157283 
  
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 1157283 
  
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
 1157283 

Diff: https://reviews.apache.org/r/1484/diff


Testing
---


Thanks,

Ming



> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-11 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083902#comment-13083902
 ] 

Ted Yu commented on HBASE-2399:
---

@Ming:
You can assign this to yourself since you know what to do.

> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-2399) Forced splits only act on the first family in a table

2011-08-11 Thread Ming Ma (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083268#comment-13083268
 ] 

Ming Ma commented on HBASE-2399:


Jonathan, if you aren't looking this, I can investigate this more. It looks 
like in trunk the issue  of "if the first family isn't splittable, then whole 
region isn't split" has been fixed as part of split/compaction refactoring. The 
issue about "using first splittable family's midkey for the whole region" is 
still there. It can be fixed by picking the midkey of the family with largest 
store files size.

> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
>  Labels: moved_from_0_20_5
> Fix For: 0.92.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-2399) Forced splits only act on the first family in a table

2010-08-24 Thread Jonathan Gray (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902246#action_12902246
 ] 

Jonathan Gray commented on HBASE-2399:
--

This fix is fairly trivial.  I held it up because of larger changes to splits 
for HBASE-2375.  If that jira ends up getting punted then I will implement a 
simple fix for this jira for 0.90.

> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-2399) Forced splits only act on the first family in a table

2010-08-24 Thread Jean-Daniel Cryans (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902177#action_12902177
 ] 

Jean-Daniel Cryans commented on HBASE-2399:
---

Do we have enough time do this if 0.90.0 is due for HW? Punt?

> Forced splits only act on the first family in a table
> -
>
> Key: HBASE-2399
> URL: https://issues.apache.org/jira/browse/HBASE-2399
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 0.20.3
>Reporter: Jonathan Gray
>Assignee: Jonathan Gray
>Priority: Critical
> Fix For: 0.90.0
>
> Attachments: HBASE-2399-test-v1.patch
>
>
> While working on a patch for HBASE-2375, I came across a few bugs in the 
> existing code related to splits.
> If a user triggers a manual split, it flips a forceSplit boolean to true and 
> then triggers a compaction (this is very similar to my current implementation 
> for HBASE-2375).  However, the forceSplit boolean is flipped back to false at 
> the beginning of Store.compact().  So the force split only acts on the first 
> family in the table.  If that Store is not splittable for some reason (it is 
> empty or has only one row), then the entire region will not be split, 
> regardless of what is in other families.
> Even if there is data in the first family, the midKey is determined based 
> solely on that family.  If it has two rows and the next family has 1M rows, 
> we pick the split key based on the two rows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.