[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-20 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161591#comment-17161591
 ] 

Nick Dimiduk commented on HBASE-24376:
--

[~ruslan.sabitov] if you have more concerns on this topic, can you please take 
them to the user@ list? We try to keep JIRA (and GitHub) focused on topics of 
active development. Thanks.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-16 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159355#comment-17159355
 ] 

Huaxiang Sun commented on HBASE-24376:
--

I think in hbase-1, the normalizer uses a force flag to do the merge, which 
means that if the two regions are not next to each other, it will still merge 
them.

Are you sure that inconsistency is caused by normalizer? I.e, before normalizer 
run, table is consistent, after normalizer run, there is inconsistency. If that 
is the case, the issue is that normalizer merges two non-adjacent regions, 
which will cause overlaps. 

There is one such issue with hbase-2, but I checked the code, hbase-1 seems ok. 

You can go over the master log, dump out meta table, and inconsistency report 
from hbck to check if that is the case.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-16 Thread Ruslan Sabitov (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158914#comment-17158914
 ] 

Ruslan Sabitov commented on HBASE-24376:


[~huaxiangsun] thank you for your reply. Here is another example:

2020-06-04 17:31:59,611 INFO 
org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
merging normalization plan: MergeNormalizationPlan\{firstRegion={ENCODED => 
5d2d90c3697145c15bc2dc1841bbd140, NAME => 
'tableName,-7-7d--TPxHgzWi3x6Nw,1591257734317.5d2d90c3697145c15bc2dc1841bbd140.',
 STARTKEY => '-7-7d--TPxHgzWi3x6Nw', ENDKEY => '-F--'}, secondRegion=\{ENCODED 
=> 5efe3811574f9f390d4cc8fc6099aa18, NAME => 
'tableName,-Myro7PP4ncDkwLSQqVv,1591257751881.5efe3811574f9f390d4cc8fc6099aa18.',
 STARTKEY => '-Myro7PP4ncDkwLSQqVv', ENDKEY => '-V–'}}

 

I parsed HBase Master log and collected all lines with text 
MergeNormalizationPlan and where r1 ENDKEY is not equal r2 STARTKEY:

[https://pastebin.com/5wqr28br]

 

I'd like to add this table becomes inconsistent each time I enable 
normalization for the table. Do you have any ideas how to check that the 
problem in the normalization?

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-15 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158517#comment-17158517
 ] 

Huaxiang Sun commented on HBASE-24376:
--

Hi [~ruslan.sabitov], last time I checked, for branch-1, it is ok. In your 
case, these two regions are overlapping with each other, so it is ok. It seems 
that there is already overlaps which means the table is not at a consistent 
state.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-07-06 Thread Ruslan Sabitov (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152065#comment-17152065
 ] 

Ruslan Sabitov commented on HBASE-24376:


I faced with the issue in branch-1 (HBase 1.2.0-cdh5.16.2):

2020-07-02 16:41:18,337 INFO 
org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
merging normalization plan: MergeNormalizationPlan{firstRegion={ENC
ODED => feba09265266f1c3c090bc42cc90becc, NAME => 
'tableName,Aw-BEZ0JD4M3HrvA4Yks,1593695478557.feba09265266f1c3c090bc42cc90becc.',
 STARTKEY => 'Aw-BEZ0JD4M3HrvA4Yks', EN
DKEY => 'D0sYMT716R0tyHPGk8ii'}, secondRegion={ENCODED => 
8003ecbf849c4f5e27bf5956ec0729cc, NAME => 
'TableName,B_zjT044PCvwQ4I53Q5m,1593695479990.8003ecbf849c4f5e27bf5956
ec0729cc.', STARTKEY => 'B_zjT044PCvwQ4I53Q5m', ENDKEY => 
'FCzjFZ4Vhb0hpVtn6VxP'}}

 

 

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-26 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116912#comment-17116912
 ] 

Huaxiang Sun commented on HBASE-24376:
--

Will post a backport for 2.2.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-25 Thread Guanghao Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116344#comment-17116344
 ] 

Guanghao Zhang commented on HBASE-24376:


{quote}bq. do you want this Jira in 2.2? If so, I will do a backport to 2.2 
branch, thanks.
{quote}
Yes. Thanks.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-25 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116302#comment-17116302
 ] 

Huaxiang Sun commented on HBASE-24376:
--

Resolve it for now.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-25 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116300#comment-17116300
 ] 

Huaxiang Sun commented on HBASE-24376:
--

Hi [~zghao], do you want this Jira backport to 2.2? If so, I will do a backport 
to 2.2 branch, thanks.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-23 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114787#comment-17114787
 ] 

Hudson commented on HBASE-24376:


Results for branch branch-2.3
[build #102 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/102/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/102/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/102/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/102/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/102/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114495#comment-17114495
 ] 

Hudson commented on HBASE-24376:


Results for branch branch-2
[build #2673 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2673/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2673/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2673/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2673/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2673/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114087#comment-17114087
 ] 

Hudson commented on HBASE-24376:


Results for branch master
[build #1734 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1734/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1734/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1600//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1734/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1734/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-19 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111351#comment-17111351
 ] 

Huaxiang Sun commented on HBASE-24376:
--

[~ndimiduk], I just updated the root cause in the description, thanks for 
review.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  
> The root cause is that getMergeNormalizationPlan() uses a list of regionInfo 
> which is ordered by regionName. regionName does not necessary guarantee the 
> order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will 
> be 'aa1!' followed by 'aa1'. This will result in normalizer merging 
> non-adjacent regions into one and creates overlaps. This is not an issue in 
> branch-1 as the list is already ordered by RegionInfo.COMPARATOR in 
> normalizer.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-18 Thread Nick Dimiduk (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110650#comment-17110650
 ] 

Nick Dimiduk commented on HBASE-24376:
--

Once you're settled on the fix, mind updating the Jira description to outline 
what the problem was? Thanks!

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Critical
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

2020-05-14 Thread Huaxiang Sun (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107812#comment-17107812
 ] 

Huaxiang Sun commented on HBASE-24376:
--

FYI [~ndimiduk], kind of understand the root cause, will put a patch tomorrow.

> MergeNormalizer is merging non-adjacent regions and causing region 
> overlaps/holes.
> --
>
> Key: HBASE-24376
> URL: https://issues.apache.org/jira/browse/HBASE-24376
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.3.0
>Reporter: Huaxiang Sun
>Assignee: Huaxiang Sun
>Priority: Blocker
>
> Currently, we found normalizer was merging regions which are non-adjacent, it 
> will cause inconsistencies in the cluster.
> {code:java}
> 439055 2020-05-08 17:47:09,814 INFO 
> org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing 
> merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 
> 47fe236a5e3649ded95cb64ad0c08492, NAME => 
> 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad   
> 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => 
> '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'},
>  secondRegion={ENCODED => 0c0f2aa67f4329d5c4   8ba0320f173d31, NAME => 
> 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.',
>  STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => 
> '\x03\x01\x05\x02\x01\x02'}}
> 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: 
> CatalogJanitor-*:16000 average execution time: 1676219193 ns.
> 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: 
> Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], 
> [0c0f2aa67f4329d5c48ba0320f173d31]
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)