[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116377#comment-17116377
]
Hudson commented on HBASE-24401:
Results for branch branch-2
[build #2676 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2676/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2676/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2676/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2676/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2676/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116291#comment-17116291
]
Hudson commented on HBASE-24401:
Results for branch branch-2.2
[build #876 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/876/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/876//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/876//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/876//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116092#comment-17116092
]
Hudson commented on HBASE-24401:
Results for branch master
[build #1736 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1736/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1736/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1600//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1736/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1736/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116041#comment-17116041
]
Hudson commented on HBASE-24401:
Results for branch branch-2.3
[build #104 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/104/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/104/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/104/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/104/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/104/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112060#comment-17112060
]
Guanghao Zhang commented on HBASE-24401:
{quote}We describe this parameter in the hbase-default.xml like this "A value
of 0 or less disables the check" and we have do this check in
RSRpcServices#checkCellSizeLimit.
{quote}
Got it.
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[ https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111890#comment-17111890 ] wenbang commented on HBASE-24401: - Hi [~zghao] , I think check maxCellSize > 0 is enough to avoid exception. Can you help me to review it ? Thank you. > Cell size limit check on append should consider 0 or less value to disable > the check > > > Key: HBASE-24401 > URL: https://issues.apache.org/jira/browse/HBASE-24401 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5 >Reporter: wenbang >Assignee: wenbang >Priority: Major > > HBASE-22274 added a cell size check for append in HRegion, but did not > consider 0 and less values. > If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn > off the cell size check, all append operations will fail. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[ https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111800#comment-17111800 ] wenbang commented on HBASE-24401: - We describe this parameter in the hbase-default.xml like this "A value of 0 or less disables the check" and we have do this check in RSRpcServices#checkCellSizeLimit. I think this shoud be the same in append operations. > Cell size limit check on append should consider 0 or less value to disable > the check > > > Key: HBASE-24401 > URL: https://issues.apache.org/jira/browse/HBASE-24401 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5 >Reporter: wenbang >Assignee: wenbang >Priority: Major > > HBASE-22274 added a cell size check for append in HRegion, but did not > consider 0 and less values. > If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn > off the cell size check, all append operations will fail. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24401) Cell size limit check on append should consider 0 or less value to disable the check
[
https://issues.apache.org/jira/browse/HBASE-24401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111740#comment-17111740
]
Guanghao Zhang commented on HBASE-24401:
{quote}If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to
turn off the cell size check, all append operations will fail.
{quote}
Config *hbase.server.keyvalue.maxsize* to Long.MAX_VALUE means turn off the
cell size check?
But I thought we should add a check fot this "*hbase.server.keyvalue.maxsize*"
config, if less or equal to 0, throw exception to prevent RegionServer start?
> Cell size limit check on append should consider 0 or less value to disable
> the check
>
>
> Key: HBASE-24401
> URL: https://issues.apache.org/jira/browse/HBASE-24401
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 1.4.10, 2.3.0, 2.1.5
>Reporter: wenbang
>Assignee: wenbang
>Priority: Major
>
> HBASE-22274 added a cell size check for append in HRegion, but did not
> consider 0 and less values.
> If we set the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn
> off the cell size check, all append operations will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
