[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125445#comment-17125445
]
Hudson commented on HBASE-24412:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125363#comment-17125363
]
Hudson commented on HBASE-24412:
Results for branch branch-2.2
[build #884 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/884//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125105#comment-17125105
]
Hudson commented on HBASE-24412:
Results for branch master
[build #1746 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1600//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[
https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124946#comment-17124946
]
Hudson commented on HBASE-24412:
Results for branch branch-2.3
[build #120 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/120/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/120/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/120/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/120/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/120/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Canary support check only one column family per RegionTask
> --
>
> Key: HBASE-24412
> URL: https://issues.apache.org/jira/browse/HBASE-24412
> Project: HBase
> Issue Type: Improvement
> Components: canary
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124538#comment-17124538 ] niuyulin commented on HBASE-24412: -- [~claraxiong] 1.Could you provide some info on the use case to support checking all families and a random family? -->Reduce side effects of canary sniff on hdd cluster with large amount regions 2.Could you expose the new option in usage? -->you can config "hbase.canary.read.all.column.famliy" 3.It was nice to clean up the old code by reformatting. But this makes review difficult.Could you undo formatting and keep formatting as the last commit? -->jenkins will check PR, we'd better ensure no "-1" before merge, including code format error > Canary support check only one column family per RegionTask > -- > > Key: HBASE-24412 > URL: https://issues.apache.org/jira/browse/HBASE-24412 > Project: HBase > Issue Type: Improvement > Components: canary >Reporter: niuyulin >Assignee: niuyulin >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124513#comment-17124513 ] Guanghao Zhang commented on HBASE-24412: BTW: Comment on PR directly may be better. > Canary support check only one column family per RegionTask > -- > > Key: HBASE-24412 > URL: https://issues.apache.org/jira/browse/HBASE-24412 > Project: HBase > Issue Type: Improvement > Components: canary >Reporter: niuyulin >Assignee: niuyulin >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124512#comment-17124512 ] Guanghao Zhang commented on HBASE-24412: [~claraxiong] Sorry. I didn't noticed your comment here.. Pushed to branch-2.2+, now. Ping [~niuyulin] for the above questions. Thanks. > Canary support check only one column family per RegionTask > -- > > Key: HBASE-24412 > URL: https://issues.apache.org/jira/browse/HBASE-24412 > Project: HBase > Issue Type: Improvement > Components: canary >Reporter: niuyulin >Assignee: niuyulin >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121394#comment-17121394 ] Clara Xiong commented on HBASE-24412: - Patch looks good. # Could you provide some info on the use case to support checking all families and a random family? # Could you expose the new option in usage? # It was nice to clean up the old code by reformatting. But this makes review difficult.Could you undo formatting and keep formatting as the last commit? > Canary support check only one column family per RegionTask > -- > > Key: HBASE-24412 > URL: https://issues.apache.org/jira/browse/HBASE-24412 > Project: HBase > Issue Type: Improvement > Components: canary >Reporter: niuyulin >Assignee: niuyulin >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
