[jira] [Commented] (HBASE-24659) Calculate FIXED_OVERHEAD automatically
[
https://issues.apache.org/jira/browse/HBASE-24659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173575#comment-17173575
]
Hudson commented on HBASE-24659:
Results for branch branch-2
[build #2771 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2771/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2771/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2767//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Calculate FIXED_OVERHEAD automatically
> --
>
> Key: HBASE-24659
> URL: https://issues.apache.org/jira/browse/HBASE-24659
> Project: HBase
> Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
> Attachments: 50M-performance.pdf
>
>
> Now the FIXED_OVERHEAD in some classes are maintained manually, an we have a
> method to TestHeapSizes to confirm that the value is correct.
> But it is really hard for developers to count the fields in a complicated
> class like HRegion. Since we have the ability to calcuate the accurate size
> in UT, I think we it is also possible to calcuate it when loading the class,
> which is a one time operation so should not effect the performance too much.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24659) Calculate FIXED_OVERHEAD automatically
[
https://issues.apache.org/jira/browse/HBASE-24659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173175#comment-17173175
]
Hudson commented on HBASE-24659:
Results for branch master
[build #1806 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1806/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1806//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Calculate FIXED_OVERHEAD automatically
> --
>
> Key: HBASE-24659
> URL: https://issues.apache.org/jira/browse/HBASE-24659
> Project: HBase
> Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
> Attachments: 50M-performance.pdf
>
>
> Now the FIXED_OVERHEAD in some classes are maintained manually, an we have a
> method to TestHeapSizes to confirm that the value is correct.
> But it is really hard for developers to count the fields in a complicated
> class like HRegion. Since we have the ability to calcuate the accurate size
> in UT, I think we it is also possible to calcuate it when loading the class,
> which is a one time operation so should not effect the performance too much.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24659) Calculate FIXED_OVERHEAD automatically
[ https://issues.apache.org/jira/browse/HBASE-24659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173120#comment-17173120 ] niuyulin commented on HBASE-24659: -- [~zhangduo] [~stack] Thanks for your review > Calculate FIXED_OVERHEAD automatically > -- > > Key: HBASE-24659 > URL: https://issues.apache.org/jira/browse/HBASE-24659 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: 50M-performance.pdf > > > Now the FIXED_OVERHEAD in some classes are maintained manually, an we have a > method to TestHeapSizes to confirm that the value is correct. > But it is really hard for developers to count the fields in a complicated > class like HRegion. Since we have the ability to calcuate the accurate size > in UT, I think we it is also possible to calcuate it when loading the class, > which is a one time operation so should not effect the performance too much. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24659) Calculate FIXED_OVERHEAD automatically
[ https://issues.apache.org/jira/browse/HBASE-24659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166826#comment-17166826 ] niuyulin commented on HBASE-24659: -- [~zhangduo], I do performance test via YCSB, the version of client and server are both 3.0.0-SNAPSHOT. the different between w/ and w/o this pr is mostly within 10% > Calculate FIXED_OVERHEAD automatically > -- > > Key: HBASE-24659 > URL: https://issues.apache.org/jira/browse/HBASE-24659 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Assignee: niuyulin >Priority: Major > Attachments: 50M-performance.pdf > > > Now the FIXED_OVERHEAD in some classes are maintained manually, an we have a > method to TestHeapSizes to confirm that the value is correct. > But it is really hard for developers to count the fields in a complicated > class like HRegion. Since we have the ability to calcuate the accurate size > in UT, I think we it is also possible to calcuate it when loading the class, > which is a one time operation so should not effect the performance too much. -- This message was sent by Atlassian Jira (v8.3.4#803005)
