[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167986#comment-17167986
]
Hudson commented on HBASE-24669:
Results for branch master
[build #1798 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1798/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1798/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1798/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1798/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1798//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Assignee: niuyulin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167631#comment-17167631
]
Hudson commented on HBASE-24669:
Results for branch branch-2
[build #2762 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2762/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2762/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2742/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2757/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Assignee: niuyulin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167519#comment-17167519
]
Hudson commented on HBASE-24669:
Results for branch branch-2.3
[build #194 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/194/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/194/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/194/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/194/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/194/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Assignee: niuyulin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151548#comment-17151548
]
niuyulin commented on HBASE-24669:
--
hi, [~ndimiduk] , I submit a PR, could you help review it
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Assignee: niuyulin
>Priority: Minor
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150529#comment-17150529
]
Nick Dimiduk commented on HBASE-24669:
--
There's a difference between "parent pid" and "ppid"? What's a "ppid" then?
I think it's common to have a pid hierarchy of depth 3 or 4. I have only
noticed logging of myself (pid) and my parent (ppid). Maybe i'm
miss-understanding?
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Assignee: niuyulin
>Priority: Minor
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149782#comment-17149782
]
niuyulin commented on HBASE-24669:
--
you mean replace "parent pid" to "parent ppid"? what if parent has parent ?
{code:java}
2020-07-02,01:05:32,181 INFO [PEWorker-8]
org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished subprocedure
pid=6190915, resume processing parent pid=6190914, ppid=6190913,
state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_CLOSED, locked=true;
TransitRegionStateProcedure table=tsdb,
region=15675415356879e7020f3ede695e0803, UNASSIGN
{code}
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Priority: Minor
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences
[
https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149743#comment-17149743
]
Nick Dimiduk commented on HBASE-24669:
--
The log line I noticed is this:
{noformat}
2020-07-01 06:17:31,449 INFO
org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished subprocedure
pid=116623, resume processing parent pid=116621,
state=RUNNABLE:SERVER_CRASH_DELETE_SPLIT_MET
A_WALS_DIR, locked=true; ServerCrashProcedure
server=hbasedn189.example.com,16020,1593583050478, splitWal=true, meta=true
{noformat}
> Logging of ppid should be consistent across all occurrences
> ---
>
> Key: HBASE-24669
> URL: https://issues.apache.org/jira/browse/HBASE-24669
> Project: HBase
> Issue Type: Improvement
> Components: Operability, proc-v2
>Reporter: Nick Dimiduk
>Priority: Minor
>
> Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of
> {{parent pid}} instead of {{ppid}}. All this logging should be uniform so
> that it's easy to grep the logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
